GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper by erlend-aasland · Pull Request #24170 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jan 8, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue24464

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-24464: Call sqlite3.enable_shared_cache() from deprecation wrapper
70f8bca
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner January 8, 2021 18:33
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 8, 2021
@bedevere-bot bedevere-bot added the awaiting review label Jan 8, 2021
@erlend-aasland

erlend-aasland commented Jan 8, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for spotting this, @mrluanma.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jan 8, 2021

Copy link
Copy Markdown
Contributor Author

@berkerpeksag or @serhiy-storchaka, can one of you review and apply this? #skipnews
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland changed the title bpo-24464: Call sqlite3.enable_shared_cache() from deprecation wrapper bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper Jan 8, 2021
@erlend-aasland

erlend-aasland commented Jan 8, 2021

Copy link
Copy Markdown
Contributor Author

Regression caused by #24008
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland marked this pull request as draft January 8, 2021 19:48
Erlend E. Aasland
Fix test_shared_cache_deprecated on macOS
260bbf3
@erlend-aasland
erlend-aasland marked this pull request as ready for review January 8, 2021 20:48
@erlend-aasland

erlend-aasland commented Jan 8, 2021

Copy link
Copy Markdown
Contributor Author

Fixed macOS tests. Ready for review, @berkerpeksag / @serhiy-storchaka
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag berkerpeksag added the skip news label Jan 8, 2021
berkerpeksag
berkerpeksag requested changes Jan 8, 2021
View reviewed changes
Comment thread Lib/sqlite3/test/dbapi.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label Jan 8, 2021
@bedevere-bot

bedevere-bot commented Jan 8, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Jan 8, 2021
Erlend E. Aasland
Address review
2eb92b6
@erlend-aasland

erlend-aasland commented Jan 9, 2021

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Jan 9, 2021
@bedevere-bot

bedevere-bot commented Jan 9, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from berkerpeksag January 9, 2021 09:03
Erlend E. Aasland and others added 2 commits January 9, 2021 10:20
Erlend E. Aasland
Removed one line too many
aecdd28
@berkerpeksag
Update dbapi.py
83f1b74
berkerpeksag
berkerpeksag approved these changes Jan 9, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Jan 9, 2021
@berkerpeksag
berkerpeksag merged commit d16f617 into python:master Jan 9, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 9, 2021
@berkerpeksag

berkerpeksag commented Jan 9, 2021

Copy link
Copy Markdown
Member

Thank you.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland deleted the bpo-24464-fix branch January 9, 2021 11:50
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper (pyt…
7825cfe 
…honGH-24170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @bedevere-bot @berkerpeksag @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.