GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-24464: Deprecate sqlite3.enable_shared_cache by erlend-aasland · Pull Request #24008 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Dec 30, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue24464

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-24464: Deprecate sqlite3.enable_shared_cache
4969fef
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner December 30, 2020 13:54
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 30, 2020
@bedevere-bot bedevere-bot added the awaiting review label Dec 30, 2020
Erlend E. Aasland
Add NEWS
86e95b6
@erlend-aasland

erlend-aasland commented Dec 30, 2020

Copy link
Copy Markdown
Contributor Author

cc @ned-deily, @ronaldoussoren
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Dec 30, 2020

Copy link
Copy Markdown
Contributor Author

FYI https://sqlite.org/c3ref/enable_shared_cache.html:
"Shared cache is disabled by default. It is recommended that it stay that way. In other words, do not use this routine. This interface continues to be provided for historical compatibility, but its use is discouraged. Any use of shared cache is discouraged."
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ZackerySpytz
ZackerySpytz reviewed Dec 31, 2020
View reviewed changes
Comment thread Doc/whatsnew/3.10.rst Outdated
(Contributed by Erlend E. Aasland in :issue:`42264`.)

* ``sqlite3.enable_shared_cache`` is now deprecated, scheduled for removal in
Python 3.12. The method is undocumented, and it's use is strongly

@ZackerySpytz ZackerySpytz Dec 31, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Python 3.12. The method is undocumented, and it's use is strongly
Python 3.12. The method is undocumented, and its use is strongly

It is incorrect to use a contraction here.

Also, it seems that sqlite3.enable_shared_cache is not a method.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@erlend-aasland erlend-aasland Dec 31, 2020

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it seems that sqlite3.enable_shared_cache is not a method.

Correct, it's a built-in function. Good catch.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@erlend-aasland erlend-aasland Dec 31, 2020

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 7d52671. Is the new phrasing acceptable?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Library/2020-12-30-14-56-25.bpo-24464.vbNVHe.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2020-12-30-14-56-25.bpo-24464.vbNVHe.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend Egeberg Aasland and others added 4 commits December 31, 2020 20:05
Erlend Egeberg Aasland @ZackerySpytz
Fix typo: it's => its
13a1eb1 
Co-authored-by: Zackery Spytz <[email protected]>
Erlend Egeberg Aasland @ZackerySpytz
Add missing punctuation mark.
f93c455 
Co-authored-by: Zackery Spytz <[email protected]>
Erlend Egeberg Aasland @ZackerySpytz
Fix typo: it's => its
5fa5918 
Co-authored-by: Zackery Spytz <[email protected]>
Erlend E. Aasland
Address review: it's not a method, it's a built-in function
7d52671
@erlend-aasland

erlend-aasland commented Dec 31, 2020

Copy link
Copy Markdown
Contributor Author

PTAL, @ZackerySpytz
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 requested a review from ronaldoussoren January 1, 2021 12:26
merwok
merwok reviewed Jan 4, 2021
View reviewed changes
Comment thread Lib/sqlite3/dbapi2.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
merwok
merwok reviewed Jan 4, 2021
View reviewed changes
Comment thread Lib/sqlite3/dbapi2.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland added 2 commits January 4, 2021 23:34
Erlend E. Aasland
Address review: Make override reload safe
03e36d0
Erlend E. Aasland
Address review: Improve formatting
cd11c78
merwok
merwok reviewed Jan 4, 2021
View reviewed changes
Comment thread Lib/sqlite3/dbapi2.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland and others added 2 commits January 5, 2021 00:09
Erlend E. Aasland
Improve scope
97b0452
@berkerpeksag
fix url markup
cf5dca4
berkerpeksag
berkerpeksag approved these changes Jan 6, 2021
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 6, 2021
@erlend-aasland

erlend-aasland commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, and thanks for the markup fix, @berkerpeksag !
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag

berkerpeksag commented Jan 6, 2021

Copy link
Copy Markdown
Member

All failed tests seem to be unrelated and flaky. Will continue with merge.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag
berkerpeksag merged commit ddb5e11 into python:master Jan 6, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 6, 2021
@erlend-aasland
erlend-aasland deleted the sqlite-shared-cache branch January 6, 2021 00:36
@erlend-aasland erlend-aasland mentioned this pull request Jan 8, 2021
bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper #24170
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-24464: Deprecate sqlite3.enable_shared_cache (pythonGH-24008)
f2c6a84
This was referenced May 9, 2022
sqlite3: remove features deprecated in 3.10 #92547
Closed
gh-92547: Remove deprecated sqlite3 features #92548
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request May 9, 2022
@erlend-aasland
pythongh-92547: Remove deprecated sqlite3 features
8312697 
The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

- sqlite3.OptimizedUnicode (pythongh-23163)
- sqlite3.enable_shared_cache (pythongh-24008)

Signed-off-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request May 16, 2022
@erlend-aasland @JelleZijlstra
gh-92547: Remove deprecated sqlite3 features (#92548)
00f22e8 
The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

- sqlite3.OptimizedUnicode (gh-23163)
- sqlite3.enable_shared_cache (gh-24008)

Co-authored-by: Jelle Zijlstra <[email protected]>
Signed-off-by: Erlend E. Aasland <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 5, 2022
gh-93370 : Deprecate sqlite3.version and sqlite3.version_info #93482
Merged
@brianschubert brianschubert mentioned this pull request Aug 1, 2025
[sqlite3] Deprecate enable_shared_cache from dbapi2 python/typeshed#14501
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments
@berkerpeksag berkerpeksag berkerpeksag approved these changes
@ronaldoussoren ronaldoussoren Awaiting requested review from ronaldoussoren
+1 more reviewer
@ZackerySpytz ZackerySpytz ZackerySpytz left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@erlend-aasland @berkerpeksag @merwok @ZackerySpytz @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.