GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41824: Add versionadded for typing.ForwardRef docs by Fidget-Spinner · Pull Request #24224 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Jan 15, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

typing.ForwardRef officially became part of the documented public API in GH-14216 (19 Jun 2019). I'm interpolating a little and guessing it landed in Python 3.7.4 according to PEP 537's schedule https://www.python.org/dev/peps/pep-0537/#id3.

https://bugs.python.org/issue41824

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
domdfcoding reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Fidget-Spinner
Add versionadded for typing.ForwardRef
abac0a2
@Fidget-Spinner
Fidget-Spinner requested review from gvanrossum and ilevkivskyi as code owners January 15, 2021 16:29
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 15, 2021
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 15, 2021
@Fidget-Spinner
remove trailing whitespace
a29bace
@Fidget-Spinner

Fidget-Spinner commented Jan 15, 2021

Copy link
Copy Markdown
Member Author

I'm guessing this should be backported to 3.9 and 3.8 (along with skip news)?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tirkarthi tirkarthi added skip issue skip news labels Jan 20, 2021
gvanrossum
gvanrossum approved these changes Feb 9, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 9, 2021
@gvanrossum
gvanrossum merged commit da21f7b into python:master Feb 9, 2021
@bedevere-bot

bedevere-bot commented Feb 9, 2021

Copy link
Copy Markdown

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 9, 2021
@Fidget-Spinner

Fidget-Spinner commented Feb 9, 2021

Copy link
Copy Markdown
Member Author

@gvanrossum Thanks Guido! Should this be backported to 3.9/3.8 too?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Feb 9, 2021

Copy link
Copy Markdown
Member

@gvanrossum Thanks Guido! Should this be backported to 3.9/3.8 too?

Sure.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner

Fidget-Spinner commented Feb 9, 2021

Copy link
Copy Markdown
Member Author

@gvanrossum Thanks Guido! Should this be backported to 3.9/3.8 too?

Sure.

Sorry to trouble, can you add the labels for them please? I don't have permissions to. Though I'm not sure if the bot will pick it up if the label is applied after the PR is merged rather than before. Either way I'm fine with manually backporting them too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum added needs backport to 3.8 labels Feb 9, 2021
@miss-islington

miss-islington commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

Thanks @Fidget-Spinner for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

Thanks @Fidget-Spinner for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Feb 9, 2021

Copy link
Copy Markdown
Member

Looks like the bot picked it up!
Fidget-Spinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

Sorry, @Fidget-Spinner and @gvanrossum, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker da21f7b6e1fd5bd3e78931a06c5eb694f6335233 3.8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned gvanrossum Feb 9, 2021
@miss-islington

miss-islington commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

Sorry @Fidget-Spinner and @gvanrossum, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker da21f7b6e1fd5bd3e78931a06c5eb694f6335233 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner

Fidget-Spinner commented Feb 9, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Aww I guess I should've done it manually from the start then. Thanks for the help anyways!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Feb 9, 2021
@bedevere-bot

bedevere-bot commented Feb 9, 2021

Copy link
Copy Markdown

GH-24493 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner added a commit to Fidget-Spinner/cpython that referenced this pull request Feb 9, 2021
@Fidget-Spinner
[3.8] bpo-41824: Add versionadded for typing.ForwardRef docs (python#…
ca1f14b 
…24224)
@bedevere-bot

bedevere-bot commented Feb 9, 2021

Copy link
Copy Markdown

GH-24494 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Feb 9, 2021
gvanrossum pushed a commit that referenced this pull request Feb 9, 2021
@Fidget-Spinner
bpo-41824: Add versionadded for typing.ForwardRef docs (#24224) (#24493)
917eca7
gvanrossum pushed a commit that referenced this pull request Feb 9, 2021
@Fidget-Spinner
[3.8] bpo-41824: Add versionadded for typing.ForwardRef docs (#24224) (…
c8a48c6 
…#24494)
@Fidget-Spinner
Fidget-Spinner deleted the patch-1 branch February 9, 2021 16:59
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@Fidget-Spinner @adorilson
bpo-41824: Add versionadded for typing.ForwardRef docs (python#24224)
6f8e162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gvanrossum gvanrossum

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Fidget-Spinner @bedevere-bot @gvanrossum @miss-islington @tirkarthi @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.