GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-36985: Document typing.ForwardRef by ilevkivskyi · Pull Request #14216 · python/cpython

Conversation

@ilevkivskyi

@ilevkivskyi ilevkivskyi commented Jun 19, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue36985

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ilevkivskyi ilevkivskyi added skip news needs backport to 3.7 labels Jun 19, 2019
@ilevkivskyi
ilevkivskyi requested a review from gvanrossum June 19, 2019 00:19
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 19, 2019
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Jun 19, 2019
asottile
asottile approved these changes Jun 19, 2019
View reviewed changes
@ilevkivskyi
Document typing.ForwardRef
60c140e
gvanrossum
gvanrossum approved these changes Jun 19, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 19, 2019
@ilevkivskyi
ilevkivskyi merged commit 809ff11 into python:master Jun 19, 2019
@miss-islington

miss-islington commented Jun 19, 2019

Copy link
Copy Markdown
Contributor

Thanks @ilevkivskyi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Jun 19, 2019
@ilevkivskyi
ilevkivskyi deleted the document-forwardref branch June 19, 2019 00:31
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2019
@ilevkivskyi @miss-islington
Document typing.ForwardRef (pythonGH-14216)
357b2ff
(cherry picked from commit 809ff11)

Co-authored-by: Ivan Levkivskyi <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 19, 2019

Copy link
Copy Markdown

GH-14217 is a backport of this pull request to the 3.8 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Jun 19, 2019
@miss-islington

miss-islington commented Jun 19, 2019

Copy link
Copy Markdown
Contributor

Sorry, @ilevkivskyi, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 809ff1181ccc09c3b629f3d0ec66e13eaa111b2e 3.7

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington miss-islington assigned ilevkivskyi Jun 19, 2019
miss-islington added a commit that referenced this pull request Jun 19, 2019
@miss-islington @ilevkivskyi
Document typing.ForwardRef (GH-14216)
fff695b
(cherry picked from commit 809ff11)

Co-authored-by: Ivan Levkivskyi <[email protected]>
ilevkivskyi added a commit to ilevkivskyi/cpython that referenced this pull request Jun 19, 2019
@ilevkivskyi
Document typing.ForwardRef (pythonGH-14216)
5d51baf
Conflicts:
	Doc/library/typing.rst
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Jun 19, 2019
@bedevere-bot

bedevere-bot commented Jun 19, 2019

Copy link
Copy Markdown

GH-14220 is a backport of this pull request to the 3.7 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit that referenced this pull request Jun 19, 2019
@ilevkivskyi @miss-islington
[3.7] bpo-36985: Document typing.ForwardRef (GH-14216) (GH-14220)
d058735
https://bugs.python.org/issue36985
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Jun 21, 2019
@CuriousLearner
Merge branch 'master' into fix-issue24255
7bf6445
* master: (599 commits)
  Docs: Improved phrasing (pythonGH-14069)
  Remove redundant if check from optional argument function in argparse. (pythonGH-8766)
  bpo-37289: Add a test for if with ifexpr in the peephole optimiser to detect regressions (pythonGH-14127)
  Update What's New in Python 3.9 (pythonGH-14253)
  bpo-36511: Improve ARM32 buildbot scripts (pythonGH-14251)
  bpo-37151: remove _PyCFunction_FastCallDict (pythonGH-14269)
  Fix typo, 'widger' -> 'widget', in idlelib/tree.py (pythonGH-14263)
  Fix bpo number in News file. (pythonGH-14260)
  bpo-37342: Fix the incorrect nb_index's type in typeobj documentation (pythonGH-14241)
  Update What's New in Python 3.8 (pythonGH-14239)
  bpo-36710: Use tstate in pylifecycle.c (pythonGH-14249)
  Add missing single quote in io.TextIOWrapper.reconfigure documentation (pythonGH-14246)
  bpo-36511: Add buildbot scripts and fix tests for Windows ARM32 buildbot (pythonGH-13454)
  bpo-37333: Ensure IncludeTkinter has a value (pythonGH-14240)
  bpo-37331: Clarify format of socket handler messages in the documentation. (pythonGH-14234)
  bpo-37258: Not a bug, but added a unit test and updated documentation. (pythonGH-14229)
  bpo-36710: Remove PyImport_Cleanup() function (pythonGH-14221)
  Fix name of '\0'. (pythonGH-14222)
  bpo-36710: Add tstate parameter in import.c (pythonGH-14218)
  Document typing.ForwardRef (pythonGH-14216)
  ...
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@ilevkivskyi @lisroach
Document typing.ForwardRef (pythonGH-14216)
50862ae
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@ilevkivskyi @DinoV
Document typing.ForwardRef (pythonGH-14216)
c58299a
@Fidget-Spinner Fidget-Spinner mentioned this pull request Jan 15, 2021
bpo-41824: Add versionadded for typing.ForwardRef docs #24224
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
+1 more reviewer
@asottile asottile asottile approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ilevkivskyi ilevkivskyi

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@ilevkivskyi @miss-islington @bedevere-bot @asottile @gvanrossum @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.