GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-20364: Improve sqlite3 placeholder docs by erlend-aasland · Pull Request #25003 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Mar 23, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Co-authored-by: Terry J. Reedy

https://bugs.python.org/issue20364

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Erlend E. Aasland
bpo-20364: Improve sqlite3 placeholder docs
b646138
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner March 23, 2021 21:56
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 23, 2021
@bedevere-bot bedevere-bot added the awaiting review label Mar 23, 2021
@erlend-aasland

erlend-aasland commented Mar 23, 2021

Copy link
Copy Markdown
Contributor Author

@berkerpeksag, @terryjreedy: would you mind taking a look at this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland added 2 commits March 23, 2021 23:05
Erlend E. Aasland
Fix default role
91962aa
Erlend E. Aasland
Fix executemany()
ebc7c1a
@berkerpeksag berkerpeksag added the skip news label Mar 27, 2021
erlend-aasland
erlend-aasland commented Apr 2, 2021
View reviewed changes
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland
Simplify execute() docs
74618e8
Fidget-Spinner
Fidget-Spinner reviewed Apr 5, 2021
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an sqllite3 expert by any means, so I'll leave verifying the content's accuracy to someone else ;).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend Egeberg Aasland @Fidget-Spinner
parametrized => parameterized
f19c531
Co-authored-by: Ken Jin <[email protected]>
@erlend-aasland

erlend-aasland commented Apr 5, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, @Fidget-Spinner, I appreciate your comments 😃

Fidget-Spinner reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland
Address review: statement => SQL statement
1482f21
Fidget-Spinner
Fidget-Spinner approved these changes Apr 13, 2021
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for improving the docs :).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Apr 13, 2021
berkerpeksag
berkerpeksag requested changes Apr 14, 2021
View reviewed changes
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/includes/sqlite3/execute_1.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Apr 14, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels Apr 14, 2021
Erlend E. Aasland added 2 commits April 14, 2021 13:00
Erlend E. Aasland
Address review: beautify xkcd link
ade4fdd
Erlend E. Aasland
Address review: use programming languages as example database
39801ac
berkerpeksag
berkerpeksag reviewed Apr 14, 2021
View reviewed changes
Comment thread Doc/includes/sqlite3/execute_1.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland
Address review: get rid of more temp vars
1dc6531
@erlend-aasland

erlend-aasland commented Apr 14, 2021

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting changes label Apr 14, 2021
@bedevere-bot

bedevere-bot commented Apr 14, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added the awaiting change review label Apr 14, 2021
@bedevere-bot
bedevere-bot requested a review from berkerpeksag April 14, 2021 11:29
@berkerpeksag

berkerpeksag commented Apr 14, 2021

Copy link
Copy Markdown
Member

Ah, can you also fix the following error?

Warning, treated as error:
[library/sqlite3:98] ":name" found in "cur.execute("select * from lang where lang_name=:name and lang_age=:age","
Makefile:49: recipe for target 'build' failed

You'll probably need to update Doc/tools/susp-ignored.csv.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland
Adapt sqlite3 suspicious doc rules
c2366b5
@erlend-aasland

erlend-aasland commented Apr 14, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

You'll probably need to update Doc/tools/susp-ignored.csv.

Oh, I've never seen this before :) c2366b5 did not fix it, but I discovered the make suspicious target in Doc. Fix comin' up pretty soon.

UPDATE: Done. Fixed in f3ed86e

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland
Fix suspicious rules
f3ed86e
@erlend-aasland

erlend-aasland commented Apr 14, 2021

Copy link
Copy Markdown
Contributor Author

Since this is a doc update, we'd want to backport it to 3.9 and 3.8, right?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

berkerpeksag
berkerpeksag approved these changes Apr 14, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Apr 14, 2021
@berkerpeksag berkerpeksag added the needs backport to 3.9 label Apr 14, 2021
@berkerpeksag
berkerpeksag merged commit 3386ca0 into python:master Apr 14, 2021
@miss-islington

miss-islington commented Apr 14, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Apr 14, 2021
@erlend-aasland
erlend-aasland deleted the bpo-20364 branch April 14, 2021 12:29
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 14, 2021
Erlend Egeberg Aasland @miss-islington
bpo-20364: Improve sqlite3 placeholder docs (pythonGH-25003)
8827074
(cherry picked from commit 3386ca0)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Apr 14, 2021

Copy link
Copy Markdown

GH-25402 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Apr 14, 2021
@erlend-aasland

erlend-aasland commented Apr 14, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, @berkerpeksag !

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

berkerpeksag pushed a commit that referenced this pull request Apr 14, 2021
@miss-islington Erlend Egeberg Aasland
bpo-20364: Improve sqlite3 placeholder docs (GH-25003)
95e4431
(cherry picked from commit 3386ca0)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request May 10, 2021
bpo-44106: Improve sqlite3 example database contents #26027
Merged
@erlend-aasland erlend-aasland mentioned this pull request Jul 27, 2022
Improve the sqlite3 reference #95273
Closed
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes
@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@erlend-aasland @bedevere-bot @berkerpeksag @miss-islington @Fidget-Spinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.