GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-44106: Improve sqlite3 example database contents by erlend-aasland · Pull Request #26027 · python/cpython

Conversation

erlend-aasland commented May 10, 2021 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Use programming languages iso. politicians as example content.

https://bugs.python.org/issue44106

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          bpo-44106: Don't use politicians as example database

d30184f

erlend-aasland requested a review from berkerpeksag as a code owner

May 10, 2021 22:51

bedevere-bot added the awaiting review label

May 10, 2021

the-knights-who-say-ni added the CLA signed label

May 10, 2021

erlend-aasland commented May 10, 2021

Copy link

Copy Markdown

Contributor Author

Ref. #25003 (comment)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland requested a review from Fidget-Spinner

May 10, 2021 22:52

Erlend E. Aasland added 2 commits

May 11, 2021 00:54


          Add NEWS

e0db380


          Update suspicious rules

70da048

berkerpeksag requested changes

May 11, 2021

View reviewed changes

Comment thread

Doc/includes/sqlite3/execsql_fetchonerow.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/includes/sqlite3/createdb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/includes/sqlite3/simple_tableprinter.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/Documentation/2021-05-11-00-54-14.bpo-44106.grCmuu.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented May 11, 2021

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting changes and removed awaiting review labels

May 11, 2021

berkerpeksag added needs backport to 3.10 skip news labels

May 11, 2021

zware reviewed

May 11, 2021

View reviewed changes

Comment thread

Doc/includes/sqlite3/ctx_manager.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/includes/sqlite3/insert_more_people.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland added 5 commits

May 11, 2021 07:21


          Address review: drop unneeded parens

8e79018


          Address review: drop unneeded constants

64b9923


          Address review: drop NEWS entry


          Address review: complete incomplete fix

174fcef


          Address review: fix inconsistent naming

7429f7a

erlend-aasland commented May 11, 2021

Copy link

Copy Markdown

Contributor Author

I have made the requested changes; please review again

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting change review and removed awaiting changes labels

May 11, 2021

bedevere-bot commented May 11, 2021

Copy link

Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot requested a review from berkerpeksag

May 11, 2021 07:10

Fidget-Spinner approved these changes

May 11, 2021

View reviewed changes

Fidget-Spinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I learnt something new about programming languages while learning about sqllite :).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland and domdfcoding reacted with laugh emoji

All reactions

😄 2 reactions

Comment thread

Doc/includes/sqlite3/createdb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland mentioned this pull request

May 18, 2021

bpo-30593: Document that sqlite3.Cursor.executescript disregards isolation_level #26220

Merged


          Update simple_tableprinter.py

berkerpeksag approved these changes

May 19, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels

May 19, 2021

berkerpeksag merged commit 92d1064 into python:main

May 19, 2021

miss-islington commented May 19, 2021

Copy link

Copy Markdown

Contributor

Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed awaiting merge needs backport to 3.10 labels

May 19, 2021

bedevere-bot commented May 19, 2021

Copy link

Copy Markdown

GH-26232 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 19, 2021


          bpo-44106: Improve sqlite3 example database contents (pythonGH-26027)

d92c7f4

(cherry picked from commit 92d1064)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 19, 2021


          bpo-44106: Improve sqlite3 example database contents (pythonGH-26027)

3a0373e

(cherry picked from commit 92d1064)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

bedevere-bot commented May 19, 2021

Copy link

Copy Markdown

GH-26233 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.9 label

May 19, 2021

berkerpeksag pushed a commit that referenced this pull request

May 19, 2021


          bpo-44106: Improve sqlite3 example database contents (GH-26027)

db20afe

(cherry picked from commit 92d1064)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

berkerpeksag pushed a commit that referenced this pull request

May 19, 2021


          bpo-44106: Improve sqlite3 example database contents (GH-26027)

3185bc9

(cherry picked from commit 92d1064)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

erlend-aasland mentioned this pull request

May 19, 2021

bpo-44106: Purge stale examples from sqlite3 documentation #26234

Merged

erlend-aasland deleted the sqlite-examples branch

May 19, 2021 07:47

pablogsal mentioned this pull request

Jul 18, 2021

[3.10] Correct the order of regen-abidump #27228

Closed

Reviewers

zware

zware left review comments

berkerpeksag

berkerpeksag approved these changes

Fidget-Spinner

Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented May 10, 2021 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented May 10, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented May 11, 2021

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented May 11, 2021

Uh oh!

bedevere-bot commented May 11, 2021

Uh oh!

Fidget-Spinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington commented May 19, 2021

Uh oh!

bedevere-bot commented May 19, 2021

Uh oh!

bedevere-bot commented May 19, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

erlend-aasland commented May 10, 2021 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.