GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-30593: Document that sqlite3.Cursor.executescript disregards isolation_level by erlend-aasland · Pull Request #26220 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 18, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue30593

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-30593: Document that sqlite3.Cursor.executescript disregards isol…
64a4159 
…ation level
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner May 18, 2021 22:12
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 18, 2021
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels May 18, 2021
@erlend-aasland
erlend-aasland requested a review from Fidget-Spinner May 18, 2021 22:12
@erlend-aasland

erlend-aasland commented May 18, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@pablogsal I'm adding skip news to this. Can be backported to 3.10 and 3.9 (3.8 doesn't even get doc updates anymore, right?).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland added skip news needs backport to 3.10 labels May 18, 2021
@pablogsal

pablogsal commented May 18, 2021

Copy link
Copy Markdown
Member

@pablogsal I'm adding skip news to this. Can be backported to 3.10 and 3.9 (3.8 doesn't even get doc updates anymore, right?).

Yep, docs changes can almost always be backported!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes May 18, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 18, 2021
@erlend-aasland

erlend-aasland commented May 18, 2021

Copy link
Copy Markdown
Contributor Author

Yep, docs changes can almost always be backported!

All right :) Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland added needs backport to 3.8 labels May 18, 2021
@erlend-aasland

erlend-aasland commented May 18, 2021

Copy link
Copy Markdown
Contributor Author

But I note that Berker chose only to apply backport labels for 3.10 and 3.9 to GH-26027. Maybe do likewise here?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented May 18, 2021

Copy link
Copy Markdown
Member

But I note that Berker chose only to apply backport labels for 3.10 and 3.9 to GH-26027. Maybe do likewise here?

I don't see personally any problem of improving the docs of all versions even if they are in sec fixes only, bit maybe I am missing some context...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag berkerpeksag removed the needs backport to 3.8 label May 19, 2021
berkerpeksag
berkerpeksag approved these changes May 19, 2021
View reviewed changes
@berkerpeksag
berkerpeksag merged commit 9014437 into python:main May 19, 2021
@miss-islington

miss-islington commented May 19, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 19, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2021
Erlend Egeberg Aasland @miss-islington
bpo-30593: Doc'ed that executescript() disregards isolation level (py…
b9461c1 
…thonGH-26220)

(cherry picked from commit 9014437)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented May 19, 2021

Copy link
Copy Markdown

GH-26230 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label May 19, 2021
@erlend-aasland
erlend-aasland deleted the bpo-30593 branch May 19, 2021 07:06
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2021
Erlend Egeberg Aasland @miss-islington
bpo-30593: Doc'ed that executescript() disregards isolation level (py…
3605012 
…thonGH-26220)

(cherry picked from commit 9014437)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label May 19, 2021
@bedevere-bot

bedevere-bot commented May 19, 2021

Copy link
Copy Markdown

GH-26231 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented May 19, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, Berker & Pablo!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag

berkerpeksag commented May 19, 2021

Copy link
Copy Markdown
Member

I don't see personally any problem of improving the docs of all versions even if they are in sec fixes only, bit maybe I am missing some context...

It's because historically online documentation of security-fix-only branches weren't updated daily.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
berkerpeksag pushed a commit that referenced this pull request May 19, 2021
@miss-islington Erlend Egeberg Aasland
bpo-30593: Doc'ed that executescript() disregards isolation level (GH…
76ed53c 
…-26220)

(cherry picked from commit 9014437)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
berkerpeksag pushed a commit that referenced this pull request May 19, 2021
@miss-islington Erlend Egeberg Aasland
bpo-30593: Doc'ed that executescript() disregards isolation level (GH…
1f483c0 
…-26220)

(cherry picked from commit 9014437)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jul 27, 2022
Improve the sqlite3 reference #95273
Closed
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes
@pablogsal pablogsal pablogsal approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@erlend-aasland @pablogsal @miss-islington @bedevere-bot @berkerpeksag @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.