GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44348: Revert "bpo-39573: Py_TYPE becomes a static inline function (GH-26493)" by pablogsal · Pull Request #26596 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Jun 8, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit f3fa63e as is
causing crashes in some Windows tests in the buildbots.

https://bugs.python.org/issue44348

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
bpo-44348: Revert "bpo-39573: Py_TYPE becomes a static inline function (
9737fa5 
pythonGH-26493)"

This reverts commit f3fa63e as is
causing crashes in some Windows tests in the buildbots.
@pablogsal
pablogsal requested a review from vstinner June 8, 2021 11:07
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 8, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jun 8, 2021
@pablogsal
pablogsal merged commit 6d518bb into python:main Jun 8, 2021
@pablogsal
pablogsal deleted the bpo-44348 branch June 8, 2021 11:24
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 8, 2021
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jun 8, 2021
bpo-43693: Un-revert commit f3fa63e. #26609
Merged
ericsnowcurrently added a commit that referenced this pull request Jun 8, 2021
@ericsnowcurrently
bpo-43693: Un-revert commit f3fa63e. (#26609)
3e1c716 
This was reverted in GH-26596 (commit 6d518bb) due to some bad memory accesses.

* Add the MAKE_CELL opcode. (gh-26396)

The memory accesses have been fixed.

https://bugs.python.org/issue43693
@vstinner vstinner mentioned this pull request Mar 12, 2024
[C API] Avoid accessing PyObject and PyVarObject members directly: add Py_SET_TYPE() and Py_IS_TYPE(), disallow Py_TYPE(obj)=type #83754
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.