GeezerVison

serhiy-storchaka requested a review from rhettinger

June 11, 2021 18:22

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the awaiting core review label

serhiy-storchaka commented

View reviewed changes

Comment thread

Lib/test/test_decimal.py

		self.assertEqual(hashit(value), hashit(int(value)))

		#the same hash that to an int
		self.assertEqual(hashit(Decimal(23)), hashit(23))

serhiy-storchaka Jun 11, 2021

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covered by tests above.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_decimal.py

Comment on lines -1822 to -1823

		self.assertTrue(hashit(Decimal('Inf')))
		self.assertTrue(hashit(Decimal('-Inf')))

serhiy-storchaka Jun 11, 2021

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covered by tests below.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_decimal.py


		#the same hash that to an int
		self.assertEqual(hashit(Decimal(23)), hashit(23))
		self.assertRaises(TypeError, hash, Decimal('sNaN'))

serhiy-storchaka Jun 11, 2021

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to test_hash_method_nan.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mdickinson approved these changes

View reviewed changes

mdickinson left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting core review labels

serhiy-storchaka merged commit 9f1c5f6 into python:main

bedevere-bot removed the awaiting merge label

serhiy-storchaka deleted the hash-nan branch

June 12, 2021 12:15

serhiy-storchaka added the needs backport to 3.10 label

miss-islington commented Jun 13, 2021

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Jun 13, 2021

Copy link

Copy Markdown

GH-26706 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.10 label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request


          bpo-43475: Fix the Python implementation of hash of Decimal NaN (pyth…

ed58970

…onGH-26679)

(cherry picked from commit 9f1c5f6)

Co-authored-by: Serhiy Storchaka <[email protected]>

miss-islington added a commit that referenced this pull request