GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-28556: Various updates to typing by ilevkivskyi · Pull Request #28 · python/cpython

Conversation

@ilevkivskyi

@ilevkivskyi ilevkivskyi commented Feb 11, 2017

Copy link
Copy Markdown
Member

This PR contains various updates from upstream python/typing repo:

  • Added typing.Counter and typing.ChainMap generics
  • More flexible typing.NamedTuple
  • Improved generic ABC caching
  • More tests
  • Bugfixes
  • Other updates

This should be backported to 3.6 and 3.5 branches.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ilevkivskyi
Various updates to typing
327bdb4
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 11, 2017
@Mariatta Mariatta added backport to 3.5 labels Feb 11, 2017
@ilevkivskyi ilevkivskyi mentioned this pull request Feb 11, 2017
Add some tests based on coverage report: Part 2 python/typing#375
Merged
gvanrossum
gvanrossum approved these changes Feb 12, 2017
View reviewed changes
@gvanrossum

gvanrossum commented Feb 12, 2017

Copy link
Copy Markdown
Member

Oh, this should probably also include a Misc/NEWS update.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ilevkivskyi
Add Misc/NEWS entry
9210c5a
@ilevkivskyi

ilevkivskyi commented Feb 12, 2017

Copy link
Copy Markdown
Member Author

I added a short entry (note that there is no issue for this, so that I referenced this PR #28)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gvanrossum

gvanrossum commented Feb 12, 2017 via email

Copy link
Copy Markdown
Member
How about http://bugs.python.org/issue28556 ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ilevkivskyi
Add issue number
400be95
@ilevkivskyi

ilevkivskyi commented Feb 12, 2017

Copy link
Copy Markdown
Member Author

OK, I added the reference to the omnibus issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@codecov

codecov Bot commented Feb 12, 2017

Copy link
Copy Markdown

Codecov Report

Merging #28 into master will increase coverage by 0.01%.
The diff coverage is 94.64%.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   82.37%   82.38%   +0.01%     
==========================================
  Files        1427     1428       +1     
  Lines      350948   351138     +190     
==========================================
+ Hits       289088   289285     +197     
+ Misses      61860    61853       -7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ffb99...400be95. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ilevkivskyi ilevkivskyi changed the title Various updates to typing bpo-28556: Various updates to typing Feb 12, 2017
@gvanrossum

gvanrossum commented Feb 13, 2017

Copy link
Copy Markdown
Member

I'm hoping some core dev will take kindly to this and merge it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brettcannon
brettcannon approved these changes Feb 13, 2017
View reviewed changes
@brettcannon

brettcannon commented Feb 13, 2017

Copy link
Copy Markdown
Member

LGTM, but I don't have the time to do the merge + cherry-picks on this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Mariatta
Mariatta merged commit b692dc8 into python:master Feb 13, 2017
@Mariatta

Mariatta commented Feb 13, 2017

Copy link
Copy Markdown
Member

Will cherry-pick shortly

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mariatta referenced this pull request in Mariatta/cpython Feb 13, 2017
@ilevkivskyi @Mariatta
bpo-28556: Various updates to typing (#28)
8d3f5f6
 various updates from upstream python/typing repo:

- Added typing.Counter and typing.ChainMap generics
- More flexible typing.NamedTuple
- Improved generic ABC caching
- More tests
- Bugfixes
- Other updates

* Add Misc/NEWS entry

* Add issue number

(cherry picked from commit b692dc8)
@Mariatta Mariatta removed the backport to 3.6 label Feb 13, 2017
Mariatta referenced this pull request in Mariatta/cpython Feb 13, 2017
@ilevkivskyi @Mariatta
bpo-28556: Various updates to typing (#28)
ffdf67d
 various updates from upstream python/typing repo:

- Added typing.Counter and typing.ChainMap generics
- More flexible typing.NamedTuple
- Improved generic ABC caching
- More tests
- Bugfixes
- Other updates

* Add Misc/NEWS entry

* Add issue number

(cherry picked from commit b692dc8)
@Mariatta Mariatta removed the backport to 3.5 label Feb 13, 2017
@Mariatta

Mariatta commented Feb 13, 2017

Copy link
Copy Markdown
Member

Cherry-picked in:
#78
#77

brettcannon reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mariatta added a commit that referenced this pull request Feb 13, 2017
@Mariatta
bpo-28556: Various updates to typing (#28) (#78)
9c5684e
various updates from upstream python/typing repo:

- Added typing.Counter and typing.ChainMap generics
- More flexible typing.NamedTuple
- Improved generic ABC caching
- More tests
- Bugfixes
- Other updates

* Add Misc/NEWS entry

* Add issue number

Contributed by Ivan Levkivskyi @ilevkivskyi

(cherry picked from commit b692dc8)
@ilevkivskyi
ilevkivskyi deleted the update-typing branch February 13, 2017 22:33
@ilevkivskyi

ilevkivskyi commented Feb 13, 2017

Copy link
Copy Markdown
Member Author

@Mariatta Thank you very much for taking care of this!

Mariatta reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gvanrossum

gvanrossum commented Feb 13, 2017 via email

Copy link
Copy Markdown
Member
Thank you both! I love the new workflows.
Mariatta reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mariatta added a commit that referenced this pull request Feb 14, 2017
@Mariatta
bpo-28556: Various updates to typing (#28) (#77)
0230e64
various updates from upstream python/typing repo:

- Added typing.Counter and typing.ChainMap generics
- More flexible typing.NamedTuple
- Improved generic ABC caching
- More tests
- Bugfixes
- Other updates
* Add Misc/NEWS entry


(cherry picked from commit b692dc8)
@mdboom mdboom mentioned this pull request Aug 25, 2022
Assert and incorrect error message when loading source file containing invalid UTF-8 #96268
Closed
@ziegenbalg ziegenbalg mentioned this pull request Nov 30, 2022
double free in io.TextIOWrapper #72573
Closed
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
Only leave a comment when no more pending CI (GH-28)
04431bf
- Ensure travis job has kicked off before checking for `pending` status.
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@warsaw
Support binary read when encoding=None (python#29)
f1ccb15
Closes python#28
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@webknjaz @jaraco
Use extend-ignore in flake8 config (python#33)
77fbe1d
* Use `extend-ignore` in flake8 config

This option allows to add extra ignored rules to the default list
instead of replacing it.

The default exclusions are: E121, E123, E126, E226, E24, E704,
W503 and W504.

Fixes python#28.

Refs:
* https://github.com/pypa/setuptools/pull/2486/files#r541943356
* https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-ignore
*
https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-ignore

* Enable complexity limit. Fixes jaraco/skeleton#34.

* Replace pep517.build with build (python#37)

* Replace pep517.build with build

Resolves python#30

* Prefer simple usage

Co-authored-by: Jason R. Coombs <[email protected]>

* Use license_files instead of license_file in meta (python#35)

Singular `license_file` is deprecated since wheel v0.32.0.

Refs:
* https://wheel.readthedocs.io/en/stable/news.html
* https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file

Co-authored-by: Jason R. Coombs <[email protected]>
nanjekyejoannah added a commit to nanjekyejoannah/cpython that referenced this pull request May 22, 2023
@bors @nanjekyejoannah
Merge python#28
b825d1f
28: test clean final r=ltratt a=nanjekyejoannah

This PR does the final cleanups to address the following:
- Allow higher recursion limit for some tests
- skip some tests that require very high recursion limits, I used the allowed limit by convention for the first item above
- call reset to allow warning propagation in some tests

Note:

Existing py3k tests fail with a segfault with -3 flag if not run individually, deleting this context manager in over 300 files will take forever, lets only run `test_py3kwarn` and the rest should be tested locally if modified. 

It took me long to know the source of this segfault, I have solved any issues with new context manager I introduce.

If this PR is merged, we can modify the CI, I am going back to implementing the warnings now.

Co-authored-by: Joannah Nanjekye <[email protected]>
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
heap-use-after-free in _PyFunction_LookupByVersion #108253
Closed
@LinanV LinanV mentioned this pull request Oct 23, 2023
Objects/typeobject.c: No such file or directory. #111203
Closed
@stasos24 stasos24 mentioned this pull request Oct 24, 2023
Modules/cjkcodecs/_codecs_iso2022.c - read out of bounds #101180
Closed
@williamhu020 williamhu020 mentioned this pull request Nov 5, 2023
Use the API C of 'Py-NewInterpreterFromConfig' to exit unexpectedly in multiple threads. #111751
Closed
@kcatss kcatss mentioned this pull request Nov 15, 2023
Use-after-free in unregister() of atexit module #112127
Closed
@kcatss kcatss mentioned this pull request Jan 14, 2024
crash in long_vectorcall in longobject.c #114050
Closed
@kcatss kcatss mentioned this pull request Feb 20, 2024
Use After Free at _heapreplace_max #115706
Closed
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Crash running PyO3 tests with --test-threads=1000 #124375
Closed
This was referenced Feb 11, 2025
segmentfault when pip installing setuptools #129992
Closed
segmentfault when pip installing setuptools #129993
Closed
@DominiquePACCO DominiquePACCO mentioned this pull request Jun 3, 2025
PdfWriter add_page adds (re)writes old page instead of new #135062
Closed
@efimov-mikhail efimov-mikhail mentioned this pull request Nov 5, 2025
memory leak in threading stack size #141044
Open
@sergey-miryanov sergey-miryanov mentioned this pull request Dec 18, 2025
Observed memory leak in ssl library: Python 3.14 GC issue #142516
Closed
@Qanux Qanux mentioned this pull request Feb 11, 2026
heap-buffer-overflow in functools.partial.__repr__() #144475
Closed
@ngoldbaum ngoldbaum mentioned this pull request Mar 6, 2026
Remove deprecated and undocumented function ctypes.SetPointerType #133866
Closed
@johng johng mentioned this pull request Jul 19, 2026
use-after-free: functools partial #154189
Closed
@djarfluka djarfluka mentioned this pull request Sep 12, 2026
Heap UAF in io.TextIOWrapper read path via reentrant detach() #157363
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ilevkivskyi @gvanrossum @brettcannon @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.