GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [backport to 3.6] bpo-28929: Link the documentation to its source file on GitHub by Mariatta · Pull Request #37 · python/cpython

Conversation

Mariatta commented Feb 12, 2017

Copy link

Copy Markdown

Member

Change the documentation's Show Source link on the left menu
to GitHub source file.

(cherry picked from commit 23bafa2)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          bpo-28929: Link the documentation to its source file on GitHub

e978c26

Change the documentation's `Show Source` link on the left menu
to GitHub source file.

(cherry picked from commit 23bafa2)

the-knights-who-say-ni added the CLA signed label

Feb 12, 2017

Mariatta added the type-feature A feature request or enhancement label

Feb 12, 2017

methane reviewed

Feb 12, 2017

View reviewed changes

Comment thread

Doc/tools/templates/customsourcelink.html Outdated

		<li><a href="{{ pathto('_sources/' + sourcename, true)\|e }}"
		rel="nofollow">{{ _('Show Source') }}</a></li>
		<li>
		{% if version == "3.7" %}

methane Feb 12, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this updated when Python 3.7 is released?
I think 2.7, 3.5, and 3.6 branch should not have this if statement.
Or could we pass variable like doc_source_url_prefix = "https://github.com/python/cpython/blob/3.6/Doc/" from conf?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Mariatta Feb 12, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, @methane :)
I removed the if statement as suggested.
Branches 2.7, 3.5, and 3.6 don't have the if statement anymore.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          remove if statement

424a1d7

berkerpeksag approved these changes

Feb 12, 2017

View reviewed changes

Mariatta merged commit f66c81f into python:3.6

Feb 12, 2017

Mariatta deleted the issue-28928-3.6 branch

February 12, 2017 21:08

Mariatta added the cherry-pick for 3.6 label

Feb 13, 2017

ghost mentioned this pull request

Sep 24, 2017

create a build environment for 2.8 so that we can distribute complete installs for windows. stackless-dev/stackless#30

Closed

kumaraditya303 pushed a commit to kumaraditya303/cpython that referenced this pull request

Aug 22, 2022


          Merge pull request python#37 from tiran/perf-test

32f8c99

ziegenbalg mentioned this pull request

Nov 30, 2022

double free in io.TextIOWrapper #72573

Closed

jaraco pushed a commit that referenced this pull request

Dec 2, 2022


          Wrote some unit tests and enabled Travis-CI. (GH-37)

8ac8fbd

jaraco pushed a commit to jaraco/cpython that referenced this pull request

Feb 17, 2023


          Add is_resource() and contents() (python#37)

e82b567

Support for is_resource() and contents()

jaraco added a commit to jaraco/cpython that referenced this pull request

Feb 17, 2023


          Replace pep517.build with build (python#37)

1731fbe

* Replace pep517.build with build

Resolves python#30

* Prefer simple usage

Co-authored-by: Jason R. Coombs <[email protected]>

jaraco added a commit to jaraco/cpython that referenced this pull request

Feb 17, 2023


          Use extend-ignore in flake8 config (python#33)

77fbe1d

* Use `extend-ignore` in flake8 config

This option allows to add extra ignored rules to the default list
instead of replacing it.

The default exclusions are: E121, E123, E126, E226, E24, E704,
W503 and W504.

Fixes python#28.

Refs:
* https://github.com/pypa/setuptools/pull/2486/files#r541943356
* https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-ignore
*
https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-ignore

* Enable complexity limit. Fixes jaraco/skeleton#34.

* Replace pep517.build with build (python#37)

* Replace pep517.build with build

Resolves python#30

* Prefer simple usage

Co-authored-by: Jason R. Coombs <[email protected]>

* Use license_files instead of license_file in meta (python#35)

Singular `license_file` is deprecated since wheel v0.32.0.

Refs:
* https://wheel.readthedocs.io/en/stable/news.html
* https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file

Co-authored-by: Jason R. Coombs <[email protected]>

Fidget-Spinner referenced this pull request in pylbbv/pylbbv

May 27, 2023


          Tests: Modified dis.py and added primitive tests (#37)

fd338df

* Tests: Modified dis.py and added primitive tests

* Docs: Typos and more documentation

* Test: Fixed minor issue

oraluben pushed a commit to oraluben/cpython that referenced this pull request

Jun 25, 2023


          fix: make assertion tier 2 frame aware (python#37)

5261ecc

gvanrossum mentioned this pull request

Aug 22, 2023

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

LinanV mentioned this pull request

Oct 23, 2023

Objects/typeobject.c: No such file or directory. #111203

Closed

kcatss mentioned this pull request

Feb 20, 2024

Use After Free at _heapreplace_max #115706

Closed

ngoldbaum mentioned this pull request

Sep 23, 2024

Crash running PyO3 tests with --test-threads=1000 #124375

Closed

This was referenced Feb 11, 2025

segmentfault when pip installing setuptools #129992

Closed

segmentfault when pip installing setuptools #129993

Closed

DominiquePACCO mentioned this pull request

Jun 3, 2025

PdfWriter add_page adds (re)writes old page instead of new #135062

Closed

sergey-miryanov mentioned this pull request

Dec 18, 2025

Observed memory leak in ssl library: Python 3.14 GC issue #142516

Closed

ngoldbaum mentioned this pull request

Mar 6, 2026

Remove deprecated and undocumented function ctypes.SetPointerType #133866

Closed

johng mentioned this pull request

Jul 19, 2026

use-after-free: functools partial #154189

Closed

djarfluka mentioned this pull request

Sep 12, 2026

Heap UAF in io.TextIOWrapper read path via reentrant detach() #157363

Open

Reviewers

methane

methane left review comments

berkerpeksag

berkerpeksag approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-feature

A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.