GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45229: Remove test_main in many tests by serhiy-storchaka · Pull Request #28405 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 17, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Instead of explicitly enumerate test classes for run_unittest()
use the unittest ability to discover tests. This also makes these
tests discoverable and runnable with unittest.

load_tests() can be used for dynamic generating tests and adding
doctests. setUpModule(), tearDownModule() and addModuleCleanup()
can be used for running code before and after all module tests.

https://bugs.python.org/issue45229

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir DO-NOT-MERGE needs backport to 3.9 labels Sep 17, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 17, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Sep 17, 2021
@serhiy-storchaka serhiy-storchaka changed the title 45229: Remove test_main in many tests bpo-45229: Remove test_main in many tests Sep 17, 2021
@serhiy-storchaka
serhiy-storchaka force-pushed the regrtest-no-test-main branch 2 times, most recently from c22388d to a4083e6 Compare September 17, 2021 07:41
@serhiy-storchaka serhiy-storchaka added the skip news label Sep 17, 2021
@serhiy-storchaka
bpo-45229: Remove test_main in many tests
dba9b2f 
Instead of explicitly enumerate test classes for run_unittest()
use the unittest ability to discover tests. This also makes these
tests discoverable and runnable with unittest.

load_tests() can be used for dynamic generating tests and adding
doctests. setUpModule(), tearDownModule() and addModuleCleanup()
can be used for running code before and after all module tests.
@serhiy-storchaka
serhiy-storchaka force-pushed the regrtest-no-test-main branch from a4083e6 to dba9b2f Compare September 17, 2021 12:49
@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review September 17, 2021 12:49
@serhiy-storchaka
serhiy-storchaka requested review from a team, brettcannon, encukou, ericsnowcurrently, ncoghlan, vsajip and warsaw as code owners September 17, 2021 12:49
@serhiy-storchaka
serhiy-storchaka requested a review from vstinner September 17, 2021 12:49
@serhiy-storchaka serhiy-storchaka added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed DO-NOT-MERGE labels Sep 17, 2021
@bedevere-bot

bedevere-bot commented Sep 17, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit dba9b2f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 17, 2021
@brettcannon
brettcannon removed their request for review September 17, 2021 18:17
@serhiy-storchaka
serhiy-storchaka merged commit 40348ac into python:main Sep 19, 2021
@miss-islington

miss-islington commented Sep 19, 2021

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 19, 2021
@miss-islington

miss-islington commented Sep 19, 2021

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 40348acc180580371d25f75f46b27048e35f2435 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka deleted the regrtest-no-test-main branch September 19, 2021 12:27
@miss-islington miss-islington assigned serhiy-storchaka Sep 19, 2021
@miss-islington

miss-islington commented Sep 19, 2021

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 40348acc180580371d25f75f46b27048e35f2435 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 19, 2021
@serhiy-storchaka
[3.10] bpo-45229: Remove test_main in many tests (pythonGH-28405)
e4b5e3b 
Instead of explicitly enumerate test classes for run_unittest()
use the unittest ability to discover tests. This also makes these
tests discoverable and runnable with unittest.

load_tests() can be used for dynamic generating tests and adding
doctests. setUpModule(), tearDownModule() and addModuleCleanup()
can be used for running code before and after all module tests..
(cherry picked from commit 40348ac)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 19, 2021

Copy link
Copy Markdown

GH-28455 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Sep 19, 2021
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 19, 2021
@serhiy-storchaka
[3.9] bpo-45229: Remove test_main in many tests (pythonGH-28405)
cf122fd 
Instead of explicitly enumerate test classes for run_unittest()
use the unittest ability to discover tests. This also makes these
tests discoverable and runnable with unittest.

load_tests() can be used for dynamic generating tests and adding
doctests. setUpModule(), tearDownModule() and addModuleCleanup()
can be used for running code before and after all module tests..
(cherry picked from commit 40348ac)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 19, 2021

Copy link
Copy Markdown

GH-28456 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Sep 19, 2021
serhiy-storchaka added a commit that referenced this pull request Sep 19, 2021
@serhiy-storchaka
[3.10] bpo-45229: Remove test_main in many tests (GH-28405) (GH-28455)
bedce35 
Instead of explicitly enumerate test classes for run_unittest()
use the unittest ability to discover tests. This also makes these
tests discoverable and runnable with unittest.

load_tests() can be used for dynamic generating tests and adding
doctests. setUpModule(), tearDownModule() and addModuleCleanup()
can be used for running code before and after all module tests.
(cherry picked from commit 40348ac)
serhiy-storchaka added a commit that referenced this pull request Sep 20, 2021
@serhiy-storchaka
[3.9] bpo-45229: Remove test_main in many tests (GH-28405) (GH-28456)
5822ab6 
Instead of explicitly enumerate test classes for run_unittest()
use the unittest ability to discover tests. This also makes these
tests discoverable and runnable with unittest.

load_tests() can be used for dynamic generating tests and adding
doctests. setUpModule(), tearDownModule() and addModuleCleanup()
can be used for running code before and after all module tests..
(cherry picked from commit 40348ac)
niyas-sait pushed a commit to niyas-sait/cpython that referenced this pull request Sep 21, 2021
@serhiy-storchaka @niyas-sait
bpo-45229: Remove test_main in many tests (pythonGH-28405)
3a0f1d9 
Instead of explicitly enumerate test classes for run_unittest()
use the unittest ability to discover tests. This also makes these
tests discoverable and runnable with unittest.

load_tests() can be used for dynamic generating tests and adding
doctests. setUpModule(), tearDownModule() and addModuleCleanup()
can be used for running code before and after all module tests.
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 16, 2022
Always use unittest for collecting tests in regrtests #89392
Closed
@The-Compiler The-Compiler mentioned this pull request May 23, 2022
test_threaded_import: Fix unittest.main spelling #93114
Merged
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou Awaiting requested review from encukou
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @bedevere-bot @miss-islington @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.