GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_threaded_import: Fix unittest.main spelling by The-Compiler · Pull Request #93114 · python/cpython

Conversation

@The-Compiler

@The-Compiler The-Compiler commented May 23, 2022

Copy link
Copy Markdown
Contributor

Regressed in 40348ac (GH-28405, v3.11.0a1) - cc @serhiy-storchaka.

(Also regressed in Lib/test/test_importlib/test_locks.py, but there it was already fixed in 2b16a08 by @tiran)

I believe this is simple enough to not need an issue/news-entry, but let me know if you disagree!

(Found by running flake8 over Lib/ out of curiosity, see #93010 (comment))

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@The-Compiler
test_threaded_import: Fix unittest.main spelling
74fa547 
Regressed in 40348ac.
@The-Compiler
The-Compiler requested review from brettcannon, encukou, ericsnowcurrently, ncoghlan and warsaw as code owners May 23, 2022 13:47
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels May 23, 2022
serhiy-storchaka
serhiy-storchaka approved these changes May 23, 2022
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 23, 2022
@serhiy-storchaka serhiy-storchaka added needs backport to 3.10 needs backport to 3.11 only security fixes skip issue skip news labels May 25, 2022
@serhiy-storchaka
serhiy-storchaka merged commit 1971014 into python:main May 25, 2022
@miss-islington

miss-islington commented May 25, 2022

Copy link
Copy Markdown
Contributor

Thanks @The-Compiler for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 25, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2022
@The-Compiler @miss-islington
test_threaded_import: Fix unittest.main spelling (pythonGH-93114)
ed6ae41 
(cherry picked from commit 1971014)

Co-authored-by: Florian Bruhin <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 25, 2022
@bedevere-bot

bedevere-bot commented May 25, 2022

Copy link
Copy Markdown

GH-93208 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2022
@The-Compiler @miss-islington
test_threaded_import: Fix unittest.main spelling (pythonGH-93114)
eec78d0 
(cherry picked from commit 1971014)

Co-authored-by: Florian Bruhin <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label May 25, 2022
@bedevere-bot

bedevere-bot commented May 25, 2022

Copy link
Copy Markdown

GH-93209 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request May 25, 2022
@miss-islington @The-Compiler
test_threaded_import: Fix unittest.main spelling (GH-93114)
02d35fc 
(cherry picked from commit 1971014)

Co-authored-by: Florian Bruhin <[email protected]>
miss-islington added a commit that referenced this pull request May 25, 2022
@miss-islington @The-Compiler
test_threaded_import: Fix unittest.main spelling (GH-93114)
2ea3d3b 
(cherry picked from commit 1971014)

Co-authored-by: Florian Bruhin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@The-Compiler @miss-islington @bedevere-bot @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.