GeezerVison

serhiy-storchaka requested review from abalkin and pganssle as code owners

September 29, 2021 10:22

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the awaiting core review label

ambv reviewed

View reviewed changes

Comment thread

Lib/test/test_datetime.py

		return tests

		def test_main():
		run_unittest(*all_test_classes)

ambv Sep 29, 2021

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this isn't used anymore, the import of run_unittest isn't necessary either.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka reacted with thumbs up emoji

All reactions

👍 1 reaction

serhiy-storchaka Sep 29, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I missed this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Remove unneeded import.

1131d9f

ambv approved these changes

View reviewed changes

ambv left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_datetime on main: Ran 960 tests in 9.497s; OK (skipped=28)
test_datetime on this PR: Ran 960 tests in 9.468s; OK (skipped=28)

Same tests running:

--- /tmp/main_datetime.log	2021-09-29 21:26:34.000000000 +0200
+++ /tmp/28615_datetime.log	2021-09-29 21:28:25.000000000 +0200
@@ -1 +1 @@
-Wed Sep 29 21:26:23 CEST 2021
+Wed Sep 29 21:28:14 CEST 2021
@@ -3 +3 @@
-== CPython 3.11.0a0 (heads/main:45ca1c0413, Sep 29 2021, 21:24:05) [Clang 12.0.0 (clang-1200.0.32.29)]
+== CPython 3.11.0a0 (heads/test-datetime-discover:1131d9fb69, Sep 29 2021, 21:27:42) [Clang 12.0.0 (clang-1200.0.32.29)]
@@ -5 +5 @@
-== cwd: /Users/ambv/Dropbox/Python/cpython/build/test_python_40589æ
+== cwd: /Users/ambv/Dropbox/Python/cpython/build/test_python_49597æ
@@ -8,2 +8,2 @@
-0:00:00 load avg: 2.35 Run tests sequentially
-0:00:00 load avg: 2.35 [1/1] test_datetime
+0:00:00 load avg: 3.01 Run tests sequentially
+0:00:00 load avg: 3.01 [1/1] test_datetime
@@ -982 +982 @@
-Ran 960 tests in 9.497s
+Ran 960 tests in 9.468s

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting core review labels

serhiy-storchaka merged commit d441437 into python:main

miss-islington commented Sep 29, 2021

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

serhiy-storchaka deleted the test-datetime-discover branch

September 29, 2021 20:28

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request


          bpo-45229: Make datetime tests discoverable (pythonGH-28615)

68e1320

(cherry picked from commit d441437)

Co-authored-by: Serhiy Storchaka <[email protected]>

miss-islington commented Sep 29, 2021

Copy link

Copy Markdown

Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d441437ee71ae174c008c23308b749b91020ba77 3.9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned serhiy-storchaka

bedevere-bot commented Sep 29, 2021

Copy link

Copy Markdown

GH-28639 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.10 label

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request


          [3.9] bpo-45229: Make datetime tests discoverable (pythonGH-28615).

e393129

(cherry picked from commit d441437)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot removed the needs backport to 3.9 label

https://buildbot.python.org/all/#/builders/75/builds/172/steps/5/logs/stdio

bedevere-bot commented Sep 30, 2021

Copy link

Copy Markdown

GH-28645 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pablogsal commented Sep 30, 2021

Copy link

Copy Markdown

Member

Unfortunately, this PR seems to have broken a bunch of buildbots. For instance:

test_divide_and_round (test.datetimetester.TestModule_Pure) ... ok
test_divide_and_round (test.datetimetester.TestModule_Fast) ... skipped 'Only run for Pure Python implementation'
----------------------------------------------------------------------
Ran 2 tests in 0.000s
OK (skipped=1)
test_divide_and_round (test.datetimetester.TestModule_Pure) ... ERROR
.test test_datetime failed
test_divide_and_round (test.datetimetester.TestModule_Fast) ... skipped 'Only run for Pure Python implementation'
======================================================================
ERROR: test_divide_and_round (test.datetimetester.TestModule_Pure)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.refleak/build/Lib/test/datetimetester.py", line 88, in test_divide_and_round
    dar = datetime_module._divide_and_round
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'datetime' has no attribute '_divide_and_round'
----------------------------------------------------------------------
Ran 2 tests in 0.003s
FAILED (errors=1, skipped=1)
1 test failed again:
    test_datetime
== Tests result: FAILURE then FAILURE ==

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pablogsal added a commit that referenced this pull request


          Revert "bpo-45229: Make datetime tests discoverable (GH-28615)"

1ada100

This reverts commit d441437.

pablogsal mentioned this pull request

bpo-45229: Revert "Make datetime tests discoverable" #28650

Merged

pablogsal added a commit that referenced this pull request

https://buildbot.python.org/all/#builders/441/builds/732


          Revert "bpo-45229: Make datetime tests discoverable (GH-28615)" (GH-2…

b07fddd

…8650)

This reverts commit d441437.

bedevere-bot commented Sep 30, 2021

Copy link

Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable Clang 3.x has failed when building commit b07fddd.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/441/builds/732) and take a look at the build logs.
Check if the failure is related to this commit (b07fddd) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

Failed tests:

test_multiprocessing_fork
test_multiprocessing_forkserver
test_multiprocessing_spawn

Failed subtests:

test_shared_memory_basics - test.test_multiprocessing_spawn.WithProcessesTestSharedMemory
test_shared_memory_basics - test.test_multiprocessing_forkserver.WithProcessesTestSharedMemory
test_shared_memory_basics - test.test_multiprocessing_fork.WithProcessesTestSharedMemory

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

412 tests OK.

10 slowest tests:

test_peg_generator: 2 min 49 sec
test_concurrent_futures: 2 min 40 sec
test_multiprocessing_spawn: 1 min 35 sec
test_nntplib: 1 min 21 sec
test_multiprocessing_forkserver: 1 min 13 sec
test_multiprocessing_fork: 1 min 6 sec
test_asyncio: 57.3 sec
test_signal: 47.2 sec
test_io: 38.7 sec
test_socket: 38.2 sec

3 tests failed:
test_multiprocessing_fork test_multiprocessing_forkserver
test_multiprocessing_spawn

12 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_startfile
test_tix test_tk test_ttk_guionly test_winconsoleio test_winreg
test_winsound test_zipfile64

3 re-run tests:
test_multiprocessing_fork test_multiprocessing_forkserver
test_multiprocessing_spawn

Total duration: 3 min 19 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_6bdda612'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_21c743d3'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_e86a3721'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang/build/Lib/test/_test_multiprocessing.py", line 3777, in test_shared_memory_basics
    sms = shared_memory.SharedMemory('test01_tsmb', create=True, size=512)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang/build/Lib/multiprocessing/shared_memory.py", line 103, in __init__
    self._fd = _posixshmem.shm_open(
               ^^^^^^^^^^^^^^^^^^^^^
FileExistsError: [Errno 17] File exists: '/test01_tsmb'

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Sep 30, 2021

Copy link

Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable Clang Installed 3.x has failed when building commit b07fddd.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/350/builds/737) and take a look at the build logs.
Check if the failure is related to this commit (b07fddd) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/350/builds/737

Failed tests:

test_multiprocessing_fork
test_multiprocessing_forkserver
test_multiprocessing_spawn

Failed subtests:

test_shared_memory_basics - test.test_multiprocessing_forkserver.WithProcessesTestSharedMemory
test_shared_memory_basics - test.test_multiprocessing_fork.WithProcessesTestSharedMemory
test_shared_memory_basics - test.test_multiprocessing_spawn.WithProcessesTestSharedMemory

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

408 tests OK.

3 tests failed:
test_multiprocessing_fork test_multiprocessing_forkserver
test_multiprocessing_spawn

16 tests skipped:
test_asdl_parser test_check_c_globals test_clinic test_devpoll
test_gdb test_ioctl test_kqueue test_msilib test_startfile
test_tix test_tk test_ttk_guionly test_winconsoleio test_winreg
test_winsound test_zipfile64

3 re-run tests:
test_multiprocessing_fork test_multiprocessing_forkserver
test_multiprocessing_spawn

Total duration: 2 min 50 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.11/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_5a1b37ec'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.11/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_9c328efe'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.11/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_a28821d5'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.11/test/_test_multiprocessing.py", line 3777, in test_shared_memory_basics
    sms = shared_memory.SharedMemory('test01_tsmb', create=True, size=512)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.11/multiprocessing/shared_memory.py", line 103, in __init__
    self._fd = _posixshmem.shm_open(
               ^^^^^^^^^^^^^^^^^^^^^
FileExistsError: [Errno 17] File exists: '/test01_tsmb'

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Sep 30, 2021

Copy link

Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora LTO + PGO 3.x has failed when building commit b07fddd.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/545/builds/783) and take a look at the build logs.
Check if the failure is related to this commit (b07fddd) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/545/builds/783

Failed tests:

test_multiprocessing_fork
test_multiprocessing_forkserver
test_multiprocessing_spawn

Failed subtests:

test_shared_memory_basics - test.test_multiprocessing_spawn.WithProcessesTestSharedMemory
test_shared_memory_basics - test.test_multiprocessing_forkserver.WithProcessesTestSharedMemory
test_shared_memory_basics - test.test_multiprocessing_fork.WithProcessesTestSharedMemory

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

409 tests OK.

10 slowest tests:

test_concurrent_futures: 2 min 31 sec
test_multiprocessing_spawn: 1 min 20 sec
test_multiprocessing_forkserver: 1 min 9 sec
test_nntplib: 1 min 6 sec
test_multiprocessing_fork: 1 min 3 sec
test_signal: 47.5 sec
test_asyncio: 44.1 sec
test_socket: 37.7 sec
test_io: 31.9 sec
test_pydoc: 31.2 sec

3 tests failed:
test_multiprocessing_fork test_multiprocessing_forkserver
test_multiprocessing_spawn

15 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib test_nis
test_readline test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

3 re-run tests:
test_multiprocessing_fork test_multiprocessing_forkserver
test_multiprocessing_spawn

Total duration: 4 min 15 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto-pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_51a8726a'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto-pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_b0dd5439'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto-pgo/build/Lib/test/_test_multiprocessing.py", line 3777, in test_shared_memory_basics
    sms = shared_memory.SharedMemory('test01_tsmb', create=True, size=512)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto-pgo/build/Lib/multiprocessing/shared_memory.py", line 103, in __init__
    self._fd = _posixshmem.shm_open(
               ^^^^^^^^^^^^^^^^^^^^^
FileExistsError: [Errno 17] File exists: '/test01_tsmb'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto-pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_31cae0a6'

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Sep 30, 2021

Copy link

Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable LTO 3.x has failed when building commit b07fddd.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/271/builds/669) and take a look at the build logs.
Check if the failure is related to this commit (b07fddd) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/271/builds/669

Failed tests:

test_multiprocessing_fork
test_multiprocessing_forkserver
test_multiprocessing_spawn

Failed subtests:

test_shared_memory_basics - test.test_multiprocessing_spawn.WithProcessesTestSharedMemory
test_shared_memory_basics - test.test_multiprocessing_forkserver.WithProcessesTestSharedMemory
test_shared_memory_basics - test.test_multiprocessing_fork.WithProcessesTestSharedMemory

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

412 tests OK.

10 slowest tests:

test_peg_generator: 3 min 45 sec
test_concurrent_futures: 2 min 31 sec
test_gdb: 1 min 44 sec
test_multiprocessing_spawn: 1 min 32 sec
test_nntplib: 1 min 21 sec
test_multiprocessing_forkserver: 1 min 12 sec
test_multiprocessing_fork: 1 min 4 sec
test_asyncio: 54.1 sec
test_signal: 47.5 sec
test_socket: 37.9 sec

3 tests failed:
test_multiprocessing_fork test_multiprocessing_forkserver
test_multiprocessing_spawn

12 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_startfile
test_tix test_tk test_ttk_guionly test_winconsoleio test_winreg
test_winsound test_zipfile64

3 re-run tests:
test_multiprocessing_fork test_multiprocessing_forkserver
test_multiprocessing_spawn

Total duration: 4 min 26 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.lto/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_717541bc'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.lto/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_c27b3f3e'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.lto/build/Lib/test/_test_multiprocessing.py", line 3777, in test_shared_memory_basics
    sms = shared_memory.SharedMemory('test01_tsmb', create=True, size=512)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.lto/build/Lib/multiprocessing/shared_memory.py", line 103, in __init__
    self._fd = _posixshmem.shm_open(
               ^^^^^^^^^^^^^^^^^^^^^
FileExistsError: [Errno 17] File exists: '/test01_tsmb'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.lto/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_fe719e16'

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Sep 30, 2021

Copy link

Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora LTO 3.x has failed when building commit b07fddd.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/55/builds/730) and take a look at the build logs.
Check if the failure is related to this commit (b07fddd) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/55/builds/730

Failed tests:

test_multiprocessing_fork
test_multiprocessing_forkserver
test_multiprocessing_spawn

Failed subtests:

test_shared_memory_basics - test.test_multiprocessing_spawn.WithProcessesTestSharedMemory
test_shared_memory_basics - test.test_multiprocessing_forkserver.WithProcessesTestSharedMemory
test_shared_memory_basics - test.test_multiprocessing_fork.WithProcessesTestSharedMemory

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

410 tests OK.

10 slowest tests:

test_peg_generator: 3 min 45 sec
test_concurrent_futures: 2 min 32 sec
test_gdb: 1 min 43 sec
test_multiprocessing_spawn: 1 min 26 sec
test_multiprocessing_forkserver: 1 min 12 sec
test_nntplib: 1 min 5 sec
test_multiprocessing_fork: 1 min 4 sec
test_signal: 47.2 sec
test_asyncio: 45.1 sec
test_socket: 38.0 sec

3 tests failed:
test_multiprocessing_fork test_multiprocessing_forkserver
test_multiprocessing_spawn

14 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_nis
test_readline test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

3 re-run tests:
test_multiprocessing_fork test_multiprocessing_forkserver
test_multiprocessing_spawn

Total duration: 6 min 5 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/_test_multiprocessing.py", line 3777, in test_shared_memory_basics
    sms = shared_memory.SharedMemory('test01_tsmb', create=True, size=512)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/multiprocessing/shared_memory.py", line 103, in __init__
    self._fd = _posixshmem.shm_open(
               ^^^^^^^^^^^^^^^^^^^^^
FileExistsError: [Errno 17] File exists: '/test01_tsmb'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_94aacdad'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_bb76f3e9'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_c472e72d'

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added a commit that referenced this pull request


          [3.9] bpo-45229: Make datetime tests discoverable (GH-28615). (GH-28645)

993a130

(cherry picked from commit d441437)

ambv added a commit to ambv/cpython that referenced this pull request


          Revert "[3.9] bpo-45229: Make datetime tests discoverable (pythonGH-2…

41e96f6

…8615). (pythonGH-28645)"

This reverts commit 993a130.

serhiy-storchaka added the needs backport to 3.10 label

miss-islington commented Sep 30, 2021

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ambv added a commit that referenced this pull request


          Revert "bpo-45229: Make datetime tests discoverable (GH-28615). (GH-2…

2cf76cf

…8645)" (GH-28660)

This reverts commit 993a130.

serhiy-storchaka added a commit that referenced this pull request


          Revert "Revert "bpo-45229: Make datetime tests discoverable (GH-28615)…

4bd7d46

…. (GH-28645)" (GH-28660)"

This reverts commit 2cf76cf.

serhiy-storchaka added a commit that referenced this pull request


          Revert "Revert "bpo-45229: Make datetime tests discoverable (GH-28615)…

47099cf

…" (GH-28650)"

This reverts commit b07fddd.

serhiy-storchaka added needs backport to 3.10 and removed needs backport to 3.10 labels

miss-islington commented Oct 1, 2021

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Oct 1, 2021

Copy link

Copy Markdown

GH-28668 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.10 label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request


          bpo-45229: Make datetime tests discoverable (pythonGH-28615)

df9c757

(cherry picked from commit d441437)

Co-authored-by: Serhiy Storchaka <[email protected]>

miss-islington added a commit that referenced this pull request


          bpo-45229: Make datetime tests discoverable (GH-28615)

ef7c729

(cherry picked from commit d441437)

Co-authored-by: Serhiy Storchaka <[email protected]>

serhiy-storchaka added a commit that referenced this pull request


          Revert "Revert "bpo-45229: Make datetime tests discoverable (GH-28615)…

2f20592

…" (GH-28650)" (GH-28667)

This reverts commit b07fddd.

serhiy-storchaka added a commit that referenced this pull request