GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45229: Revert "Make datetime tests discoverable" by pablogsal · Pull Request #28650 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Sep 30, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Reverts #28615

https://bugs.python.org/issue45229

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
Revert "bpo-45229: Make datetime tests discoverable (GH-28615)"
1ada100 
This reverts commit d441437.
@pablogsal
pablogsal requested review from abalkin and pganssle as code owners September 30, 2021 12:21
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 30, 2021
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Sep 30, 2021
@pablogsal

pablogsal commented Sep 30, 2021

Copy link
Copy Markdown
Member Author

Temporary revert of #28615 until we have a fix for the buildbot fleet
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal added the skip news label Sep 30, 2021
@pablogsal
pablogsal requested review from ambv and vstinner September 30, 2021 12:22
pganssle
pganssle approved these changes Sep 30, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 30, 2021
vstinner
vstinner approved these changes Sep 30, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Serhiy's enhancement is great, but breaking all Refleaks buildbot is reason good enough to justify a revert.

It seems like it's simple to reproduce the issue, so we can revert and investigate on our side in the meanwhile.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal merged commit b07fddd into main Sep 30, 2021
@pablogsal
pablogsal deleted the revert-28615-test-datetime-discover branch September 30, 2021 13:46
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 30, 2021
serhiy-storchaka added a commit that referenced this pull request Oct 1, 2021
@serhiy-storchaka
Revert "Revert "bpo-45229: Make datetime tests discoverable (GH-28615)…
47099cf 
…" (GH-28650)"

This reverts commit b07fddd.
@serhiy-storchaka serhiy-storchaka mentioned this pull request Oct 1, 2021
Revert "bpo-45229: Revert "Make datetime tests discoverable"" #28667
Merged
serhiy-storchaka added a commit that referenced this pull request Oct 1, 2021
@serhiy-storchaka
Revert "Revert "bpo-45229: Make datetime tests discoverable (GH-28615)…
2f20592 
…" (GH-28650)" (GH-28667)

This reverts commit b07fddd.
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 16, 2022
Always use unittest for collecting tests in regrtests #89392
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@pganssle pganssle pganssle approved these changes
@abalkin abalkin Awaiting requested review from abalkin
@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@pablogsal @vstinner @pganssle @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.