GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45678: Add ``functools.singledispatchmethod`` tests by AlexWaygood · Pull Request #29328 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Oct 30, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue45678

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
bpo-45678: Add functools.singledispatchmethod tests
adabdbe
@AlexWaygood
AlexWaygood requested a review from rhettinger as a code owner October 30, 2021 12:16
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 30, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 30, 2021
@bedevere-bot bedevere-bot added the awaiting review label Oct 30, 2021
@AlexWaygood
Update 2021-10-30-13-12-20.bpo-45678.bKrYeS.rst
3767676
@ambv ambv added needs backport to 3.9 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Nov 2, 2021
@bedevere-bot

bedevere-bot commented Nov 2, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ambv for commit 3767676 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 2, 2021
@AlexWaygood

AlexWaygood commented Nov 3, 2021

Copy link
Copy Markdown
Member Author

All buildbot failures but one are on test_sqlite3. I believe that is unrelated to this PR (see #29382).

The only buildbot that failed on a non-sqlite test was "AMD64 FreeBSD Shared PR", where test_gdb didn't pass. I think that's probably also unrelated? 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit 5a14929 into python:main Nov 3, 2021
@miss-islington

miss-islington commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label Nov 3, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2021
@AlexWaygood @miss-islington
bpo-45678: Add functools.singledispatchmethod tests (pythonGH-29328)
9c41894 
(cherry picked from commit 5a14929)

Co-authored-by: Alex Waygood <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 3, 2021

Copy link
Copy Markdown

GH-29390 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Nov 3, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2021
@AlexWaygood @miss-islington
bpo-45678: Add functools.singledispatchmethod tests (pythonGH-29328)
531de96 
(cherry picked from commit 5a14929)

Co-authored-by: Alex Waygood <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 3, 2021

Copy link
Copy Markdown

GH-29391 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Nov 3, 2021
@AlexWaygood
AlexWaygood deleted the add-functools-tests branch November 3, 2021 16:13
ambv pushed a commit that referenced this pull request Nov 3, 2021
@miss-islington @AlexWaygood
bpo-45678: Add functools.singledispatchmethod tests (GH-29328) (G…
f191838 
…H-29390)

(cherry picked from commit 5a14929)

Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Nov 3, 2021
@AlexWaygood
[3.9] bpo-45678: Fix singledispatchmethod classmethod/`staticmeth…
fdff8bf 
…od` bug

This PR fixes a bug in the 3.9 branch where
``functools.singledispatchmethod`` did not properly wrap attributes such as
``__name__``, ``__doc__`` and ``__module__`` of the target method. It also
backports tests already merged into the 3.11 and 3.10 branches in #python#29328 and
python#29390.
@AlexWaygood AlexWaygood mentioned this pull request Nov 3, 2021
[3.9] bpo-45678: Fix singledispatchmethod classmethod/staticmethod bug #29394
Merged
@AlexWaygood

AlexWaygood commented Nov 3, 2021

Copy link
Copy Markdown
Member Author

As discussed in #29391, the attempted backport of this PR by @miss-islington to Python 3.9 exposed a bug in that branch. A new bugfix/backport PR is here: #29394
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ambv added a commit that referenced this pull request Nov 4, 2021
@AlexWaygood @ambv
[3.9] bpo-45678: Fix singledispatchmethod classmethod/`staticmeth…
effb72f 
…od` bug (GH-29394)

This PR fixes a bug in the 3.9 branch where
``functools.singledispatchmethod`` did not properly wrap attributes such as
``__name__``, ``__doc__`` and ``__module__`` of the target method. It also
backports tests already merged into the 3.11 and 3.10 branches in #29328 and
#29390.

Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@AlexWaygood @bedevere-bot @miss-islington @ambv @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.