GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-45678: Fix `singledispatchmethod` `classmethod`/`staticmethod` bug by AlexWaygood · Pull Request #29394 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Nov 3, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR fixes a bug in the 3.9 branch where
functools.singledispatchmethod did not properly wrap attributes such as
__name__, __doc__ and __module__ of the target method. It also
backports tests already merged into the 3.11 and 3.10 branches in #29328 and
#29390.

https://bugs.python.org/issue45678

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
[3.9] bpo-45678: Fix singledispatchmethod classmethod/`staticmeth…
fdff8bf 
…od` bug

This PR fixes a bug in the 3.9 branch where
``functools.singledispatchmethod`` did not properly wrap attributes such as
``__name__``, ``__doc__`` and ``__module__`` of the target method. It also
backports tests already merged into the 3.11 and 3.10 branches in #python#29328 and
python#29390.
@AlexWaygood
AlexWaygood requested a review from rhettinger as a code owner November 3, 2021 19:32
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 3, 2021
@bedevere-bot bedevere-bot added the awaiting review label Nov 3, 2021
@AlexWaygood AlexWaygood mentioned this pull request Nov 3, 2021
bpo-45678: Add functools.singledispatchmethod tests #29328
Merged
@AlexWaygood

AlexWaygood commented Nov 3, 2021

Copy link
Copy Markdown
Member Author

To test this bugfix, I added some additional tests that were not included in #29328 and #29390 (the previous PRs to the 3.10 & 3.11 branches). I'd like to "forward-port" these tests to 3.10 & 3.11 after this PR is merged (if it is accepted), before the BPO issue is closed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
Clean up tests
ef70461
ambv
ambv reviewed Nov 4, 2021
View reviewed changes
Comment thread Lib/functools.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv mentioned this pull request Nov 4, 2021
[3.9] bpo-45678: Add functools.singledispatchmethod tests (GH-29328) #29391
Closed
@ambv
Use obvious spelling for staticmethod/classmethod special case
8e26322
@ambv
ambv merged commit effb72f into python:3.9 Nov 4, 2021
@bedevere-bot bedevere-bot removed the awaiting review label Nov 4, 2021
@ambv

ambv commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

Go ahead and "forward-port" the new tests, @AlexWaygood!
AlexWaygood reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood deleted the singledispatchmethod-wrapping-bug branch November 4, 2021 19:55
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Nov 4, 2021
@AlexWaygood
bpo-45678: Add more singledispatchmethod tests
65d913e 
In order to fix a bug in the 3.9 branch in python#29394, more tests were added to
``test_functools.py`` to ensure that ``singledispatchmethod`` still correctly
wrapped a target method, even if the target method had already been wrapped by
 multiple other decorators. This PR brings the new tests into the 3.11 and 3.10
branches as well.
@AlexWaygood AlexWaygood mentioned this pull request Nov 4, 2021
bpo-45678: Add more singledispatchmethod tests #29412
Merged
@AlexWaygood

AlexWaygood commented Nov 4, 2021

Copy link
Copy Markdown
Member Author

Go ahead and "forward-port" the new tests, @AlexWaygood!

Forward-port is here! #29412 😀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ambv pushed a commit that referenced this pull request Nov 5, 2021
@AlexWaygood
bpo-45678: Add more singledispatchmethod tests (GH-29412)
32f55d1 
In order to fix a bug in the 3.9 branch in #29394, more tests were added to
``test_functools.py`` to ensure that ``singledispatchmethod`` still correctly
wrapped a target method, even if the target method had already been wrapped by
 multiple other decorators. This PR brings the new tests into the 3.11 and 3.10
branches as well.
@miss-islington miss-islington mentioned this pull request Nov 5, 2021
[3.10] bpo-45678: Add more singledispatchmethod tests (GH-29412) #29424
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2021
@AlexWaygood @miss-islington
bpo-45678: Add more singledispatchmethod tests (pythonGH-29412)
98af9fc 
In order to fix a bug in the 3.9 branch in pythonGH-29394, more tests were added to
``test_functools.py`` to ensure that ``singledispatchmethod`` still correctly
wrapped a target method, even if the target method had already been wrapped by
 multiple other decorators. This PR brings the new tests into the 3.11 and 3.10
branches as well.
(cherry picked from commit 32f55d1)

Co-authored-by: Alex Waygood <[email protected]>
ambv pushed a commit that referenced this pull request Nov 5, 2021
@miss-islington @AlexWaygood
bpo-45678: Add more singledispatchmethod tests (GH-29412) (GH-29424)
bcb236c 
In order to fix a bug in the 3.9 branch in GH-29394, more tests were added to
``test_functools.py`` to ensure that ``singledispatchmethod`` still correctly
wrapped a target method, even if the target method had already been wrapped by
 multiple other decorators. This PR brings the new tests into the 3.11 and 3.10
branches as well.
(cherry picked from commit 32f55d1)

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AlexWaygood @ambv @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.