GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45723: Improve and simplify more configure.ac checks (GH-29485) by erlend-aasland · Pull Request #29485 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 9, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Cache checking of -Wl,--no-as-needed
  • Make PY_CHECK_CC_WARNING more efficient
  • Consolidate AC_MSG_CHECKING and AC_CACHE_VAL

https://bugs.python.org/issue45723

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland added 3 commits November 9, 2021 13:45
Erlend E. Aasland
Cache checking for -Wl,--no-as-needed
6e0fa90
Erlend E. Aasland
Make PY_CHECK_CC_WARNING more efficient
35fe25c
Erlend E. Aasland
Consolidate AC_MSG_CHECKING and AC_CACHE_VAL
ad35861
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 9, 2021
@bedevere-bot bedevere-bot added the awaiting review label Nov 9, 2021
@erlend-aasland erlend-aasland added the skip news label Nov 9, 2021
@erlend-aasland
erlend-aasland requested a review from tiran November 9, 2021 12:49
Erlend E. Aasland added 3 commits November 9, 2021 13:53
Erlend E. Aasland
Nitpick
77f4cad
Erlend E. Aasland
Use AS_VAR_APPEND in PY_CHECK_CC_WARNING
de69f18
Erlend E. Aasland
Take down one more AC_MSG_RESULT
79b97e0
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 9, 2021
@bedevere-bot

bedevere-bot commented Nov 9, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 79b97e0 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 9, 2021
tiran
tiran approved these changes Nov 9, 2021
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll do another test before I merge the PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 9, 2021
@erlend-aasland

erlend-aasland commented Nov 9, 2021

Copy link
Copy Markdown
Contributor Author

Looks good to me. I'll do another test before I merge the PR.

Great, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran changed the title bpo-45723: Improve and simplify more configure.ac checks bpo-45723: Improve and simplify more configure.ac checks (GH-29485) Nov 10, 2021
@tiran
tiran merged commit 76d14fa into python:main Nov 10, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 10, 2021
@erlend-aasland
erlend-aasland deleted the ac-more-stuff branch November 10, 2021 15:44
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Erlend Egeberg Aasland remykarem
bpo-45723: Improve and simplify more configure.ac checks (pythonGH-29485
669fb41 
)
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
Erlend Egeberg Aasland remykarem
bpo-45723: Improve and simplify more configure.ac checks (pythonGH-29485
c4ffd3c 
)
@tiran tiran mentioned this pull request Apr 22, 2022
Improve and simplify configure.ac checks #89886
Closed
@virtuald virtuald mentioned this pull request Oct 14, 2022
bpo-41916: allow cross-compiled python to have -pthread set for CXX #22525
Merged
@eli-schwartz eli-schwartz mentioned this pull request Jun 19, 2024
Failing configure tests due to missing space #120671
Closed
@allsey87 allsey87 mentioned this pull request Jun 21, 2024
gh-120671: Fix as_fn_append CFLAGS #120822
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @bedevere-bot @tiran @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.