GeezerVison

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@pR0Ps

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@pR0Ps I guess you ignored the change requests from the other PR, shouldn't call __del__ like that; see here.

Also IMO you'd want to give the warning regardless of the file having been rolled over to disk or not. BytesIO does not warn in its __del__. Otherwise you'd have warnings that are triggered by the phase of moon.

@ztane Made the requested change to the __del__ method and added a test to ensure that a ResourceWarning is generated in both a rolled and unrolled state.

Rebased on latest main.

In the future, please avoid force pushes on Python repositories, they make reviewing less pleasant: https://devguide.python.org/pullrequest/

In the future, please avoid force pushes on Python repositories, they make reviewing less pleasant: https://devguide.python.org/pullrequest/

Sorry, I've re-pushed the change as a separate commit and will do the same in the future.

@pR0Ps Thanks! When PR is updated with a usual push, everybody subscribed can open the PR from "Unread notifications" and see only these updates of a diff. For example, a full PR4881073 contains 38 insertions but I do not need to reread it from a scratch after a (bunch of) commit(s) was added today:

^{Source: https://github.com/python/cpython/pull/29052/files/91f8ad6445a0671af6b0ee65cfba778c7ac150c4..d28a4ed7e24263972549ab82e6c7cf455e05defc}

With a force-push, however, GitHub gives up and forces a reviewer to open a list of commits and manually scan for all changes:

When there are a few commits per day, it's ok. However, in this repo with a dosen of changes per hour, such manual works would become a second job.

@erlend-aasland Can you take a look please?