GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95913: Add io support for SpooledTemporaryFile in Whatsnew by CAM-Gerlach · Pull Request #98312 · python/cpython

Conversation

@CAM-Gerlach

@CAM-Gerlach CAM-Gerlach commented Oct 16, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Part of #95913

Adds a section for tempfile to the 3.11 What's New, mentioning that tempfile.SpooledTemporaryFIle now supports the full range of IO base class methods, as added in issue #70363 / PR #29560 .

  • Issue: Edit What's New for Python 3.11 #95913

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@CAM-Gerlach
Whatsnew: Add io method support for tempfile.SpooledTemporaryFile
cfb41ec
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 16, 2022
@CAM-Gerlach CAM-Gerlach changed the title Whatsnew: Add io support for tempfile.SpooledTemporaryFile gh-95913: Add io support for SpooledTemporaryFile in Whatsnew Oct 16, 2022
@CAM-Gerlach CAM-Gerlach added 3.11 only security fixes needs backport to 3.11 only security fixes labels Oct 16, 2022
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 16, 2022
Edit What's New for Python 3.11 #95913
Closed
31 of 33 tasks
@CAM-Gerlach
CAM-Gerlach requested review from ezio-melotti and merwok October 16, 2022 02:17
merwok
merwok reviewed Oct 16, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@CAM-Gerlach
Revise tempfile wording for clarity per Éric's suggestion
6d5a49a
@CAM-Gerlach
CAM-Gerlach requested a review from merwok October 16, 2022 18:43
@CAM-Gerlach

CAM-Gerlach commented Oct 24, 2022

Copy link
Copy Markdown
Member Author

Hey @merwok , is this ✔️ on your end?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CAM-Gerlach
CAM-Gerlach requested a review from JelleZijlstra October 24, 2022 02:51
JelleZijlstra
JelleZijlstra reviewed Oct 24, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra
Update Doc/whatsnew/3.11.rst
77d381b
JelleZijlstra
JelleZijlstra approved these changes Oct 24, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 24, 2022
@JelleZijlstra
JelleZijlstra merged commit f3f8b6f into python:main Oct 24, 2022
@miss-islington

miss-islington commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

Thanks @CAM-Gerlach for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Oct 24, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2022
@CAM-Gerlach @miss-islington
pythongh-95913: Add io support for SpooledTemporaryFile in 3.11 Whats…
f2a9bfe
…new (pythonGH-98312)

(cherry picked from commit f3f8b6f)

Co-authored-by: C.A.M. Gerlach <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 24, 2022

Copy link
Copy Markdown

GH-98599 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 24, 2022
miss-islington added a commit that referenced this pull request Oct 24, 2022
@miss-islington @CAM-Gerlach
gh-95913: Add io support for SpooledTemporaryFile in 3.11 Whatsnew (G…
c4ad3fc
…H-98312)

(cherry picked from commit f3f8b6f)

Co-authored-by: C.A.M. Gerlach <[email protected]>
JelleZijlstra added a commit that referenced this pull request Oct 24, 2022
@JelleZijlstra
gh-95913: Fix grammar for SpooledTemporaryFile 3.11 whatsnew entry
de64f32
Followup from #98312.
@JelleZijlstra JelleZijlstra mentioned this pull request Oct 24, 2022
gh-95913: Fix grammar for SpooledTemporaryFile 3.11 whatsnew entry #98604
Merged
JelleZijlstra added a commit that referenced this pull request Oct 24, 2022
@JelleZijlstra
gh-95913: Fix grammar for SpooledTemporaryFile 3.11 whatsnew entry (#…
c5a9d3f
…98604)

Followup from #98312.
@miss-islington miss-islington mentioned this pull request Oct 24, 2022
[3.11] gh-95913: Fix grammar for SpooledTemporaryFile 3.11 whatsnew entry (GH-98604) #98606
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2022
@JelleZijlstra @miss-islington
pythongh-95913: Fix grammar for SpooledTemporaryFile 3.11 whatsnew en…
6c9307c
…try (pythonGH-98604)

Followup from pythonGH-98312.
(cherry picked from commit c5a9d3f)

Co-authored-by: Jelle Zijlstra <[email protected]>
miss-islington added a commit that referenced this pull request Oct 24, 2022
@miss-islington @JelleZijlstra
gh-95913: Fix grammar for SpooledTemporaryFile 3.11 whatsnew entry (G…
3f6cfc5
…H-98604)

Followup from GH-98312.
(cherry picked from commit c5a9d3f)

Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti
@merwok merwok Awaiting requested review from merwok

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.11 only security fixes docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@CAM-Gerlach @miss-islington @bedevere-bot @merwok @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.