GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Refactor sanitizer skip tests into test.support by pablogsal · Pull Request #30889 · python/cpython

Conversation

pablogsal commented Jan 25, 2022

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Refactor sanitizer skip tests into test.support

fb9b3a1

pablogsal added skip issue skip news labels

Jan 25, 2022

the-knights-who-say-ni added the CLA signed label

Jan 25, 2022

bedevere-bot added the awaiting core review label

Jan 25, 2022

pablogsal requested a review from erlend-aasland

January 25, 2022 16:28

erlend-aasland approved these changes

Jan 25, 2022

View reviewed changes

erlend-aasland left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. LGTM, with a single remark.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/support/__init__.py Outdated

		'--with-memory-sanitizer' in _config_args
		)
		address_sanitizer = (
		'-fsanitize=address' in _cflags

erlend-aasland Jan 25, 2022

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check '--with-memory-sanitizer' in _config_args

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

erlend-aasland commented Jan 25, 2022

Copy link

Copy Markdown

Contributor

I'd add a NEWS entry and possibly document it in the test support section.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reviewed

Jan 25, 2022

View reviewed changes

Comment thread

Lib/test/support/__init__.py Outdated

		"run_with_tz", "PGO", "missing_compiler_executable",
		"ALWAYS_EQ", "NEVER_EQ", "LARGEST", "SMALLEST",
		"LOOPBACK_TIMEOUT", "INTERNET_TIMEOUT", "SHORT_TIMEOUT", "LONG_TIMEOUT",
		"skip_if_sanitizer",

erlend-aasland Jan 25, 2022

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this probably belongs in the unittest section between line 34 and 44.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pablogsal reacted with thumbs up emoji

All reactions

👍 1 reaction

pablogsal commented Jan 25, 2022

Copy link

Copy Markdown

Member Author

I'd add a NEWS entry and possibly document it in the test support section.

The news section is for user visible changes, this is an internal change.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pablogsal added 2 commits

January 25, 2022 21:23


          fixup! Refactor sanitizer skip tests into test.support

a12b766


          fixup! fixup! Refactor sanitizer skip tests into test.support

erlend-aasland approved these changes

Jan 25, 2022

View reviewed changes

pablogsal merged commit b1cb843 into python:main

Jan 25, 2022

pablogsal deleted the asan branch

January 25, 2022 22:01

bedevere-bot removed the awaiting core review label

Jan 25, 2022

vstinner mentioned this pull request

Mar 1, 2022

[3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) #31634

Merged

vstinner added a commit that referenced this pull request

Mar 2, 2022


          [3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) (G…

…H-31634)

* Refactor sanitiser skip tests into test.support (GH-30889)

* Refactor sanitizer skip tests into test.support

(cherry picked from commit b1cb843)

* Add skips to crashing tests under sanitizers instead of manually skipping them (GH-30897)

(cherry picked from commit a275053)

* bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632)

Skip tests on ASAN and/or MSAN builds:

* multiprocessing tests
* test___all__
* test_concurrent_futures
* test_decimal
* test_peg_generator
* test_tools

(cherry picked from commit 9204bb7)

Co-authored-by: Pablo Galindo Salgado <[email protected]>

vstinner mentioned this pull request

Mar 2, 2022

[3.9] bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) (GH-31634) #31644

Merged

vstinner added a commit that referenced this pull request

Mar 2, 2022


          [3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) (G…

359bc39

…H-31634) (GH-31644)

* Refactor sanitiser skip tests into test.support (GH-30889)

* Refactor sanitizer skip tests into test.support

(cherry picked from commit b1cb843)

* Add skips to crashing tests under sanitizers instead of manually skipping them (GH-30897)

(cherry picked from commit a275053)

* bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632)

Skip tests on ASAN and/or MSAN builds:

* multiprocessing tests
* test___all__
* test_concurrent_futures
* test_decimal
* test_peg_generator
* test_tools

(cherry picked from commit 9204bb7)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
(cherry picked from commit 9326445)

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request

Jun 2, 2022


          [3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (pythonGH-31632…

c36f6d7

…) (pythonGH-31634) (pythonGH-31644)

* Refactor sanitiser skip tests into test.support (pythonGH-30889)

* Refactor sanitizer skip tests into test.support

(cherry picked from commit b1cb843)

* Add skips to crashing tests under sanitizers instead of manually skipping them (pythonGH-30897)

(cherry picked from commit a275053)

* bpo-46633: Skip tests on ASAN and/or MSAN builds (pythonGH-31632)

Skip tests on ASAN and/or MSAN builds:

* multiprocessing tests
* test___all__
* test_concurrent_futures
* test_decimal
* test_peg_generator
* test_tools

(cherry picked from commit 9204bb7)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
(cherry picked from commit 9326445)

gpshead mentioned this pull request

Jun 5, 2023

Display the sanitizer config in the regrtest header. #105301

Merged

Reviewers

erlend-aasland

erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.