GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46633: Skip tests on ASAN and/or MSAN builds by vstinner · Pull Request #31632 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 1, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Skip tests on ASAN and/or MSAN builds:

  • multiprocessing tests
  • test___all__
  • test_concurrent_futures
  • test_decimal
  • test_peg_generator
  • test_tools

The ASAN job of GitHub Actions no longer excludes these tests.

https://bugs.python.org/issue46633

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-46633: Skip tests on ASAN and/or MSAN builds
321060f 
Skip tests on ASAN and/or MSAN builds:

* multiprocessing tests
* test___all__
* test_concurrent_futures
* test_decimal
* test_peg_generator
* test_tools

The ASAN job of GitHub Actions no longer excludes these tests.
@vstinner
vstinner requested review from lysnikolaou, pablogsal and rhettinger as code owners March 1, 2022 09:28
@bedevere-bot bedevere-bot added the awaiting core review label Mar 1, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 1, 2022
@vstinner
fixup! bpo-46633: Skip tests on ASAN and/or MSAN builds
7c8e1eb 
Add missing import
@vstinner vstinner added the skip news label Mar 1, 2022
@vstinner
vstinner merged commit 9204bb7 into python:main Mar 1, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 1, 2022
@vstinner
vstinner deleted the skip_asan branch March 1, 2022 14:44
@vstinner vstinner added needs backport to 3.9 labels Mar 1, 2022
@miss-islington

miss-islington commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9204bb72a2da5885facc747e63d2bd2d654606fe 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned vstinner Mar 1, 2022
@miss-islington

miss-islington commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Sorry @vstinner, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 9204bb72a2da5885facc747e63d2bd2d654606fe 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner removed needs backport to 3.9 labels Mar 1, 2022
@vstinner vstinner mentioned this pull request Mar 1, 2022
[3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) #31634
Merged
vstinner added a commit that referenced this pull request Mar 2, 2022
@vstinner @pablogsal
[3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) (G…
9326445 
…H-31634)

* Refactor sanitiser skip tests into test.support (GH-30889)

* Refactor sanitizer skip tests into test.support

(cherry picked from commit b1cb843)

* Add skips to crashing tests under sanitizers instead of manually skipping them (GH-30897)

(cherry picked from commit a275053)

* bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632)

Skip tests on ASAN and/or MSAN builds:

* multiprocessing tests
* test___all__
* test_concurrent_futures
* test_decimal
* test_peg_generator
* test_tools

(cherry picked from commit 9204bb7)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@vstinner vstinner mentioned this pull request Mar 2, 2022
[3.9] bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) (GH-31634) #31644
Merged
vstinner added a commit that referenced this pull request Mar 2, 2022
@vstinner @pablogsal
[3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) (G…
359bc39 
…H-31634) (GH-31644)

* Refactor sanitiser skip tests into test.support (GH-30889)

* Refactor sanitizer skip tests into test.support

(cherry picked from commit b1cb843)

* Add skips to crashing tests under sanitizers instead of manually skipping them (GH-30897)

(cherry picked from commit a275053)

* bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632)

Skip tests on ASAN and/or MSAN builds:

* multiprocessing tests
* test___all__
* test_concurrent_futures
* test_decimal
* test_peg_generator
* test_tools

(cherry picked from commit 9204bb7)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
(cherry picked from commit 9326445)
@vstinner vstinner mentioned this pull request May 5, 2022
AddressSanitizer: Skip tests directly in Python, not with external config #90791
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@vstinner @pablogsal @hello-adam
[3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (pythonGH-31632…
c36f6d7 
…) (pythonGH-31634) (pythonGH-31644)

* Refactor sanitiser skip tests into test.support (pythonGH-30889)

* Refactor sanitizer skip tests into test.support

(cherry picked from commit b1cb843)

* Add skips to crashing tests under sanitizers instead of manually skipping them (pythonGH-30897)

(cherry picked from commit a275053)

* bpo-46633: Skip tests on ASAN and/or MSAN builds (pythonGH-31632)

Skip tests on ASAN and/or MSAN builds:

* multiprocessing tests
* test___all__
* test_concurrent_futures
* test_decimal
* test_peg_generator
* test_tools

(cherry picked from commit 9204bb7)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
(cherry picked from commit 9326445)
@hugovk hugovk mentioned this pull request Aug 29, 2023
3.11.5 test_httpservers fails on unhandled DeprecationWarning ("invalid escape sequence '\\?'") #108569
Closed
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @miss-islington @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.