GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45173: Keep configparser deprecations until Python 3.12 by hugovk · Pull Request #30952 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Jan 27, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

First commit:

Revert #28292 / 1fc41ae to give projects another year to update before removal of configparser deprecations.

Second commit:

Update the deprecation warnings to explicitly call out that they will be removed in Python 3.12, and mention in What's New and a NEWS file.

Re:

  • https://bugs.python.org/issue45173#msg411810
  • https://mail.python.org/archives/list/[email protected]/thread/GJTREADEXYAETECE5JDTPYWK4WMTKYGR/
  • https://discuss.python.org/t/experience-with-python-3-11-in-fedora/12911

https://bugs.python.org/issue45173

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
hugovk added 2 commits January 27, 2022 11:14
@hugovk
Revert "bpo-45173 Remove configparser deprecations"
ebfa178
This reverts commit df2284b.
@hugovk
bpo-45173: Note these configparser deprecations will be removed in 3.12
b06e9ba
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 27, 2022
@bedevere-bot bedevere-bot added the awaiting review label Jan 27, 2022
@hugovk hugovk mentioned this pull request Jan 27, 2022
bpo-46607: Add DeprecationWarning to LegacyInterpolation #30927
Merged
@hugovk

hugovk commented Jan 27, 2022

Copy link
Copy Markdown
Member Author

Should this (the second commit specifically) also go into 3.9 and 3.10 for greater visibility?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Jan 27, 2022

Copy link
Copy Markdown
Member

cc @gpshead

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gpshead

gpshead commented Jan 27, 2022

Copy link
Copy Markdown
Member

I think it seems reasonable for the second commit updating the warning message text to be backported to 3.10, but you should really ask the release manager @pablogsal. I wouldn't bother going as far back as 3.9 with that.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Jan 28, 2022

Copy link
Copy Markdown
Member

but you should really ask the release manager @pablogsal. I wouldn't bother going as far back as 3.9 with that.

I am ok backporting the error message to 3.10.

For 3.9 you should check with @ambv

hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk added the needs backport to 3.10 label Jan 29, 2022
@vstinner

vstinner commented Feb 2, 2022

Copy link
Copy Markdown
Member

@gpshead @pablogsal: I'm the one who asked for the revert, but I would prefer if someone else merges this PR. Do you want to merge it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@domdfcoding

domdfcoding commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

If the intention is to remove these for good in 3.12, it it worth noting that in the docs for readfp? Currently it only says that it's deprecated, but not that it's about to be removed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead
gpshead approved these changes Feb 2, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 2, 2022
@gpshead

gpshead commented Feb 2, 2022

Copy link
Copy Markdown
Member

If the intention is to remove these for good in 3.12, it it worth noting that in the docs for readfp? Currently it only says that it's deprecated, but not that it's about to be removed.

I think this is fine. Keeping version numbers straight everywhere and sticking to them is hard enough. The important thing given we have a plan here is that the raised warnings now mention a version.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gpshead
gpshead merged commit e8659b4 into python:main Feb 2, 2022
@miss-islington

miss-islington commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Feb 2, 2022
@miss-islington

miss-islington commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

Sorry @hugovk and @gpshead, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e8659b47dece5a272111c0af5e340c364a9f807b 3.10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington miss-islington assigned gpshead Feb 2, 2022
@gpshead

gpshead commented Feb 2, 2022

Copy link
Copy Markdown
Member

feel free to assign warning message update backport PRs to me when you've made them.

hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk
hugovk deleted the issue45173-revert-configparser-deprecations branch February 2, 2022 17:07
@hugovk hugovk mentioned this pull request Feb 2, 2022
[3.10] bpo-45173: Note configparser deprecations will be removed in 3.12 #31084
Merged
miss-islington pushed a commit that referenced this pull request Feb 2, 2022
@hugovk
[3.10] bpo-45173: Note configparser deprecations will be removed in 3…
ba4d79a
….12 (GH-31084)

Cherry-pick of [`b06e9ba`](b06e9ba) from #30952.
@vstinner vstinner removed the needs backport to 3.10 label Feb 2, 2022
@vstinner

vstinner commented Feb 2, 2022

Copy link
Copy Markdown
Member

Python 3.10 didn't get a backward, only the doc was updated: ba4d79a

gpshead and hugovk reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk mentioned this pull request Apr 10, 2022
Postpone configparser deprecations until 3.12 #89336
Closed
@hugovk hugovk mentioned this pull request May 10, 2022
gh-89336: Fix configparser.RawConfigParser.readfp typo #92636
Merged
@EliahKagan EliahKagan mentioned this pull request Aug 14, 2023
build: Update versioneer from 0.15 to 0.29 cwacek/python-jsonschema-objects#242
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@hugovk @vstinner @gpshead @pablogsal @domdfcoding @miss-islington @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.