GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46586: Fix more erroneous doc links to builtins by meersuri · Pull Request #31429 · python/cpython

Conversation

@meersuri

@meersuri meersuri commented Feb 19, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue46586

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
meersuri and others added 5 commits February 8, 2022 23:23
@meersuri
Fix enum.property documentation link
a7dd04a 
Incorrectly pointed to built-in the property() function as mentioned in python#46586
@blurb-it
📜🤖 Added by blurb_it.
64f5b1d
@meersuri
Fix links to builtin max, min in sys.float_info
078b226
@meersuri
Revert "📜🤖 Added by blurb_it."
47d95ac 
This reverts commit 64f5b1d.
@meersuri
Fix more erroneous doc links to builtins
8484127
@meersuri
meersuri requested a review from ethanfurman as a code owner February 19, 2022 06:42
@bedevere-bot bedevere-bot added the awaiting review label Feb 19, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 19, 2022
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Feb 19, 2022
@hugovk hugovk added the skip news label Feb 19, 2022
@AlexWaygood

AlexWaygood commented Feb 19, 2022

Copy link
Copy Markdown
Member

Hi, it looks like you need to merge origin/main into your branch here — the enum.property fix is still showing up in this PR, even though that one's already been committed to main 🙂
meersuri reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@meersuri
Merge branch 'main' of github.com:python/cpython into fix-issue-46586
bd501db
merwok
merwok reviewed Mar 5, 2022
View reviewed changes
Comment thread Doc/library/io.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
merwok
merwok reviewed Mar 5, 2022
View reviewed changes
Comment thread Doc/library/zipfile.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra reviewed May 2, 2022
View reviewed changes
Comment thread Doc/library/io.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra @merwok
Apply suggestions from code review
ccf9af7 
Co-authored-by: Éric <[email protected]>
JelleZijlstra
JelleZijlstra approved these changes May 2, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 2, 2022
@JelleZijlstra JelleZijlstra self-assigned this May 2, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.9 labels May 2, 2022
merwok
merwok reviewed May 2, 2022
View reviewed changes
Comment thread Doc/library/fileinput.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
merwok
merwok reviewed May 2, 2022
View reviewed changes
Comment thread Doc/library/urllib.request.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra @merwok
Apply suggestions from code review
5d0aad4 
Co-authored-by: Éric <[email protected]>
@merwok

merwok commented May 2, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thanks for this PR!
Could we also fix the wrong markup in the documentation of structseq objects? (see #90744 (comment))
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented May 2, 2022

Copy link
Copy Markdown
Member

@merwok let's keep that for another PR, so we can land this one.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@merwok

merwok commented May 2, 2022

Copy link
Copy Markdown
Member

I don’t really get why split these fixes into three changes here, two changes there (and the original ticket about enum has already had its scope widered), but 🤷🏽 it’s up to you! Better to merge some fixes than none 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit cc6ae4f into python:main May 2, 2022
@miss-islington

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Thanks @meersuri for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 2, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2022
@meersuri @miss-islington
bpo-46586: Fix more erroneous doc links to builtins (pythonGH-31429)
3445252 
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Éric <[email protected]>
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri <[email protected]>
@miss-islington

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Sorry, @meersuri and @JelleZijlstra, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cc6ae4f4835f9e76a34f24cd1f666c1cc0fecfa3 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 2, 2022

Copy link
Copy Markdown

GH-92198 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label May 2, 2022
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request May 2, 2022
@meersuri @JelleZijlstra
[3.9] bpo-46586: Fix more erroneous doc links to builtins (pythonGH-3…
0ccd7f2 
…1429)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Éric <[email protected]>.
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label May 2, 2022
@bedevere-bot

bedevere-bot commented May 2, 2022

Copy link
Copy Markdown

GH-92199 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request May 2, 2022
@miss-islington @meersuri
bpo-46586: Fix more erroneous doc links to builtins (GH-31429)
5f40cb8 
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Éric <[email protected]>
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri <[email protected]>
JelleZijlstra added a commit that referenced this pull request May 3, 2022
@JelleZijlstra @meersuri
[3.9] bpo-46586: Fix more erroneous doc links to builtins (GH-31429) (#…
92d2615 
…92199)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Éric <[email protected]>.
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri <[email protected]>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@JelleZijlstra @meersuri @hello-adam
[3.9] bpo-46586: Fix more erroneous doc links to builtins (pythonGH-3…
a527fa6 
…1429) (python#92199)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Éric <[email protected]>.
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri <[email protected]>
@Dutcho Dutcho mannequin mentioned this pull request Apr 10, 2022
In documentation same-named attributes erroneously link to built-in names #90744
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@AlexWaygood AlexWaygood AlexWaygood left review comments
@ethanfurman ethanfurman Awaiting requested review from ethanfurman

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@meersuri @AlexWaygood @merwok @JelleZijlstra @miss-islington @bedevere-bot @hugovk @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.