GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-46586: Fix more erroneous doc links to builtins (GH-31429) by JelleZijlstra · Pull Request #92199 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 2, 2022

Copy link
Copy Markdown
Member

Co-authored-by: Jelle Zijlstra [email protected]
Co-authored-by: Éric [email protected].
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@meersuri @JelleZijlstra
[3.9] bpo-46586: Fix more erroneous doc links to builtins (pythonGH-3…
0ccd7f2 
…1429)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Éric <[email protected]>.
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri <[email protected]>
@JelleZijlstra JelleZijlstra self-assigned this May 2, 2022
@bedevere-bot bedevere-bot mentioned this pull request May 2, 2022
bpo-46586: Fix more erroneous doc links to builtins #31429
Merged
@bedevere-bot bedevere-bot added skip news docs Documentation in the Doc dir awaiting core review labels May 2, 2022
serhiy-storchaka
serhiy-storchaka approved these changes May 3, 2022
View reviewed changes
Comment thread Doc/library/urllib.request.rst
This method, if implemented, will be called by the parent
:class:`OpenerDirector`. It should return a file-like object as described in
the return value of the :meth:`open` of :class:`OpenerDirector`, or ``None``.
the return value of the :meth:`~OpenerDirector.open` method of :class:`OpenerDirector`, or ``None``.

@serhiy-storchaka serhiy-storchaka May 3, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not related to this PR, but if some item is mentioned multiple times in one paragrafph, I prefer to keep link only in one of them (usually at the first occurrence). :class:`!OpenerDirector` or ``OpenerDirector``. Too many duplicated links do not make the text more readable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra and AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

@JelleZijlstra JelleZijlstra May 3, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, will keep it in mind for the future.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 3, 2022
@JelleZijlstra JelleZijlstra mentioned this pull request May 3, 2022
Style guide suggestion: Avoid duplicate links python/docs-community#52
Closed
@JelleZijlstra
JelleZijlstra merged commit 92d2615 into python:3.9 May 3, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 3, 2022
@JelleZijlstra
JelleZijlstra deleted the backport-cc6ae4f-3.9 branch May 3, 2022 12:08
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@JelleZijlstra @meersuri @hello-adam
[3.9] bpo-46586: Fix more erroneous doc links to builtins (pythonGH-3…
a527fa6 
…1429) (python#92199)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Éric <[email protected]>.
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @serhiy-storchaka @bedevere-bot @meersuri
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.