GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-46805: Add low level UDP socket functions to asyncio by agronholm · Pull Request #31455 · python/cpython

Conversation

agronholm commented Feb 20, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

sock_sendto()
sock_recvfrom()
sock_recvfrom_into()

https://bugs.python.org/issue46805

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lewoudar and graingert reacted with rocket emoji

All reactions

🚀 2 reactions


          Added three new raw socket methods to asyncio

5f1cadb

* sock_sendto()
* sock_recvfrom()
* sock_recvfrom_into()

bedevere-bot added the awaiting review label

Feb 20, 2022

the-knights-who-say-ni added the CLA signed label

Feb 20, 2022

agronholm added 7 commits

February 20, 2022 23:03


          Added news blurb

ef60dcf


          Fixed variable/constant references

928742c


          Fixed recvfrom_into()

ebd2353


          Merge branch 'main' into fix-issue-46805

586dc65


          Fixed NameError

af18ee1


          Merge remote-tracking branch 'fork/fix-issue-46805' into fix-issue-46805

113b93f


          Cleanup additions/fixes

agronholm force-pushed the fix-issue-46805 branch from 98a4c5a to 2395598 Compare

February 27, 2022 23:01

agronholm marked this pull request as ready for review

February 27, 2022 23:19

agronholm requested review from 1st1 and asvetlov as code owners

February 27, 2022 23:19

kumaraditya303 reviewed

Mar 4, 2022

View reviewed changes

Comment thread

Modules/overlapped.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

asvetlov reviewed

Mar 11, 2022

View reviewed changes

Comment thread

Lib/asyncio/windows_events.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Fixed wrong return value on BrokenPipeError

7b3c12b

kumaraditya303 requested changes

Mar 11, 2022

View reviewed changes

kumaraditya303 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new methods should be mentioned in 3.11 whatsnew

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting core review and removed awaiting review labels

Mar 11, 2022

agronholm commented Mar 11, 2022

Copy link

Copy Markdown

Contributor Author

The new methods should be mentioned in 3.11 whatsnew

They're already mentioned in the news blurb in this PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303 commented Mar 11, 2022

Copy link

Copy Markdown

Contributor

It should also be mentioned in the Improved Modules section of whatsnew under asyncio.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

agronholm commented Mar 11, 2022

Copy link

Copy Markdown

Contributor Author

It should also be mentioned in the Improved Modules section of whatsnew under asyncio.

What do I need to do?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303 commented Mar 11, 2022

Copy link

Copy Markdown

Contributor

It should also be mentioned in the Improved Modules section of whatsnew under asyncio.

What do I need to do?

Add new methods here https://github.com/python/cpython/blob/main/Doc/whatsnew/3.11.rst, See https://github.com/python/cpython/blob/main/Doc/whatsnew/3.11.rst#inspect for inspect module as an example.

agronholm reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

agronholm added 2 commits

March 11, 2022 14:44


          Merge branch 'main' into fix-issue-46805

0cb4622


          Added item to the "improved modules" section

16177df

agronholm commented Mar 11, 2022

Copy link

Copy Markdown

Contributor Author

It should also be mentioned in the Improved Modules section of whatsnew under asyncio.

Done.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

asvetlov reviewed

Mar 11, 2022

View reviewed changes

asvetlov left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix minor notes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/overlapped.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/overlapped.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/overlapped.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

agronholm added 2 commits

March 12, 2022 14:27


          Fixed the return type description for sock_recvfrom_into()

059f645


          Fixed code style

7908ea6


          Switched to automated parsing of Py_buffer

f907a77

asvetlov approved these changes

Mar 13, 2022

View reviewed changes

asvetlov left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting core review labels

Mar 13, 2022

asvetlov merged commit 9f04ee5 into python:main

Mar 13, 2022

bedevere-bot removed the awaiting merge label

Mar 13, 2022

agronholm deleted the fix-issue-46805 branch

March 13, 2022 16:43

agronholm commented Mar 13, 2022

Copy link

Copy Markdown

Contributor Author

Thanks for reviewing!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

carljm pushed a commit to carljm/cpython that referenced this pull request

Mar 14, 2022


          Merge branch 'main' into dictwatch

d22463b

* main: (94 commits)
  Revert "bpo-46986: Upgrade bundled setuptools to 60.9.3 (pythonGH-31820)" (pythonGH-31879)
  bpo-30677: [doc] mention that os.mkdir() can raise FileNotFoundError (pythonGH-31548)
  git ignore Lib/site-packages (pythonGH-31862)
  bpo-31415: importtime was made by Inada Naoki (pythonGH-31875)
  bpo-46920: Remove code that has explainers why it was disabled (pythonGH-31813)
  bpo-46920: Remove disabled debug code added decades ago and likely unnecessary (pythonGH-31812)
  bpo-46920: Remove code that has no explainer why it was disabled (pythonGH-31814)
  bpo-46906: Mention native endian in PyFloat_Pack8() doc (pythonGH-31866)
  bpo-40280: select: Use NULL for empty fdset (pythonGH-31865)
  CI: Fix patchcheck (pythonGH-31708)
  bpo-46987: Remove _PySys_GetObjectId / _PySys_GetObjectId (pythonGH-31835)
  bpo-46994: Accept explicit contextvars.Context in asyncio create_task() API (pythonGH-31837)
  bpo-39829: Fix `__len__()` is called twice in list() constructor (pythonGH-31816)
  bpo-47003: Cleanup _overlapped module (pythonGH-31848)
  bpo-47004: Sync with importlib_metadata 4.11.3. (python#31854)
  bpo-46986: Upgrade bundled setuptools to 60.9.3 (pythonGH-31820)
  bpo-46985: Upgrade bundled pip to 22.0.4 (pythonGH-31819)
  bpo-46805: Add low level UDP socket functions to asyncio (pythonGH-31455)
  bpo-46995: Deprecate missing asyncio.Task.set_name() for third-party task implementations (pythonGH-31838)
  bpo-43215: Document Happy Eyeballs args of asyncio.open_connection (pythonGH-24525)
  ...

Reviewers

kumaraditya303

kumaraditya303 requested changes

asvetlov

asvetlov approved these changes

1st1

Awaiting requested review from 1st1

1st1 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

agronholm commented Feb 20, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kumaraditya303 left a comment

Choose a reason for hiding this comment

Uh oh!

agronholm commented Mar 11, 2022

Uh oh!

kumaraditya303 commented Mar 11, 2022

Uh oh!

agronholm commented Mar 11, 2022

Uh oh!

kumaraditya303 commented Mar 11, 2022

Uh oh!

agronholm commented Mar 11, 2022

Uh oh!

asvetlov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asvetlov left a comment

Choose a reason for hiding this comment

Uh oh!

agronholm commented Mar 13, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

agronholm commented Feb 20, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.