GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.12 (GH-31891) by hugovk · Pull Request #31998 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Mar 19, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594.
(cherry picked from commit 7747384)

Also updated tests to ignore the (new in 3.9) deprecation warnings, the same way they're ignored in 3.10.

https://bugs.python.org/issue47022

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
hugovk requested review from a team, tiran and vsajip as code owners March 19, 2022 21:03
@bedevere-bot bedevere-bot added the awaiting review label Mar 19, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 19, 2022
@bedevere-bot bedevere-bot mentioned this pull request Mar 19, 2022
bpo-47022: Document asynchat, asyncore and smtpd removals in 3.12 #31891
Merged
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Mar 19, 2022
@hugovk
hugovk requested a review from brettcannon March 19, 2022 21:39
brettcannon
brettcannon requested changes Mar 21, 2022
View reviewed changes
Comment thread Lib/asynchat.py Outdated

@brettcannon brettcannon Mar 21, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't backport warnings like this, only documentation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@hugovk hugovk Mar 22, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, dropped changes to .py files, and adjusted the NEWS entry to refer only to docs (and not deprecation warnings).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Mar 21, 2022
@bedevere-bot

bedevere-bot commented Mar 21, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon brettcannon self-assigned this Mar 21, 2022
@hugovk
[3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.…
5419793 
…12 (pythonGH-31891)

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594..
(cherry picked from commit 7747384)

Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk
hugovk force-pushed the backport-7747384-3.9 branch from 66e6bbf to 5419793 Compare March 22, 2022 09:05
@hugovk

hugovk commented Mar 22, 2022

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Mar 22, 2022
@bedevere-bot

bedevere-bot commented Mar 22, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from brettcannon March 22, 2022 09:48
brettcannon
brettcannon approved these changes Mar 22, 2022
View reviewed changes
@brettcannon
brettcannon merged commit af341eb into python:3.9 Mar 22, 2022
@hugovk
hugovk deleted the backport-7747384-3.9 branch March 22, 2022 18:16
@bedevere-bot

bedevere-bot commented Mar 22, 2022

Copy link
Copy Markdown

@brettcannon: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting change review label Mar 22, 2022
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@hugovk @hello-adam
[3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.…
bf720a3 
…12 (pythonGH-31891) (python#31998)

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594..
(cherry picked from commit 7747384)

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@tiran tiran Awaiting requested review from tiran
@vsajip vsajip Awaiting requested review from vsajip

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brettcannon brettcannon

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hugovk @bedevere-bot @brettcannon @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.