GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-47167: Allow overriding a future compliance check in asyncio.Task by asvetlov · Pull Request #32197 · python/cpython

Conversation

@asvetlov

@asvetlov asvetlov commented Mar 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue47167

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
asvetlov added 5 commits March 29, 2022 20:43
@asvetlov
Make changes
ce2491a
@asvetlov
Merge branch 'main' into asyncio-task-check
3bd939a
@asvetlov
Fix tests
617423e
@asvetlov
Add tests
924e011
@asvetlov
Add NEWS
e3cc354
@asvetlov
asvetlov requested a review from 1st1 as a code owner March 30, 2022 15:36
@bedevere-bot bedevere-bot added the awaiting core review label Mar 30, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 30, 2022
arhadthedev
arhadthedev reviewed Mar 31, 2022
View reviewed changes
Comment thread Modules/_asynciomodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
asvetlov added 3 commits March 31, 2022 16:00
@asvetlov
Apply notes
8760a60
@asvetlov
Merge branch 'main' into asyncio-task-check
eb9e88d
@asvetlov
Document the method
da248fc
@asvetlov asvetlov added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 31, 2022
@bedevere-bot

bedevere-bot commented Mar 31, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @asvetlov for commit da248fc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 31, 2022
@asvetlov
asvetlov merged commit d4bb38f into main Apr 1, 2022
@asvetlov
asvetlov deleted the asyncio-task-check branch April 1, 2022 01:25
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 1, 2022
@1st1

1st1 commented Apr 1, 2022

Copy link
Copy Markdown
Member

I think this PR should be reverted. I explained why in the issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@1st1

1st1 commented Apr 1, 2022

Copy link
Copy Markdown
Member

@asvetlov Andrew, please don't force commits like this without my review (I'm still listed as a co-owner).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asvetlov asvetlov mentioned this pull request Apr 10, 2022
Allow overriding future-task compliance check in asyncio #91323
Closed
ambv added a commit to ambv/cpython that referenced this pull request Jul 29, 2022
@ambv
Revert "bpo-47167: Allow overriding a future compliance check in asyn…
32ea7d1 
…cio.Task (pythonGH-32197)"

This reverts commit d4bb38f.
ambv added a commit that referenced this pull request Aug 4, 2022
@ambv
gh-91323: Revert "Allow overriding a future compliance check in async…
0342c93 
…io.Task (GH-32197)" (GH-95442)

This reverts commit d4bb38f.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2022
@ambv @miss-islington
pythongh-91323: Revert "Allow overriding a future compliance check in…
5202170 
… asyncio.Task (pythonGH-32197)" (pythonGH-95442)

This reverts commit d4bb38f.
(cherry picked from commit 0342c93)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Aug 4, 2022
@miss-islington @ambv
gh-91323: Revert "Allow overriding a future compliance check in async…
5ac3d0f 
…io.Task (GH-32197)" (GH-95442) (GH-95652)

This reverts commit d4bb38f.
(cherry picked from commit 0342c93)

Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@asvetlov @bedevere-bot @1st1 @arhadthedev @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.