GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91323: Revert "Allow overriding a future compliance check in asyncio.Task (GH-32197)" by ambv · Pull Request #95442 · python/cpython

Conversation

@ambv

@ambv ambv commented Jul 29, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This reverts commit d4bb38f.

  • Issue: Allow overriding future-task compliance check in asyncio #91323

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ambv
Revert "bpo-47167: Allow overriding a future compliance check in asyn…
32ea7d1 
…cio.Task (pythonGH-32197)"

This reverts commit d4bb38f.
@ambv
ambv requested review from 1st1 and asvetlov as code owners July 29, 2022 15:48
@bedevere-bot bedevere-bot added the awaiting core review label Jul 29, 2022
@ambv
Actually, leave the nicer formatting in
261ecef
@ambv ambv added the skip news label Jul 29, 2022
@ambv

ambv commented Jul 29, 2022

Copy link
Copy Markdown
Contributor Author

I marked this as "skip news" as the original change wasn't mentioned in the change log.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv added the needs backport to 3.11 only security fixes label Jul 29, 2022
@ambv ambv changed the title Revert "bpo-47167: Allow overriding a future compliance check in asyncio.Task (GH-32197)" bpo-47167: Revert "Allow overriding a future compliance check in asyncio.Task (GH-32197)" Jul 29, 2022
@ambv ambv changed the title bpo-47167: Revert "Allow overriding a future compliance check in asyncio.Task (GH-32197)" gh-91323: Revert "Allow overriding a future compliance check in asyncio.Task (GH-32197)" Jul 29, 2022
1st1
1st1 approved these changes Jul 29, 2022
View reviewed changes

@1st1 1st1 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, according to #91323 (comment) this change isn't really needed.

I don't think it's much useful for anything else and I think the bar for adding new APIs to Tasks/Future is very high. Let's drop it for now. cc @asvetlov

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 29, 2022
@arhadthedev arhadthedev mentioned this pull request Jul 29, 2022
gh-92679: Clarify asyncio.loop.start_tls parameters #92682
Merged
@ambv
ambv merged commit 0342c93 into python:main Aug 4, 2022
@miss-islington

miss-islington commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 4, 2022
@ambv
ambv deleted the revert-gh-32197 branch August 4, 2022 13:51
@bedevere-bot

bedevere-bot commented Aug 4, 2022

Copy link
Copy Markdown

GH-95652 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 4, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2022
@ambv @miss-islington
pythongh-91323: Revert "Allow overriding a future compliance check in…
5202170 
… asyncio.Task (pythonGH-32197)" (pythonGH-95442)

This reverts commit d4bb38f.
(cherry picked from commit 0342c93)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Aug 4, 2022
@miss-islington @ambv
gh-91323: Revert "Allow overriding a future compliance check in async…
5ac3d0f 
…io.Task (GH-32197)" (GH-95442) (GH-95652)

This reverts commit d4bb38f.
(cherry picked from commit 0342c93)

Co-authored-by: Łukasz Langa <[email protected]>
@ambv
ambv restored the revert-gh-32197 branch August 4, 2022 16:41
@ambv
ambv deleted the revert-gh-32197 branch August 5, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ambv @miss-islington @bedevere-bot @1st1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.