GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-47211: Remove function re.template() and flag re.TEMPLATE by serhiy-storchaka · Pull Request #32300 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Apr 4, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

They were undocumented and never working.

https://bugs.python.org/issue47211

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-47211: Remove function re.template() and flag re.TEMPLATE
7a17c27 
They were undocumented and never working.
@bedevere-bot bedevere-bot added the awaiting core review label Apr 4, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 4, 2022
@vstinner

vstinner commented Apr 5, 2022

Copy link
Copy Markdown
Member

I search for re.template() and re.TEMPLATE with the regex (?i)re.template and no project of top 5000 PyPI projects use it. So I'm fine with removing it with no deprecation period.

$ ./search_pypi_top.py PYPI-2022-01-26-TOP-5000/ '(?i)re.template' -o re_template
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Apr 5, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 5, 2022
@serhiy-storchaka
serhiy-storchaka merged commit b09184b into python:main Apr 6, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 6, 2022
@serhiy-storchaka
serhiy-storchaka deleted the remove-re-template branch April 6, 2022 16:53
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 12, 2022
3.11.0b1 regression: re.template removed without a deprecation period #92728
Closed
hroncok added a commit to hroncok/cpython that referenced this pull request May 24, 2022
@hroncok
Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (…
2e8f218 
…pythonGH-32300)"

This reverts commit b09184b.

Fixes python#92728
serhiy-storchaka pushed a commit that referenced this pull request May 25, 2022
@hroncok
gh-92728: Restore re.template, but deprecate it (GH-93161)
16a7e4a 
Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (GH-32300)"

This reverts commit b09184b.
@miss-islington miss-islington mentioned this pull request May 25, 2022
[3.11] gh-92728: Restore re.template, but deprecate it (GH-93161) #93206
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2022
@hroncok @miss-islington
pythongh-92728: Restore re.template, but deprecate it (pythonGH-93161)
f191b17 
Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (pythonGH-32300)"

This reverts commit b09184b.
(cherry picked from commit 16a7e4a)

Co-authored-by: Miro Hrončok <[email protected]>
miss-islington added a commit that referenced this pull request May 25, 2022
@miss-islington @hroncok
gh-92728: Restore re.template, but deprecate it (GH-93161)
74b205b 
Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (GH-32300)"

This reverts commit b09184b.
(cherry picked from commit 16a7e4a)

Co-authored-by: Miro Hrončok <[email protected]>
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jun 13, 2023
gh-105687: Remove deprecated objects from re module #105688
Merged
@wimglenn wimglenn mentioned this pull request Oct 24, 2024
Fix re pattern pretty print ipython/ipython#14558
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.