GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-92728: Restore re.template, but deprecate it by hroncok · Pull Request #93161 · python/cpython

Conversation

hroncok commented May 24, 2022

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

hroncok added 2 commits

May 24, 2022 10:24


          Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (…

2e8f218

…pythonGH-32300)"

This reverts commit b09184b.

Fixes python#92728


          Deprecate re.template

82e9f97

bedevere-bot added the awaiting review label

May 24, 2022

hroncok mentioned this pull request

May 24, 2022

3.11.0b1 regression: re.template removed without a deprecation period #92728

Closed

hroncok added 4 commits

May 24, 2022 10:59


          Blurb it!

88ed787


          Typos

b26b7b6


          What's new?

b80e4f4


          Update the comment for SRE_FLAG_TEMPLATE

1a97998

hroncok marked this pull request as ready for review

May 24, 2022 09:07

hroncok commented May 24, 2022

Copy link

Copy Markdown

Contributor Author

Considering the relevant function/flag was not documented, I have decided not to add a versionchanged thing to the documentation of the re module. Let me know if I should.

serhiy-storchaka reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hroncok commented

May 24, 2022

View reviewed changes

Comment thread

Lib/re/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka self-requested a review

May 24, 2022 09:25

serhiy-storchaka approved these changes

May 24, 2022

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/re/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/Library/2022-05-24-10-59-02.gh-issue-92728.zxTifq.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting merge and removed awaiting review labels

May 24, 2022

hroncok added 2 commits

May 24, 2022 12:02


          Add a note to the previous changelog entry.

cd4b0a0


          Also update the comment in re/__init__.py

773a6ad

serhiy-storchaka approved these changes

May 24, 2022

View reviewed changes

hroncok commented May 24, 2022

Copy link

Copy Markdown

Contributor Author

Could you please label this with 3.11 backport?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hroncok commented

May 24, 2022

View reviewed changes

Comment thread

Lib/test/test_re.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Typo

ef78163

serhiy-storchaka added the 3.11 only security fixes label

May 25, 2022

serhiy-storchaka merged commit 16a7e4a into python:main

May 25, 2022

bedevere-bot removed the awaiting merge label

May 25, 2022

serhiy-storchaka added needs backport to 3.11 only security fixes and removed 3.11 only security fixes labels

May 25, 2022

miss-islington commented May 25, 2022

Copy link

Copy Markdown

Contributor

Thanks @hroncok for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 25, 2022


          pythongh-92728: Restore re.template, but deprecate it (pythonGH-93161)

f191b17

Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (pythonGH-32300)"

This reverts commit b09184b.
(cherry picked from commit 16a7e4a)

Co-authored-by: Miro Hrončok <[email protected]>

bedevere-bot commented May 25, 2022

Copy link

Copy Markdown

GH-93206 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

May 25, 2022

miss-islington added a commit that referenced this pull request

May 25, 2022


          gh-92728: Restore re.template, but deprecate it (GH-93161)

74b205b

Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (GH-32300)"

This reverts commit b09184b.
(cherry picked from commit 16a7e4a)

Co-authored-by: Miro Hrončok <[email protected]>

hroncok deleted the dont_break_compatibility branch

May 25, 2022 10:17

wimglenn mentioned this pull request

Oct 24, 2024

Fix re pattern pretty print ipython/ipython#14558

Closed

donbarbos mentioned this pull request

Aug 10, 2025

[stdlib] Deprecate old functions python/typeshed#14553

Merged

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.