GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-31320: No traceback to sys.stderr in test_ssl by tiran · Pull Request #3360 · python/cpython

Conversation

@tiran

@tiran tiran commented Sep 5, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In case PROTOCOL_TLS_SERVER is used for both client context and server
context, the test thread dies with OSError. Catch OSError to avoid
traceback on sys.stderr

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue31320

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
bpo-31320: No traceback to sys.stderr in test_ssl
b6160e6 
In case PROTOCOL_TLS_SERVER is used for both client context and server
context, the test thread dies with OSError. Catch OSError to avoid
traceback on sys.stderr

Signed-off-by: Christian Heimes <[email protected]>
@tiran tiran added needs backport to 3.6 tests Tests in the Lib/test dir labels Sep 5, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 5, 2017
@bedevere-bot bedevere-bot added the awaiting merge label Sep 5, 2017
vstinner
vstinner approved these changes Sep 5, 2017
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
tiran merged commit 305e56c into python:master Sep 5, 2017
@miss-islington

miss-islington commented Sep 5, 2017

Copy link
Copy Markdown
Contributor

🐍🍒⛏🤖 Thanks @tiran for the PR, and @tiran for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.
Mariatta reacted with thumbs up emoji Mariatta reacted with laugh emoji Mariatta reacted with hooray emoji Mariatta reacted with heart emoji
All reactions
  • 👍 1 reaction
  • 😄 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran
tiran deleted the bpo-31320_test_ssl_traceback branch September 5, 2017 23:37
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2017
@tiran @miss-islington
[3.6] bpo-31320: No traceback to sys.stderr in test_ssl (pythonGH-3360)
e514ce7 
In case PROTOCOL_TLS_SERVER is used for both client context and server
context, the test thread dies with OSError. Catch OSError to avoid
traceback on sys.stderr

Signed-off-by: Christian Heimes <[email protected]>
(cherry picked from commit 305e56c)
@bedevere-bot

bedevere-bot commented Sep 5, 2017

Copy link
Copy Markdown

GH-3369 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Sep 5, 2017
Mariatta pushed a commit that referenced this pull request Sep 6, 2017
@miss-islington @Mariatta
[3.6] bpo-31320: No traceback to sys.stderr in test_ssl (GH-3360) (GH…
c506403 
…-3369)

In case PROTOCOL_TLS_SERVER is used for both client context and server
context, the test thread dies with OSError. Catch OSError to avoid
traceback on sys.stderr

Signed-off-by: Christian Heimes <[email protected]>
(cherry picked from commit 305e56c)
GadgetSteve pushed a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
@tiran @GadgetSteve
bpo-31320: No traceback to sys.stderr in test_ssl (python#3360)
bf0bc61 
In case PROTOCOL_TLS_SERVER is used for both client context and server
context, the test thread dies with OSError. Catch OSError to avoid
traceback on sys.stderr

Signed-off-by: Christian Heimes <[email protected]>
@Mariatta Mariatta removed the awaiting merge label Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@tiran @miss-islington @bedevere-bot @vstinner @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.