GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29660: traceback: Document that etype is ignored in some places. by Carreau · Pull Request #344 · python/cpython

Conversation

@Carreau

@Carreau Carreau commented Feb 27, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

See http://bugs.python.org/issue29660

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 27, 2017
vadmium
vadmium reviewed Feb 27, 2017
View reviewed changes
Comment thread Doc/library/traceback.rst Outdated

@vadmium vadmium Feb 27, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inferred (also repeated below)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Carreau Carreau Mar 2, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/traceback.rst Outdated

@vadmium vadmium Feb 27, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not seem to be the case for “format_exception_only”

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Carreau Carreau Mar 2, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/traceback.rst Outdated

@vadmium vadmium Feb 27, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem ideal. It is less compatible with older Python versions. If it needs clarifying at all, perhaps a comment would be better?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Carreau Carreau Mar 2, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner changed the title bpo-29660: Document that etype is ignored in some places. bpo-29660: traceback: Document that etype is ignored in some places. Mar 2, 2017
@vstinner vstinner added the docs Documentation in the Doc dir label Mar 2, 2017
@Carreau
bpo-29660: Document that etype is ignored in some places.
b4727b6 
See http://bugs.python.org/issue29660
@Carreau
Carreau force-pushed the doccument-deprecated-etype branch from 1069939 to b4727b6 Compare March 2, 2017 22:52
@Carreau

Carreau commented Mar 2, 2017

Copy link
Copy Markdown
Contributor Author

Thanks, sorry for the delay to fix. Comments should be addressed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta Mariatta added needs backport to 3.5 labels May 17, 2017
Mariatta
Mariatta reviewed May 17, 2017
View reviewed changes
Comment thread Doc/library/traceback.rst Outdated
print("*** print_tb:")
traceback.print_tb(exc_traceback, limit=1, file=sys.stdout)
print("*** print_exception:")
# exc_type below ignored on 3.5 and later

@Mariatta Mariatta May 17, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is ignored on 3.5 and later

The same for below :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Mariatta
add 'is' ignored
9df4d1b
Mariatta
Mariatta approved these changes Jun 1, 2017
View reviewed changes
@Mariatta
Mariatta merged commit cdb89cd into python:master Jun 1, 2017
@Mariatta

Mariatta commented Jun 1, 2017

Copy link
Copy Markdown
Member

Thanks @Carreau 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Carreau
Carreau deleted the doccument-deprecated-etype branch June 2, 2017 03:01
@Carreau
Carreau restored the doccument-deprecated-etype branch June 2, 2017 03:01
Carreau added a commit to Carreau/cpython that referenced this pull request Jun 2, 2017
@Carreau
[3.6] bpo-29660: traceback: Document that etype is ignored in some pl…
2104905 
…aces. (pythonGH-344)

(cherry picked from commit cdb89cd)
Carreau added a commit to Carreau/cpython that referenced this pull request Jun 2, 2017
@Carreau
[3.5] bpo-29660: traceback: Document that etype is ignored in some pl…
a1f1266 
…aces. (pythonGH-344)

(cherry picked from commit cdb89cd)
This was referenced Jun 2, 2017
[3.6] bpo-29660: traceback: Document that etype is ignored in some pl… #1913
Merged
[3.5] bpo-29660: traceback: Document that etype is ignored in some pl… #1914
Merged
@Mariatta Mariatta removed needs backport to 3.5 labels Jun 2, 2017
Mariatta pushed a commit that referenced this pull request Jun 2, 2017
@Carreau @Mariatta
bpo-29660: traceback: Document that etype is ignored in some places. (G…
e417d12 
…H-344) (GH-1913)

(cherry picked from commit cdb89cd)
Mariatta pushed a commit that referenced this pull request Jun 2, 2017
@Carreau @Mariatta
bpo-29660: traceback: Document that etype is ignored in some places. (G…
cca3d4a 
…H-344) (GH-1914)

(cherry picked from commit cdb89cd)
@Carreau
Carreau deleted the doccument-deprecated-etype branch June 2, 2017 03:39
akruis pushed a commit to stackless-dev/stackless that referenced this pull request Nov 1, 2017
@gvanrossum
Issue python#28556: merge 5 more typing changes from upstream (python…
83ec302 
…#340, python#344, python#348, python#349, python#350)
akruis pushed a commit to stackless-dev/stackless that referenced this pull request Nov 1, 2017
@gvanrossum
Issue python#28556: merge 5 more typing changes from upstream (python…
043a8bc 
…#340, python#344, python#348, python#349, python#350) (3.5->3.6)
akruis pushed a commit to stackless-dev/stackless that referenced this pull request Nov 1, 2017
@gvanrossum
Issue python#28556: merge 5 more typing changes from upstream (python…
52f2959 
…#340, python#344, python#348, python#349, python#350) (3.6->3.7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadmium vadmium vadmium left review comments
@Mariatta Mariatta Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Carreau @Mariatta @vadmium @vstinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.