GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Properly link against functions introduced in macOS 10.12 by maxbelanger · Pull Request #350 · python/cpython

Conversation

maxbelanger commented Feb 27, 2017

Copy link

Copy Markdown

Contributor

macOS Sierra/10.12 introduced new functions that are problematic to link against (i.e. getentropy, clock_gettime, etc) because autoconf detecting their presence isn't sufficient to guarantee they will be available downlevel. Building Python using Xcode 8 and the macOS 10.12 SDK and following Apple's recommended practices (see https://developer.apple.com/library/content/documentation/DeveloperTools/Conceptual/cross_development/Configuring/configuring.html), to set MACOSX_DEPLOYMENT_TARGET to the minimum version to be supported (e.g. 10.8) will result in these functions being weakly linked. While testing on macOS 10.12 works properly, running Python on an older (yet declared supported) version will trigger a crash when the symbol is used, as the code doesn't appear to support the symbol being weakly defined (who would). Essentially, AC_CHECK_FUNCS is not sufficient for these functions on macOS, so we need to do extra work.

This patch alters configure not to check when building for Darwin and MACOSX_DEPLOYMENT_TARGET is defined to a version below 10.12, allowing proper down-level support.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          first pass

4f0a857

the-knights-who-say-ni added the CLA not signed label

Feb 27, 2017

the-knights-who-say-ni commented Feb 27, 2017

Copy link

Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

If you don't have an account on b.p.o, please create one
Make sure your GitHub username is listed in "Your Details" at b.p.o
If you have not already done so, please sign the PSF contributor agreement. The "bugs.python.org username " requested by the form is the "Login name" field under "Your Details".
If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ned-deily commented Feb 27, 2017

Copy link

Copy Markdown

Member

Please open an issue on bugs.python.org for this. But, note that in general, we do not claim to support building Python for an older OS X version with a newer SDK using weak links.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ned-deily self-requested a review

February 27, 2017 18:28

maxbelanger commented Feb 27, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

Hey Ned, this is following up on http://bugs.python.org/issue27596. I took a closer look at the changes made in http://bugs.python.org/issue29057 but we don't think they solve the fundamental issue for our scenario (we deploy on 10.6-10.12 using the latest SDK, as Apple recommends), particularly when using Python 3.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mariatta removed the CLA not signed label

Feb 28, 2017

the-knights-who-say-ni added the CLA signed label

Feb 28, 2017

maxbelanger closed this

Oct 30, 2017

akruis pushed a commit to stackless-dev/stackless that referenced this pull request

Nov 1, 2017


          Issue python#28556: merge 5 more typing changes from upstream (python…

83ec302

…#340, python#344, python#348, python#349, python#350)

akruis pushed a commit to stackless-dev/stackless that referenced this pull request

Nov 1, 2017


          Issue python#28556: merge 5 more typing changes from upstream (python…

043a8bc

…#340, python#344, python#348, python#349, python#350) (3.5->3.6)

akruis pushed a commit to stackless-dev/stackless that referenced this pull request

Nov 1, 2017


          Issue python#28556: merge 5 more typing changes from upstream (python…

52f2959

…#340, python#344, python#348, python#349, python#350) (3.6->3.7)

jaraco pushed a commit that referenced this pull request

Dec 2, 2022


          Bump pytest-asyncio from 0.12.0 to 0.14.0 (#350)

f9e479c

Bumps [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio) from 0.12.0 to 0.14.0.
- [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases)
- [Commits](pytest-dev/pytest-asyncio@v0.12.0...v0.14.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

SonicField added a commit to SonicField/cpython that referenced this pull request

May 12, 2026


          docs/ops: NBS handle-namespace collision codification + proposed fix

9e2b652

Codification commit python#3 in post-c4 codification batch per supervisor
16:05:15Z dispatch. Anchors librarian 06:16Z (handle-namespace recurring
per-cycle observation) + pythia python#350 (cross-project collision queue) +
python#351 (per-cycle prediction confirmed by repeated fixup workarounds at
07:12Z, 08:10Z, 09:11Z, 10:12Z, 11:13Z, 12:50:32Z, 13:52:13Z, 14:53:48Z).

Documents:
- Cross-project handle collision class (multiple Phoenix-style teams on
  same OS user share role names like 'scribe', 'medic')
- Proximate driver: nbs-sidecar-restart line 153 handle-strip collapses
  compound handles like supervisor-vib -> supervisor, erasing project
  distinctness when project name follows role
- Current operational workaround: --root=PATH filter on every fixup call
- Proposed one-line fix: add SC_ROOT to dedup key so cross-project
  sidecars stay separate by default (lines 167 + 169 area in script)

The fix is local to nbs-sidecar-restart and does not require coordination
with nbs-sidecar itself. --root=PATH becomes an additional filter rather
than the only protection.

Doc-only commit; not modifying nbs-sidecar-restart in this Phoenix repo
(out of phoenix tree). Implementation deferred to whoever ships the
script change.

Reviewers

ned-deily

Awaiting requested review from ned-deily

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

maxbelanger commented Feb 27, 2017

Uh oh!

the-knights-who-say-ni commented Feb 27, 2017

Uh oh!

ned-deily commented Feb 27, 2017

Uh oh!

maxbelanger commented Feb 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

maxbelanger commented Feb 27, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.