GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-27494: Fix 2to3 handling of trailing comma after a generator expression by jstasiak · Pull Request #3771 · python/cpython

Conversation

@jstasiak

@jstasiak jstasiak commented Sep 26, 2017

Copy link
Copy Markdown
Contributor

While this is a valid Python 2 and Python 3 syntax lib2to3 would choke
on it:

    set(x for x in [],)

This patch changes the grammar definition used by lib2to3 so that the
actual Python syntax is supported now and backwards compatibility is
preserved.

https://bugs.python.org/issue27494

Note: there are some issues with the build of the first pull request I created (#60) to merge this change so this is a replacement pull request I create, hoping it'll fix things.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mscuthbert reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added the awaiting review label Sep 26, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 26, 2017
@jstasiak jstasiak mentioned this pull request Sep 26, 2017
bpo-27494: Fix a 2to3 parser bug (trailing comma) #60
Closed
@jstasiak
bpo-27494: Fix 2to3 handling of trailing comma after a generator expr…
b6dca9e 
…ession

While this is a valid Python 2 and Python 3 syntax lib2to3 would choke
on it:

    set(x for x in [],)

This patch changes the grammar definition used by lib2to3 so that the
actual Python syntax is supported now and backwards compatibility is
preserved.
@jstasiak
jstasiak force-pushed the fix-lib2to3 branch from 71b60a5 to b6dca9e Compare October 1, 2017 21:19
@jstasiak

jstasiak commented Oct 4, 2017

Copy link
Copy Markdown
Contributor Author

@ambv or @benjaminp may I ask for a review? If there's a more appropriate review I'd appreciate an information.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjaminp
reword
0756041
@benjaminp
benjaminp merged commit af810b3 into python:master Oct 5, 2017
@bedevere-bot bedevere-bot removed the awaiting review label Oct 5, 2017
@jstasiak

jstasiak commented Oct 5, 2017

Copy link
Copy Markdown
Contributor Author

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jstasiak
jstasiak deleted the fix-lib2to3 branch October 5, 2017 14:04
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 11, 2018
@serhiy-storchaka
Revert "closes bpo-27494: Fix 2to3 handling of trailing comma after a…
79d58f9 
… generator expression (python#3771)"

This reverts commit af810b3.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2018
@serhiy-storchaka @miss-islington
Revert "closes bpo-27494: Fix 2to3 handling of trailing comma after a…
99cc7f2 
… generator expression (pythonGH-3771)" (pythonGH-8241)

This reverts commit af810b3.

This is not valid syntax (see bpo-32012).
(cherry picked from commit 4b8a7f5)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jul 31, 2018
@serhiy-storchaka
Revert "closes bpo-27494: Fix 2to3 handling of trailing comma after …
4b8a7f5 
…a generator expression (GH-3771)" (#8241)

This reverts commit af810b3.

This is not valid syntax (see bpo-32012).
miss-islington added a commit that referenced this pull request Jul 31, 2018
@miss-islington @serhiy-storchaka
Revert "closes bpo-27494: Fix 2to3 handling of trailing comma after a…
9ecbe33 
… generator expression (GH-3771)" (GH-8241)

This reverts commit af810b3.

This is not valid syntax (see bpo-32012).
(cherry picked from commit 4b8a7f5)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jstasiak @benjaminp @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.