GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "closes bpo-27494: Fix 2to3 handling of trailing comma after a generator expression (#3771)" by serhiy-storchaka · Pull Request #8241 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 11, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit af810b3.

https://bugs.python.org/issue27494

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
serhiy-storchaka added 2 commits July 11, 2018 09:56
@serhiy-storchaka
Revert "closes bpo-27494: Fix 2to3 handling of trailing comma after a…
79d58f9 
… generator expression (python#3771)"

This reverts commit af810b3.
@serhiy-storchaka
Update news entries.
b26b085
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Jul 11, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 11, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Jul 11, 2018
@serhiy-storchaka
serhiy-storchaka requested a review from benjaminp July 23, 2018 20:42
benjaminp
benjaminp approved these changes Jul 31, 2018
View reviewed changes
@serhiy-storchaka
serhiy-storchaka merged commit 4b8a7f5 into python:master Jul 31, 2018
@bedevere-bot

bedevere-bot commented Jul 31, 2018

Copy link
Copy Markdown

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 31, 2018

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 31, 2018
@serhiy-storchaka
serhiy-storchaka deleted the revert-pr-3771 branch July 31, 2018 06:34
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Jul 31, 2018
@bedevere-bot

bedevere-bot commented Jul 31, 2018

Copy link
Copy Markdown

GH-8580 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2018
@serhiy-storchaka @miss-islington
Revert "closes bpo-27494: Fix 2to3 handling of trailing comma after a…
99cc7f2 
… generator expression (pythonGH-3771)" (pythonGH-8241)

This reverts commit af810b3.

This is not valid syntax (see bpo-32012).
(cherry picked from commit 4b8a7f5)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington added a commit that referenced this pull request Jul 31, 2018
@miss-islington @serhiy-storchaka
Revert "closes bpo-27494: Fix 2to3 handling of trailing comma after a…
9ecbe33 
… generator expression (GH-3771)" (GH-8241)

This reverts commit af810b3.

This is not valid syntax (see bpo-32012).
(cherry picked from commit 4b8a7f5)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp benjaminp approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@serhiy-storchaka @bedevere-bot @miss-islington @benjaminp @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.