GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [backport to 2.7] bpo-28598: Support __rmod__ for RHS subclasses of str in % string formatting operations by mjpieters · Pull Request #382 · python/cpython

Conversation

@mjpieters

@mjpieters mjpieters commented Mar 1, 2017

Copy link
Copy Markdown
Contributor

Backport of #51

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Martijn Pieters added 2 commits March 1, 2017 15:38
Martijn Pieters
[backport to 2.7] bpo-28598: Support __rmod__ for RHS subclasses of s…
9097de9 
…tr in % string formatting operations
Martijn Pieters
Record change in NEWS
ee2754c
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 1, 2017
@zhangyangyu

zhangyangyu commented Mar 1, 2017

Copy link
Copy Markdown
Member

Ohh, I have done it in #366 .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag

berkerpeksag commented Mar 1, 2017

Copy link
Copy Markdown
Member

Thanks, @mjpieters! This is already done in #366.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag berkerpeksag closed this Mar 1, 2017
@mjpieters

mjpieters commented Mar 1, 2017

Copy link
Copy Markdown
Contributor Author

😃 I realised when I saw the conflict, and was scouring my overflowing inbox for the ticket correspondence. Thanks for doing this, @zhangyangyu!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mjpieters
mjpieters deleted the bpo28598_backport_2.7 branch March 1, 2017 16:55
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
Fix Automerge functionality (#382)
dc67f1e 
* Fix Automerge functionality

Look up conclusions from check runs in addition to status checks.

Ensure all check runs have completed.
Ensure there is no "failure" or "timed_out" result from the check runs

Fixes python/miss-islington#375

* 🐍🌚🤖 Formatted using `black`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mjpieters @zhangyangyu @berkerpeksag @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.