GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-26133: Clear signals list on interpreter finalizing by asvetlov · Pull Request #5002 · python/cpython

Conversation

@asvetlov

@asvetlov asvetlov commented Dec 24, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

See comments in #4956

https://bugs.python.org/issue26133

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@asvetlov
bpo-26133: Clear signals list on interpreter finalizing
8200c66
@asvetlov
asvetlov requested a review from 1st1 as a code owner December 24, 2017 09:32
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 24, 2017
@bedevere-bot bedevere-bot added the awaiting merge label Dec 24, 2017
@asvetlov asvetlov added topic-asyncio skip news labels Dec 24, 2017
1st1
1st1 approved these changes Dec 24, 2017
View reviewed changes
@asvetlov asvetlov added the needs backport to 3.6 label Dec 24, 2017
@asvetlov
asvetlov merged commit 4f146f9 into python:master Dec 24, 2017
@miss-islington

miss-islington commented Dec 24, 2017

Copy link
Copy Markdown
Contributor

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 24, 2017
@asvetlov
asvetlov deleted the postfix-bpo-26133 branch December 24, 2017 11:50
@bedevere-bot

bedevere-bot commented Dec 24, 2017

Copy link
Copy Markdown

GH-5003 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Dec 24, 2017
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 24, 2017
@asvetlov @miss-islington
bpo-26133: Clear signals list on interpreter finalizing (pythonGH-5002)
07ab4f5 
(cherry picked from commit 4f146f9)
asvetlov pushed a commit that referenced this pull request Dec 24, 2017
@miss-islington @asvetlov
bpo-26133: Clear signals list on interpreter finalizing (GH-5002) (#5003
5ff5d11 
)

(cherry picked from commit 4f146f9)
@lelit

lelit commented Dec 25, 2017

Copy link
Copy Markdown
Contributor

There are a couple of typos in commit 4f146f9:

  • "warinigs" -> "warnings"
  • "unsubsription" -> "unsubscription"
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asvetlov

asvetlov commented Dec 25, 2017

Copy link
Copy Markdown
Contributor Author

Nice catch!
Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asvetlov asvetlov mentioned this pull request Dec 25, 2017
bpo-26133: Fix typos #5010
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@asvetlov @miss-islington @bedevere-bot @lelit @1st1 @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.