GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-26133: Fix typos by asvetlov · Pull Request #5010 · python/cpython

Conversation

@asvetlov

@asvetlov asvetlov commented Dec 25, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

As reported in #5002

https://bugs.python.org/issue26133

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@asvetlov
Fix typos
5c9280d
@asvetlov
asvetlov requested a review from 1st1 as a code owner December 25, 2017 21:21
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 25, 2017
@bedevere-bot bedevere-bot added the awaiting merge label Dec 25, 2017
@asvetlov asvetlov added the skip news label Dec 25, 2017
1st1
1st1 reviewed Dec 25, 2017
View reviewed changes
Comment thread Lib/asyncio/unix_events.py Outdated
warnings.warn(f"Closing the loop {self!r} "
f"on interpreter shutdown "
f"stage, signal unsubsription is disabled",
f"stage, signal unsubscription is disabled",

@1st1 1st1 Dec 25, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsubscription -> skipping signal handlers removal

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@asvetlov asvetlov Dec 25, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Is now ok?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@asvetlov
Fix warning text
82f3d60
@1st1

1st1 commented Dec 25, 2017

Copy link
Copy Markdown
Member

Maybe mock sys.is_finalizing and test that branch of code?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asvetlov
Add test
bf29780
@asvetlov asvetlov added the needs backport to 3.6 label Dec 26, 2017
@asvetlov
asvetlov merged commit a8f4e15 into python:master Dec 26, 2017
@miss-islington

miss-islington commented Dec 26, 2017

Copy link
Copy Markdown
Contributor

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 26, 2017
@asvetlov
asvetlov deleted the bpo-26133 branch December 26, 2017 09:53
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 26, 2017
@asvetlov @miss-islington
bpo-26133: Fix typos (pythonGH-5010)
771b118 
* Fix typos
* Change warning text
* Add test
(cherry picked from commit a8f4e15)
@bedevere-bot

bedevere-bot commented Dec 26, 2017

Copy link
Copy Markdown

GH-5014 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Dec 26, 2017
asvetlov pushed a commit that referenced this pull request Dec 26, 2017
@miss-islington @asvetlov
bpo-26133: Fix typos (GH-5010) (#5014)
32518b4 
* Fix typos
* Change warning text
* Add test
(cherry picked from commit a8f4e15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@asvetlov @1st1 @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.