GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "bpo-29571: Use correct locale encoding in test_re (#149)" by benjaminp · Pull Request #554 · python/cpython

Conversation

@benjaminp

@benjaminp benjaminp commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

This reverts commit ace5c0f. The correct fix was in 02371e0. This change is breaking Windows.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benjaminp
Revert "bpo-29571: Use correct locale encoding in test_re (#149)"
270a1e6 
This reverts commit ace5c0f.
@benjaminp benjaminp added needs backport to 2.7 labels Mar 8, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 8, 2017
@benjaminp benjaminp added the needs backport to 3.5 label Mar 8, 2017
@benjaminp
benjaminp merged commit 21a7431 into master Mar 8, 2017
@benjaminp
benjaminp deleted the benjamin-rv-re-locale-change branch March 8, 2017 06:48
benjaminp added a commit that referenced this pull request Mar 8, 2017
@benjaminp
Revert "bpo-29571: Use correct locale encoding in test_re (#149)" (#554)
65ad8d5 
This reverts commit ace5c0f.
benjaminp added a commit that referenced this pull request Mar 8, 2017
@benjaminp
Revert "bpo-29571: Use correct locale encoding in test_re (#149)" (#554)
604b94d 
This reverts commit ace5c0f.
benjaminp added a commit that referenced this pull request Mar 8, 2017
@benjaminp
Revert "bpo-29571: Use correct locale encoding in test_re (#149)" (#554…
312f7df 
…) (#556)

This reverts commit ace5c0f.
benjaminp added a commit that referenced this pull request Mar 8, 2017
@benjaminp
Revert "bpo-29571: Use correct locale encoding in test_re (#149)" (#554…
6a4b04c 
…) (#555)

This reverts commit ace5c0f.
@Mariatta Mariatta removed needs backport to 3.5 labels Mar 9, 2017
@Mariatta

Mariatta commented Mar 9, 2017

Copy link
Copy Markdown
Member

Since this has been backported to 3.5 and 3.6, I'm removing the needs backport.. label.

It doesn't seem like this need to be backported to 2.7 though?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjaminp benjaminp removed the needs backport to 2.7 label Mar 9, 2017
@benjaminp

benjaminp commented Mar 9, 2017

Copy link
Copy Markdown
Contributor Author

Correct. I overestimated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tirkarthi tirkarthi mentioned this pull request Feb 28, 2019
bpo-29571: Fix test_re.test_locale_flag() #12099
Merged
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@dependabot
Bump cachetools from 5.0.0 to 5.1.0 (#554)
d513e49 
Bumps [cachetools](https://github.com/tkem/cachetools) from 5.0.0 to 5.1.0.
- [Release notes](https://github.com/tkem/cachetools/releases)
- [Changelog](https://github.com/tkem/cachetools/blob/master/CHANGELOG.rst)
- [Commits](tkem/cachetools@v5.0.0...v5.1.0)

---
updated-dependencies:
- dependency-name: cachetools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@benjaminp @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.