GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Travis CI: run rstlint.py in the docs job by vstinner · Pull Request #68 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 13, 2017

Copy link
Copy Markdown
Member

Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
Travis CI: run rstlint.py in the docs job
0ffa5e4 
Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 13, 2017
@vstinner vstinner added docs Documentation in the Doc dir tests Tests in the Lib/test dir labels Feb 13, 2017
@berkerpeksag berkerpeksag mentioned this pull request Feb 13, 2017
Fix trailing whitespaces in Doc/faq/windows.rst #69
Closed
berkerpeksag
berkerpeksag approved these changes Feb 13, 2017
View reviewed changes
@vstinner
vstinner merged commit 2b50186 into python:master Feb 13, 2017
@berkerpeksag berkerpeksag added backport to 3.5 labels Feb 13, 2017
@JDLH

JDLH commented Feb 13, 2017

Copy link
Copy Markdown
Contributor

Thank you for catching this. I authored the trailing spaces in those two lines.
My "test suite" for the documentation was make html. I didn't know to run rstlint.py as well.

It would have helped me to have this check in some sort of make test in Doc/Makefile. It would also have helped me to have a reference to this doc testing in https://cpython-devguide.readthedocs.io/docquality.html .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Feb 13, 2017 via email

Copy link
Copy Markdown
Member Author
2017-02-13 21:28 GMT+01:00 Jim DeLaHunt <[email protected]>:
It would have helped me to have this check in some sort of make test in Doc/Makefile. It would also have helped me to have a reference to this doc testing in https://cpython-devguide.readthedocs.io/docquality.html .
You might propose a patch https://github.com/python/devguide or you can now rely on the Travis CI "docs" job for that ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zware

zware commented Feb 14, 2017

Copy link
Copy Markdown
Member

Note that running rstlint is available as make check.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
methane referenced this pull request in methane/cpython Feb 14, 2017
@vstinner @methane
Travis CI: run rstlint.py in the docs job (#68)
a78efcb 
Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.
methane referenced this pull request in methane/cpython Feb 14, 2017
@vstinner @methane
Travis CI: run rstlint.py in the docs job (#68)
8eaa1d0 
Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.
@berkerpeksag

berkerpeksag commented Feb 14, 2017

Copy link
Copy Markdown
Member

Note that running rstlint is available as make check.

Good point, opened #96. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit that referenced this pull request Feb 15, 2017
@vstinner
Backport36 doc fixes: PR#68 and PR#124 (#125)
b300c66 
* Travis CI: run rstlint.py in the docs job (#68)

Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.
(cherry picked from commit 2b50186)

* Doc/Makefile: set PYTHON to python3 (#124)

rstlint.py run by "make check" doesn't support Python 2.

"make venv" runs "$(PYTHON) -m venv", whereas Python 2 doens't
provide the venv module: it's a module of Python 3 standard library.

(cherry picked from commit 91b0e7d)
vstinner added a commit that referenced this pull request Feb 16, 2017
@vstinner
Backport35 doc fixes: PR#68 and PR#124 (#125) (#126)
5e04dfe 
* Travis CI: run rstlint.py in the docs job (#68)

Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.
(cherry picked from commit 2b50186)

* Doc/Makefile: set PYTHON to python3 (#124)

rstlint.py run by "make check" doesn't support Python 2.

"make venv" runs "$(PYTHON) -m venv", whereas Python 2 doens't
provide the venv module: it's a module of Python 3 standard library.

(cherry picked from commit 91b0e7d)
(cherry picked from commit b300c66)
ncoghlan pushed a commit that referenced this pull request Feb 19, 2017
@methane @ncoghlan
[backport to 3.6] bpo-29529: Add .travis.yml to 3.6 branch (#25)
3337d33 
* Add .travis.yml to 3.6 branch

* Travis CI: run rstlint.py in the docs job (#68)

Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.

* Only run CI checks when appropriate files have changed (#74)

Closes python/core-workflow#14

* Use 'make check' instead of 'python3 tools/rstlint.py' (#96)
ncoghlan pushed a commit that referenced this pull request Feb 19, 2017
@methane @ncoghlan
[backport to 3.5] bpo-29529: Add .travis.yml to 3.5 branch (#26)
24bfe15 
* Add .travis.yml to 3.5 branch

* Only run CI checks when appropriate files have changed (#74)

Closes python/core-workflow#14

* Travis CI: run rstlint.py in the docs job (#68)

Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.

* Use 'make check' instead of 'python3 tools/rstlint.py' (#96)
@methane methane removed needs backport to 3.5 labels Feb 22, 2017
@vstinner
vstinner deleted the travis_doc_linter branch June 15, 2017 23:06
colesbury referenced this pull request in colesbury/nogil Oct 6, 2021
@colesbury
mimalloc: consider heap tag when checking available abandoned pages
ada086b 
The logic in mi_segment_check_free didn't match the logic in
mi_segment_reclaim/right_page_reclaimed, which led to a segment
being reclaimed that did not have available pages for the
appropriate heap. This triggered an assertion error in
mi_segment_page_alloc_in.

Bug was probably introduced in 45e0ec5

Fixes #68
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @Mariatta
Update aiohttp from 3.0.4 to 3.0.5 (GH-68)
87e474e
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@jaraco
Update changelog. Closes python#68.
7c425c1
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
Zach Burnett
rename .readthedocs.yml to .readthedocs.yaml (RTD docs indicate t…
5467524 
…hat `.readthedocs.yml` will be deprecated) (python#68)
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
heap-use-after-free in _PyFunction_LookupByVersion #108253
Closed
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Crash running PyO3 tests with --test-threads=1000 #124375
Closed
This was referenced Feb 11, 2025
segmentfault when pip installing setuptools #129992
Closed
segmentfault when pip installing setuptools #129993
Closed
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Apr 18, 2025
@AA-Turner
t-strings: Add more syntax tests (python#68)
e6da757
@sergey-miryanov sergey-miryanov mentioned this pull request Dec 18, 2025
Observed memory leak in ssl library: Python 3.14 GC issue #142516
Closed
@ngoldbaum ngoldbaum mentioned this pull request Mar 6, 2026
Remove deprecated and undocumented function ctypes.SetPointerType #133866
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@vstinner @JDLH @zware @berkerpeksag @methane @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.