GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-32604: Improve subinterpreter tests. by ericsnowcurrently · Pull Request #6914 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented May 16, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add more tests for subinterpreters. This patch also fixes a few small defects in the channel implementation.

https://bugs.python.org/issue32604

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 18 commits May 16, 2018 12:41
@ericsnowcurrently
Convert channel IDs into channels when shared.
828a227
@ericsnowcurrently
Only convert channel IDs when requested.
bac0f12
@ericsnowcurrently
channel_drop_interpreter -> channel_release.
5242a34
@ericsnowcurrently
Organize tests.
7b2407d
@ericsnowcurrently
Fix function signatures.
6a5d1fc
@ericsnowcurrently
Add InterpreterID/ChannelID.__str__().
c34ff90
@ericsnowcurrently
Return an InterpreterID from get_main().
cbbc562
@ericsnowcurrently
Add support for int.
49e8065
@ericsnowcurrently
Correctly handle \x00 when sharing bytes.
cb41fa5
@ericsnowcurrently
Test channel_close() across a broad spectrum of cases.
13e6b7a
@ericsnowcurrently
Fix a typo.
2ee8cb0
@ericsnowcurrently
Add an exhaustive set of permutated tests for close_channel().
ecb5834
@ericsnowcurrently
Fix run_action() for close operations.
262e53e
@ericsnowcurrently
Skip the exhaustive tests.
7028808
@ericsnowcurrently
Add a note about lookup of cross-interpreter types.
5479620
@ericsnowcurrently
Add support for str.
13c51d4
@ericsnowcurrently
Move the normal channel_close() tests.
4cf75a2
@ericsnowcurrently
Do not mask errors in _channel_recv().
bffbbfc
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 16, 2018
@bedevere-bot bedevere-bot added the awaiting merge label May 16, 2018
@ericsnowcurrently ericsnowcurrently added the skip news label May 16, 2018
@ericsnowcurrently
ericsnowcurrently merged commit 6d2cd90 into python:master May 16, 2018
@bedevere-bot

bedevere-bot commented May 16, 2018

Copy link
Copy Markdown

@ericsnowcurrently: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 16, 2018
@ericsnowcurrently
ericsnowcurrently deleted the interpreters-tests branch May 16, 2018 20:46
This was referenced May 30, 2018
bpo-33615: avoid extra decref #7251
Merged
bpo-33615: Temporarily disable a test that is triggering crashes on a few buildbots. #7288
Merged
ericsnowcurrently added a commit that referenced this pull request May 31, 2018
@ericsnowcurrently
bpo-33615: Temporarily disable a test that is triggering crashes on a…
110bc01 
… few buildbots. (gh-7288)

For bpo-32604 I added some subinterpreter-related tests (see #6914) that are causing crashes on a few buildbots. I'm working on fixing the crashes (see #7251).  This change temporarily disables the triggering test.
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jun 1, 2018
bpo-33724: Use the right format code for int64_t in subinterpreters code. #7330
Merged
ericsnowcurrently added a commit that referenced this pull request Jun 2, 2018
@ericsnowcurrently
bpo-33615: Re-enable a subinterpreter test. (gh-7251)
6379913 
For bpo-32604 I added extra subinterpreter-related tests (see #6914), which caused a few buildbots to crash. This patch fixes the crash by ensuring that refcounts in channels are handled properly.
@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 24, 2018
improve subinterpreter tests ericsnowcurrently/multi-core-python#9
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.