GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-33615: avoid extra decref by ericsnowcurrently · Pull Request #7251 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented May 30, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

For bpo-32604 I added extra subinterpreter-related tests (see #6914), which caused a few buildbots to fail. This patch ensures that refcounts in channels are handled properly.

WIP: I'll be iterating against the failing buildbots (particularly "x86 Gentoo Refleaks 3.x") until this is resolved. The problem may have already existed before #6914 (and only surfaced with the new tests). However, I'm going to start from #6914 and then dive deeper. My first stab at the problem involves preventing a race (albeit an unlikely one) in _PyObject_GetCrossInterpreterData().

https://bugs.python.org/issue33615

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 30, 2018
@bedevere-bot bedevere-bot added the awaiting merge label May 30, 2018
@ericsnowcurrently ericsnowcurrently added the skip news label May 30, 2018
vstinner
vstinner approved these changes May 30, 2018
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve blindly the PR just because any attempt to fix the annoying test failure is a good idea :-D Also, I trust Eric to understand his own code :-D

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner

vstinner commented May 31, 2018

Copy link
Copy Markdown
Member

Hum, the change doesn't work yet...

test_run_string_arg_resolved (test.test__xxsubinterpreters.ChannelTests) ... Fatal Python error: Objects/dictobject.c:557 object at 0x14dbb111ec48 has negative ref count -2604246222170760230
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 31, 2018

Copy link
Copy Markdown
Member

Oops sorry, I forgot to mention that the crash comes from Travis CI:
https://travis-ci.org/python/cpython/jobs/385779931
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently

ericsnowcurrently commented May 31, 2018

Copy link
Copy Markdown
Member Author

Yeah, I've been working on this whenever I can spare some time. I haven't been able to reproduce the issue locally (something racy is happening) so I was planning to rely on the buildbots to verify when I've fixed the issue. I'm actually glad things failed on CI since it reduces the latency of results (vs. buildbots). :) The current PR is the first thing I've tried to fix the issue.

Also, note that with clang the PR led to a refcount-related abort, whereas with GCC it segfaulted. I'd be much more likely to resolve this quickly if I could see a C-level backtrace on CI/buildbots (and moreso if I could repro locally), but I expect that isn't an option. :/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 31, 2018
bpo-33615: Temporarily disable a test that is triggering crashes on a few buildbots. #7288
Merged
ericsnowcurrently added a commit that referenced this pull request May 31, 2018
@ericsnowcurrently
bpo-33615: Temporarily disable a test that is triggering crashes on a…
110bc01 
… few buildbots. (gh-7288)

For bpo-32604 I added some subinterpreter-related tests (see #6914) that are causing crashes on a few buildbots. I'm working on fixing the crashes (see #7251).  This change temporarily disables the triggering test.
@ericsnowcurrently
ericsnowcurrently force-pushed the fix-channel-test-fatal-error branch from fe153c4 to 19a530c Compare June 1, 2018 22:09
ericsnowcurrently added 3 commits June 1, 2018 16:52
@ericsnowcurrently
Re-enable the crashing test.
28c15d9
@ericsnowcurrently
Move incref responsibility to getdata funcs.
435ce8b
@ericsnowcurrently
Factor out _call_in_interpreter().
ea22ea3
@ericsnowcurrently
ericsnowcurrently force-pushed the fix-channel-test-fatal-error branch from 19a530c to ea22ea3 Compare June 1, 2018 22:52
@ericsnowcurrently

ericsnowcurrently commented Jun 1, 2018

Copy link
Copy Markdown
Member Author

FYI, I'm running this against the custom buildbot builders before merging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently

ericsnowcurrently commented Jun 2, 2018

Copy link
Copy Markdown
Member Author

The custom build looks good so I'm going to merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently ericsnowcurrently changed the title [WIP] bpo-33615: avoid extra decref bpo-33615: avoid extra decref Jun 2, 2018
@ericsnowcurrently
ericsnowcurrently merged commit 6379913 into python:master Jun 2, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 2, 2018
@ericsnowcurrently
ericsnowcurrently deleted the fix-channel-test-fatal-error branch June 4, 2018 15:21
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.