GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.6] bpo-33967: Remove use of deprecated assertRaisesRegexp() (GH-8261) by miss-islington · Pull Request #8295 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 16, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

It was added in test_functools at 445f1b3.
(cherry picked from commit 9e9b2c3)

Co-authored-by: Zackery Spytz [email protected]

https://bugs.python.org/issue33967

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZackerySpytz @miss-islington
bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
bb9e6c7 
It was added in test_functools at 445f1b3.
(cherry picked from commit 9e9b2c3)

Co-authored-by: Zackery Spytz <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 16, 2018
@bedevere-bot bedevere-bot added the skip news label Jul 16, 2018
@bedevere-bot bedevere-bot mentioned this pull request Jul 16, 2018
bpo-33967: Remove use of deprecated assertRaisesRegexp() #8261
Merged
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jul 16, 2018
vstinner
vstinner approved these changes Jul 16, 2018
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 16, 2018
@vstinner
vstinner merged commit 336c953 into python:3.6 Jul 16, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 16, 2018
@miss-islington
miss-islington deleted the backport-9e9b2c3-3.6 branch July 16, 2018 09:26
@gaborbernat gaborbernat mentioned this pull request Jun 3, 2026
Remove private stdlib helpers orphaned by past removals #150882
Closed
gaborbernat added a commit to gaborbernat/cpython that referenced this pull request Jun 3, 2026
@gaborbernat
pythongh-150882: Remove unused shutil._ensure_directory
448cb74 
Introduced in python#8295 alongside shutil.unpack_archive() as a helper that
created the parent directory of each extracted member.

Orphaned by pythongh-146581 (pythonGH-146591), the ZIP path-traversal fix, which
reworked _unpack_zipfile() to create directories inline and deleted the
last _ensure_directory(targetpath) call site in the same change.

Since then the private helper has had no caller: a word-boundary search
across Lib, Modules, Python, Objects and Include finds zero references
outside its own definition, and a GitHub code search finds no downstream
importers.
This was referenced Jun 3, 2026
gh-150885: Remove unused shutil._ensure_directory #150883
Merged
Remove unused private function shutil._ensure_directory #150885
Closed
gaborbernat added a commit to gaborbernat/cpython that referenced this pull request Jun 3, 2026
@gaborbernat
pythongh-150885: Remove unused shutil._ensure_directory
5de9387 
Introduced in python#8295 alongside shutil.unpack_archive() as a helper that
created the parent directory of each extracted member.

Orphaned by pythongh-146581 (pythonGH-146591), the ZIP path-traversal fix, which
reworked _unpack_zipfile() to create directories inline and deleted the
last _ensure_directory(targetpath) call site in the same change.

Since then the private helper has had no caller: a word-boundary search
across Lib, Modules, Python, Objects and Include finds zero references
outside its own definition, and a GitHub code search finds no downstream
importers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @ZackerySpytz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.