GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-33967: Remove use of deprecated assertRaisesRegexp() by ZackerySpytz · Pull Request #8261 · python/cpython

Conversation

ZackerySpytz commented Jul 12, 2018 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

It was added in 445f1b3.

https://bugs.python.org/issue33967

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          bpo-33967: Fix use of deprecated assertRaisesRegexp() in test_functools

25ff803

It was added in 445f1b3.

ZackerySpytz requested review from ncoghlan and rhettinger as code owners

July 12, 2018 02:09

the-knights-who-say-ni added the CLA signed label

Jul 12, 2018

bedevere-bot added the awaiting review label

Jul 12, 2018

ZackerySpytz mentioned this pull request

Jul 12, 2018

bpo-33967: singledispatch raises TypeError when no positional arguments #8184

Merged


          Update test_functools.py

37071b6

methane added the skip news label

Jul 12, 2018

methane changed the title ~~bpo-33967: Fix use of deprecated assertRaisesRegexp() in test_functools~~ bpo-33967: Remove use of deprecated assertRaisesRegexp()

Jul 12, 2018


          Update test_functools.py

29fb9a2

methane merged commit 9e9b2c3 into python:master

Jul 12, 2018

bedevere-bot removed the awaiting review label

Jul 12, 2018

ZackerySpytz deleted the test_functools_werror_fail branch

July 12, 2018 03:57

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Jul 14, 2018


          Merge branch 'master' into bitwise_docs

11c1706

* master: (2633 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Jul 15, 2018


          Merge branch 'master' into fix-issue8525

fdc3a3d

* master: (1159 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...

vstinner added needs backport to 3.6 labels

Jul 16, 2018

miss-islington commented Jul 16, 2018

Copy link

Copy Markdown

Contributor

Thanks @ZackerySpytz for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Jul 16, 2018

Copy link

Copy Markdown

Contributor

Thanks @ZackerySpytz for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Jul 16, 2018

Copy link

Copy Markdown

GH-8295 is a backport of this pull request to the 3.6 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.6 label

Jul 16, 2018

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 16, 2018


          bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)

bb9e6c7

It was added in test_functools at 445f1b3.
(cherry picked from commit 9e9b2c3)

Co-authored-by: Zackery Spytz <[email protected]>

bedevere-bot removed the needs backport to 3.7 label

Jul 16, 2018

bedevere-bot commented Jul 16, 2018

Copy link

Copy Markdown

GH-8296 is a backport of this pull request to the 3.7 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 16, 2018


          bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)

6eec9c6

It was added in test_functools at 445f1b3.
(cherry picked from commit 9e9b2c3)

Co-authored-by: Zackery Spytz <[email protected]>

vstinner pushed a commit that referenced this pull request

Jul 16, 2018


          bpo-33967: Remove use of deprecated assertRaisesRegexp() (GH-8261) (G…

336c953

…H-8295)

It was added in test_functools at 445f1b3.
(cherry picked from commit 9e9b2c3)

Co-authored-by: Zackery Spytz <[email protected]>

vstinner pushed a commit that referenced this pull request

Jul 16, 2018


          bpo-33967: Remove use of deprecated assertRaisesRegexp() (GH-8261) (G…

0a820a2

…H-8296)

It was added in test_functools at 445f1b3.
(cherry picked from commit 9e9b2c3)

Co-authored-by: Zackery Spytz <[email protected]>

serhiy-storchaka reviewed

Jul 16, 2018

View reviewed changes

Comment thread

Lib/test/test_functools.py

		pass
		msg = 'f requires at least 1 positional argument'
		with self.assertRaisesRegexp(TypeError, msg):
		with self.assertRaises(TypeError, msg=msg):

serhiy-storchaka Jul 16, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct use of msg. The correct code is:

with self.assertRaisesRegex(TypeError, msg):

The msg argument of assertRaises() is used for reporting a failure. But it should be used for testing the error message.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Jul 16, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the code looks wrong, you should reopen https://bugs.python.org/issue33967 and comment there, otherwise your comment may be lost.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

methane Jul 17, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. It was my mistake.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Jul 21, 2018


          Merge branch 'master' of github.com:CuriousLearner/cpython into fix-i…

7b039a0

…ssue-33014

* 'master' of github.com:CuriousLearner/cpython: (722 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...

Reviewers

vstinner

vstinner left review comments

methane

methane left review comments

serhiy-storchaka

serhiy-storchaka left review comments

ncoghlan

Awaiting requested review from ncoghlan

rhettinger

Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ZackerySpytz commented Jul 12, 2018 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented Jul 16, 2018

Uh oh!

miss-islington commented Jul 16, 2018

Uh oh!

bedevere-bot commented Jul 16, 2018

Uh oh!

bedevere-bot commented Jul 16, 2018

Uh oh!

serhiy-storchaka Jul 16, 2018

Choose a reason for hiding this comment

Uh oh!

vstinner Jul 16, 2018

Choose a reason for hiding this comment

Uh oh!

methane Jul 17, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ZackerySpytz commented Jul 12, 2018 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.