GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — smtplib documentation fixes by scop · Pull Request #8708 · python/cpython

Conversation

scop commented Aug 8, 2018

Copy link

Copy Markdown

Contributor

Not sure if this needs a bpo entry -- let me know if it does and I'll go file it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

scop added 3 commits

August 8, 2018 11:32


          SMTP.startssl: Fix doc on keyfile and certfile use

f647971


          SMTP.startssl: Add missing keyfile and certfile deprecation notice

1044efd


          SMTP: Doc grammar fixes

456fd69

scop requested a review from a team as a code owner

August 8, 2018 08:40

the-knights-who-say-ni added the CLA signed label

Aug 8, 2018

bedevere-bot added docs

Documentation in the Doc dir

awaiting review labels

Aug 8, 2018

Mariatta added needs backport to 3.6 skip issue skip news labels

Aug 9, 2018

Mariatta approved these changes

Aug 9, 2018

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Aug 9, 2018

Mariatta commented Aug 9, 2018

Copy link

Copy Markdown

Member

Thanks. News entry or bpo issue won't be necessary here. I think this looks good, but I'll wait a couple days and see if @python/email-team wants to review before I merge.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mariatta merged commit da12063 into python:master

Aug 13, 2018

miss-islington commented Aug 13, 2018

Copy link

Copy Markdown

Contributor

Thanks @scop for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Aug 13, 2018

Mariatta commented Aug 13, 2018

Copy link

Copy Markdown

Member

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Aug 13, 2018

Copy link

Copy Markdown

GH-8753 is a backport of this pull request to the 3.7 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.7 label

Aug 13, 2018

bedevere-bot commented Aug 13, 2018

Copy link

Copy Markdown

GH-8754 is a backport of this pull request to the 3.6 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.6 label

Aug 13, 2018

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 13, 2018


          smtplib documentation fixes (pythonGH-8708)

4400ae8

* SMTP.startssl: Fix doc on keyfile and certfile use

* SMTP.startssl: Add missing keyfile and certfile deprecation notice

* SMTP: Doc grammar fixes
(cherry picked from commit da12063)

Co-authored-by: Ville Skyttä <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 13, 2018


          smtplib documentation fixes (pythonGH-8708)

6ea9507

* SMTP.startssl: Fix doc on keyfile and certfile use

* SMTP.startssl: Add missing keyfile and certfile deprecation notice

* SMTP: Doc grammar fixes
(cherry picked from commit da12063)

Co-authored-by: Ville Skyttä <[email protected]>

miss-islington added a commit that referenced this pull request

Aug 13, 2018


          smtplib documentation fixes (GH-8708)

4ee06b3

* SMTP.startssl: Fix doc on keyfile and certfile use

* SMTP.startssl: Add missing keyfile and certfile deprecation notice

* SMTP: Doc grammar fixes
(cherry picked from commit da12063)

Co-authored-by: Ville Skyttä <[email protected]>

miss-islington added a commit that referenced this pull request

Aug 13, 2018


          smtplib documentation fixes (GH-8708)

6c14060

* SMTP.startssl: Fix doc on keyfile and certfile use

* SMTP.startssl: Add missing keyfile and certfile deprecation notice

* SMTP: Doc grammar fixes
(cherry picked from commit da12063)

Co-authored-by: Ville Skyttä <[email protected]>

scop deleted the smtplib-docs branch

August 15, 2018 06:18

carljm added a commit to carljm/cpython that referenced this pull request

Aug 19, 2018


          Merge branch 'master' into cached-property

977ece0

* master: (107 commits)
  bpo-22057: Clarify eval() documentation (pythonGH-8812)
  bpo-34318: Convert deprecation warnings to errors in assertRaises() etc. (pythonGH-8623)
  bpo-22602: Raise an exception in the UTF-7 decoder for ill-formed sequences starting with "+". (pythonGH-8741)
  bpo-34415: Updated logging.Formatter docstring. (pythonGH-8811)
  bpo-34432: doc Mention complex and decimal.Decimal on str.format not about locales (pythonGH-8808)
  bpo-34381: refer to 'Running & Writing Tests' in README.rst (pythonGH-8797)
  Improve error message when mock.assert_has_calls fails (pythonGH-8205)
  Warn not to set SIGPIPE to SIG_DFL (python#6773)
  bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938 (pythonGH-8796)
  bpo-34418: Fix HTTPErrorProcessor documentation (pythonGH-8793)
  bpo-34391: Fix ftplib test for TLS 1.3 (pythonGH-8787)
  bpo-34217: Use lowercase for windows headers (pythonGH-8472)
  bpo-34395: Fix memory leaks caused by incautious usage of PyMem_Resize(). (pythonGH-8756)
  bpo-34405: Updated to OpenSSL 1.1.0i for Windows builds. (pythonGH-8775)
  bpo-34384: Fix os.readlink() on Windows (pythonGH-8740)
  closes bpo-34400: Fix undefined behavior in parsetok(). (pythonGH-4439)
  bpo-34399: 2048 bits RSA keys and DH params (python#8762)
  Make regular expressions in test_tasks.py raw strings. (pythonGH-8759)
  smtplib documentation fixes (pythonGH-8708)
  Fix misindented yaml in logging how to example (pythonGH-8604)
  ...

Reviewers

Mariatta

Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.