GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-34432: doc Mention complex and decimal.Decimal on str.format note… by andresdelfino · Pull Request #8808 · python/cpython

Conversation

andresdelfino commented Aug 18, 2018 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

… about locales

https://bugs.python.org/issue34432

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          bpo-34432: doc Mention complex and decimal.Decimal on str.format note…

999d635

… about locales

the-knights-who-say-ni added the CLA signed label

Aug 18, 2018

bedevere-bot added docs

Documentation in the Doc dir

awaiting review labels

Aug 18, 2018

ericvsmith requested changes

Aug 18, 2018

View reviewed changes

ericvsmith left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks in advance for the also making the unrelated change (see my comment).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/stdtypes.rst Outdated

		temporary change affects other threads.
		When formatting a number (:class:`int`, :class:`float`, :class:`complex`,
		:class:`decimal.Decimal` and subclasses) with the ``n`` type
		(ex: ``'{:n}'.format(1234)``), the function sets temporarily the

ericvsmith Aug 18, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long you're editing this, could you change "sets temporarily" to "temporarily sets"?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

andresdelfino Aug 18, 2018

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting changes and removed awaiting review labels

Aug 18, 2018

bedevere-bot commented Aug 18, 2018

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericvsmith added needs backport to 3.6 skip news labels

Aug 18, 2018


          "sets temporarily" to "temporarily sets"

86e5f76

andresdelfino commented Aug 18, 2018

Copy link

Copy Markdown

Contributor Author

I have made the requested changes; please review again

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting change review and removed awaiting changes labels

Aug 18, 2018

bedevere-bot commented Aug 18, 2018

Copy link

Copy Markdown

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericvsmith approved these changes

Aug 18, 2018

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels

Aug 18, 2018

ericvsmith merged commit 93b5655 into python:master

Aug 18, 2018

miss-islington commented Aug 18, 2018

Copy link

Copy Markdown

Contributor

Thanks @andresdelfino for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Aug 18, 2018

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 18, 2018


          bpo-34432: doc Mention complex and decimal.Decimal on str.format not …

aeb502a

…about locales (pythonGH-8808)

(cherry picked from commit 93b5655)

Co-authored-by: Andrés Delfino <[email protected]>

bedevere-bot removed the needs backport to 3.7 label

Aug 18, 2018

bedevere-bot commented Aug 18, 2018

Copy link

Copy Markdown

GH-8809 is a backport of this pull request to the 3.7 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Aug 18, 2018

Copy link

Copy Markdown

GH-8810 is a backport of this pull request to the 3.6 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.6 label

Aug 18, 2018

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 18, 2018


          bpo-34432: doc Mention complex and decimal.Decimal on str.format not …

9e82612

…about locales (pythonGH-8808)

(cherry picked from commit 93b5655)

Co-authored-by: Andrés Delfino <[email protected]>

andresdelfino deleted the str.format-locale branch

August 18, 2018 17:45

ericvsmith pushed a commit that referenced this pull request

Aug 18, 2018


          bpo-34432: doc Mention complex and decimal.Decimal on str.format not …

fbd0a14

…about locales (GH-8808) (GH-8810)

(cherry picked from commit 93b5655)

Co-authored-by: Andrés Delfino <[email protected]>

ericvsmith pushed a commit that referenced this pull request

Aug 18, 2018


          bpo-34432: doc Mention complex and decimal.Decimal on str.format note…

0fd6f83

… about locales (GH-8808) (GH-8809)

(cherry picked from commit 93b5655)

Co-authored-by: Andrés Delfino <[email protected]>

carljm added a commit to carljm/cpython that referenced this pull request

Aug 19, 2018


          Merge branch 'master' into cached-property

977ece0

* master: (107 commits)
  bpo-22057: Clarify eval() documentation (pythonGH-8812)
  bpo-34318: Convert deprecation warnings to errors in assertRaises() etc. (pythonGH-8623)
  bpo-22602: Raise an exception in the UTF-7 decoder for ill-formed sequences starting with "+". (pythonGH-8741)
  bpo-34415: Updated logging.Formatter docstring. (pythonGH-8811)
  bpo-34432: doc Mention complex and decimal.Decimal on str.format not about locales (pythonGH-8808)
  bpo-34381: refer to 'Running & Writing Tests' in README.rst (pythonGH-8797)
  Improve error message when mock.assert_has_calls fails (pythonGH-8205)
  Warn not to set SIGPIPE to SIG_DFL (python#6773)
  bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938 (pythonGH-8796)
  bpo-34418: Fix HTTPErrorProcessor documentation (pythonGH-8793)
  bpo-34391: Fix ftplib test for TLS 1.3 (pythonGH-8787)
  bpo-34217: Use lowercase for windows headers (pythonGH-8472)
  bpo-34395: Fix memory leaks caused by incautious usage of PyMem_Resize(). (pythonGH-8756)
  bpo-34405: Updated to OpenSSL 1.1.0i for Windows builds. (pythonGH-8775)
  bpo-34384: Fix os.readlink() on Windows (pythonGH-8740)
  closes bpo-34400: Fix undefined behavior in parsetok(). (pythonGH-4439)
  bpo-34399: 2048 bits RSA keys and DH params (python#8762)
  Make regular expressions in test_tasks.py raw strings. (pythonGH-8759)
  smtplib documentation fixes (pythonGH-8708)
  Fix misindented yaml in logging how to example (pythonGH-8604)
  ...

Reviewers

ericvsmith

ericvsmith approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

andresdelfino commented Aug 18, 2018 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericvsmith left a comment

Choose a reason for hiding this comment

Uh oh!

ericvsmith Aug 18, 2018

Choose a reason for hiding this comment

Uh oh!

andresdelfino Aug 18, 2018

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Aug 18, 2018

Uh oh!

andresdelfino commented Aug 18, 2018

Uh oh!

bedevere-bot commented Aug 18, 2018

Uh oh!

miss-islington commented Aug 18, 2018

Uh oh!

bedevere-bot commented Aug 18, 2018

Uh oh!

bedevere-bot commented Aug 18, 2018

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

andresdelfino commented Aug 18, 2018 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.