Copy link

Copy Markdown

Contributor

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   82.38%   82.38%   +<.01%     
==========================================
  Files        1428     1428              
  Lines      351138   351138              
==========================================
+ Hits       289282   289292      +10     
+ Misses      61856    61846      -10

berkerpeksag reviewed Feb 14, 2017

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

berkerpeksag approved these changes Feb 14, 2017

View reviewed changes

"appears to not work in all cases" does not inspire confidence in this
module. I can find no context for what bug this was referencing so it
should be removed.
(cherry picked from commit 6de2b78)

"appears to not work in all cases" does not inspire confidence in this
module. I can find no context for what bug this was referencing so it
should be removed.
(cherry picked from commit 6de2b78)

"appears to not work in all cases" does not inspire confidence in this
module. I can find no context for what bug this was referencing so it
should be removed.
(cherry picked from commit 6de2b78)

"appears to not work in all cases" does not inspire confidence in this
module. I can find no context for what bug this was referencing so it
should be removed.
(cherry picked from commit 6de2b78)

…ets.

Unbinding (tasklet.bind(None) ) of main tasklets caused an assertion violation.
Now it raises RuntimError.

https://bitbucket.org/stackless-dev/stackless/issues/90
(grafted from 58b930a8a1d931da2f5bc834681af5d1452e1733 and 46335aa61c7c)

Update the readme indicating that the PR will be assigned to the
core dev for follow up.

Implements scripts/w45_bridge_drift_falsifier.sh per
docs/w45-bridge-signature-drift-falsifier.md.

Mutate-Build-Verify-Restore loop:
- Mutates a bridge signature (extern "C" decl in builder.cpp + function
  definition in builder_emit_c.c, in lockstep) by appending a sentinel
  param 'int phx_w45_drift'.
- Verifies the build fails at the C++ dispatch-switch call site (which
  has the OLD arity).
- Restores both files; clean rebuild verifies tree state.

Catches the structural drift class identified by pythia python#90/python#91:
void* args at the bridge crossing erase the type-safety C++ overload
resolution would normally provide. 252+ dispatch sites in builder.cpp
post Phase 1 burndown — manual audit unscalable.

Initial 6 fixtures (per spec §2.2 + §2.6 retro):
- hir_builder_emit_before_with_c (Phase 1 python#6 retro)
- hir_builder_emit_setup_with_c (Phase 1 python#7 retro)
- hir_builder_emit_format_simple_c (Phase 1 python#2 sample)
- hir_builder_emit_copy_free_vars_c (Phase 1 python#4 sample)
- hir_builder_emit_get_yield_from_iter_c (Phase 1 python#4 sample)
- hir_builder_emit_primitive_load_const_c (Phase 1 python#5 sample)

Modes:
- --dry-run: stage mutations, no build (any agent — bypass build lock)
- --strict: exit 1 on FAIL (for gate integration)
- --verbose: show build stderr

Uses perl -0777 multi-line slurp for robust parsing of multi-line
extern decls + function definitions. Mutation marker (phx_w45_drift)
verified post-mutation to guard against silent no-op substitutions.

Build lock: BUILD mode invokes cmake --build --target jit; per CLAUDE.md
Phase 3D Build Lock, only testkeeper / gate_phoenix.sh may invoke with
builds enabled. --dry-run is unrestricted.

Authorization: theologian 21:55:24Z + supervisor 21:55:36Z + 22:33:17Z
DISPOSITION (C). §3.5 fold-into-C derivation falsifier (opcode-constant
shadow class) is deferred — needs W21 golden integration.

Sibling workstreams: W33 (zero-bridge verifier), W42 (refcount
correctness), W44 (DO-NOT-USE caller gate).

Per testkeeper 22:44:12Z STRICT VERIFY: BUILD MODE was running
'cmake --build .' from REPO_ROOT, but cmake build dir is
Python/jit_build/build. All 6 fixtures errored with "not a CMake build
directory" → counted as FAIL → false GATE FAIL.

Fix: introduce CMAKE_BUILD_DIR variable + pass to both cmake calls
(per-fixture build at L153, post-restore rebuild at L194).

Concept already EMPIRICALLY VERIFIED by testkeeper manual sanity-test
on hir_builder_emit_format_simple_c — build failed at builder.cpp:2492
with "no matching function" + "candidate function not viable: requires
4 arguments, but 3 were provided". Exact void*-arg-erasure detection
pythia python#90/python#91 named.

Post-fix expected: 6/6 PASS in BUILD MODE.