Copy link

Copy Markdown

Contributor

brettcannon reviewed Feb 14, 2017

View reviewed changes

Carreau force-pushed the betterimport branch from bd14cf2 to d3aff79 Compare February 14, 2017 18:27

brettcannon requested changes Feb 14, 2017

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brettcannon requested changes Feb 14, 2017

View reviewed changes

Carreau force-pushed the betterimport branch 2 times, most recently from 3f218f5 to 30a5055 Compare February 14, 2017 21:57

brettcannon requested changes Feb 14, 2017

View reviewed changes

Carreau force-pushed the betterimport branch from 30a5055 to 32e42aa Compare February 14, 2017 22:39

@@            Coverage Diff            @@
##             master      #91   +/-   ##
=========================================
  Coverage          ?   82.38%           
=========================================
  Files             ?     1428           
  Lines             ?   351163           
  Branches          ?        0           
=========================================
  Hits              ?   289314           
  Misses            ?    61849           
  Partials          ?        0

Carreau force-pushed the betterimport branch from 32e42aa to 7456cfc Compare February 14, 2017 22:48

brettcannon approved these changes Feb 14, 2017

View reviewed changes

bpo-29546: Set the 'path' attribute on ImportError for ``from ... import ...``.

Carreau deleted the betterimport branch February 15, 2017 00:08

Add location information like canonical module name where identifier
cannot be found and file location if available.

First iteration of this was pythongh-91

…ursion depth

Reset the recursion depth in PyTasklet_BindEx and add a few asserts.
This fixes issue python#91.
Add a test case for the recursion depth and as test case for an assertion failure caused by this bug.

https://bitbucket.org/stackless-dev/stackless/issues/91
(grafted from 1584a89fca366f66dadf3cf04f0306dd45b1372f and 380b70b1933d)

Implements scripts/w45_bridge_drift_falsifier.sh per
docs/w45-bridge-signature-drift-falsifier.md.

Mutate-Build-Verify-Restore loop:
- Mutates a bridge signature (extern "C" decl in builder.cpp + function
  definition in builder_emit_c.c, in lockstep) by appending a sentinel
  param 'int phx_w45_drift'.
- Verifies the build fails at the C++ dispatch-switch call site (which
  has the OLD arity).
- Restores both files; clean rebuild verifies tree state.

Catches the structural drift class identified by pythia python#90/python#91:
void* args at the bridge crossing erase the type-safety C++ overload
resolution would normally provide. 252+ dispatch sites in builder.cpp
post Phase 1 burndown — manual audit unscalable.

Initial 6 fixtures (per spec §2.2 + §2.6 retro):
- hir_builder_emit_before_with_c (Phase 1 python#6 retro)
- hir_builder_emit_setup_with_c (Phase 1 python#7 retro)
- hir_builder_emit_format_simple_c (Phase 1 python#2 sample)
- hir_builder_emit_copy_free_vars_c (Phase 1 python#4 sample)
- hir_builder_emit_get_yield_from_iter_c (Phase 1 python#4 sample)
- hir_builder_emit_primitive_load_const_c (Phase 1 python#5 sample)

Modes:
- --dry-run: stage mutations, no build (any agent — bypass build lock)
- --strict: exit 1 on FAIL (for gate integration)
- --verbose: show build stderr

Uses perl -0777 multi-line slurp for robust parsing of multi-line
extern decls + function definitions. Mutation marker (phx_w45_drift)
verified post-mutation to guard against silent no-op substitutions.

Build lock: BUILD mode invokes cmake --build --target jit; per CLAUDE.md
Phase 3D Build Lock, only testkeeper / gate_phoenix.sh may invoke with
builds enabled. --dry-run is unrestricted.

Authorization: theologian 21:55:24Z + supervisor 21:55:36Z + 22:33:17Z
DISPOSITION (C). §3.5 fold-into-C derivation falsifier (opcode-constant
shadow class) is deferred — needs W21 golden integration.

Sibling workstreams: W33 (zero-bridge verifier), W42 (refcount
correctness), W44 (DO-NOT-USE caller gate).

Per testkeeper 22:44:12Z STRICT VERIFY: BUILD MODE was running
'cmake --build .' from REPO_ROOT, but cmake build dir is
Python/jit_build/build. All 6 fixtures errored with "not a CMake build
directory" → counted as FAIL → false GATE FAIL.

Fix: introduce CMAKE_BUILD_DIR variable + pass to both cmake calls
(per-fixture build at L153, post-restore rebuild at L194).

Concept already EMPIRICALLY VERIFIED by testkeeper manual sanity-test
on hir_builder_emit_format_simple_c — build failed at builder.cpp:2492
with "no matching function" + "candidate function not viable: requires
4 arguments, but 3 were provided". Exact void*-arg-erasure detection
pythia python#90/python#91 named.

Post-fix expected: 6/6 PASS in BUILD MODE.