GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] gh-80254: Disallow recursive usage of cursors in `sqlite3` converters by erlend-aasland · Pull Request #92278 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 3, 2022

Copy link
Copy Markdown
Contributor

(cherry picked from commit c908dc5)

Co-authored-by: Sergey Fedoseev [email protected]
Co-authored-by: Jelle Zijlstra [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland @sir-sigurd @JelleZijlstra
[3.9] pythongh-80254: Disallow recursive usage of cursors in `sqlite3…
a5b9786 
…` converters

(cherry picked from commit c908dc5)

Co-authored-by: Sergey Fedoseev <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner May 3, 2022 23:55
@bedevere-bot bedevere-bot added the awaiting review label May 3, 2022
@erlend-aasland
erlend-aasland requested a review from JelleZijlstra May 3, 2022 23:56
JelleZijlstra
JelleZijlstra approved these changes May 4, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 4, 2022
@JelleZijlstra JelleZijlstra self-assigned this May 4, 2022
@JelleZijlstra JelleZijlstra added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 4, 2022
@bedevere-bot

bedevere-bot commented May 4, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit a5b9786 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 4, 2022
erlend-aasland added 2 commits May 4, 2022 18:25
@erlend-aasland
Fix ref leak in pysqlite_cursor_iternext
41a21db
@erlend-aasland
Explicitly free resources at test tearDown()
8e5fe56
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2022
@bedevere-bot

bedevere-bot commented May 5, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 8e5fe56 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2022
@erlend-aasland

erlend-aasland commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

For 3.9, 3.8, and 3.7, the cursor is not deallocated implicitly. I checked the code coverage, and the cursor dealloc function never run. Explicitly deleting the cursor in tearDown ensures proper cleanup.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced May 5, 2022
gh-80254: Disallow recursive usage of cursors in sqlite3 converters #29054
Merged
sqlite crashes with converters mutating cursor #80254
Closed
JelleZijlstra
JelleZijlstra approved these changes May 5, 2022
View reviewed changes
@JelleZijlstra
JelleZijlstra merged commit 7d17a7b into python:3.9 May 5, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 5, 2022
@erlend-aasland
erlend-aasland deleted the backport-sqlite-converter-segfault-3.9 branch May 5, 2022 20:24
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@erlend-aasland @hello-adam
[3.9] pythongh-80254: Disallow recursive usage of cursors in `sqlite3…
968e51d 
…` converters (python#92278)

* [3.9] pythongh-80254: Disallow recursive usage of cursors in `sqlite3` converters

(cherry picked from commit c908dc5)

Co-authored-by: Sergey Fedoseev <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>

* Fix ref leak in pysqlite_cursor_iternext

* Explicitly free resources at test tearDown()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.